From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B5F6A051A; Fri, 17 Jan 2020 04:08:17 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 348691D54F; Fri, 17 Jan 2020 04:08:16 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id D4AEB1D522 for ; Fri, 17 Jan 2020 04:08:14 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jan 2020 19:08:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,328,1574150400"; d="scan'208";a="214333735" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga007.jf.intel.com with ESMTP; 16 Jan 2020 19:08:13 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Jan 2020 19:08:07 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Jan 2020 19:08:06 -0800 Received: from shsmsx106.ccr.corp.intel.com ([169.254.10.139]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.197]) with mapi id 14.03.0439.000; Fri, 17 Jan 2020 11:08:04 +0800 From: "Zhu, TaoX" To: "Xing, Beilei" , "Zhang, Qi Z" CC: "dev@dpdk.org" , "Yang, Qiming" , "Ye, Xiaolong" Thread-Topic: [PATCH v5] net/i40e: add PF MDD event handler Thread-Index: AQHVzOIKBC4S7m9hbEa4jzVykS2MpKfuK/oA Date: Fri, 17 Jan 2020 03:08:04 +0000 Message-ID: <60652C6914E08D41B9AA1580751B3CA9C291A5@SHSMSX106.ccr.corp.intel.com> References: <20191209135928.31697-1-taox.zhu@intel.com> <20200117112422.7214-1-taox.zhu@intel.com> In-Reply-To: <20200117112422.7214-1-taox.zhu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5] net/i40e: add PF MDD event handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi ALL, The name of patch subject has forgotten to be modified. Please ignore this = patch and I will resend it. BR, Zhu, Tao > -----Original Message----- > From: Zhu, TaoX > Sent: Friday, January 17, 2020 7:24 PM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Yang, Qiming ; Ye, Xiaolong > ; Zhu, TaoX > Subject: [PATCH v5] net/i40e: add PF MDD event handler >=20 > From: Zhu Tao >=20 > Add warning and counter to handle the malicious driver detection event. > When the hardware determines that a malicious driver on VF, this VF will > become unworkable, the PF records and gives a warning message. >=20 > Signed-off-by: Zhu Tao > Acked-by: Qiming Yang > --- > doc/guides/nics/i40e.rst | 1 + > doc/guides/rel_notes/release_20_02.rst | 4 +- > drivers/net/i40e/i40e_ethdev.c | 89 +++++++++++++++++++++++++- > drivers/net/i40e/i40e_ethdev.h | 1 + > 4 files changed, 92 insertions(+), 3 deletions(-) >=20 > v6: > - Change commit message > v5: > - Change commit message > v4: > - Change commit message > - Rebase doc/guides/rel_notes/release_20_02.rst > v3: > - Change commit message >=20 > diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index > c7c34b62f..2bf11e8ca 100644 > --- a/doc/guides/nics/i40e.rst > +++ b/doc/guides/nics/i40e.rst > @@ -43,6 +43,7 @@ Features of the i40e PMD are: > - Dynamic Device Personalization (DDP) > - Queue region configuration > - Virtual Function Port Representors > +- Malicious Device Drive event catch and notify >=20 > Prerequisites > ------------- > diff --git a/doc/guides/rel_notes/release_20_02.rst > b/doc/guides/rel_notes/release_20_02.rst > index 1e83e659a..a39f22221 100644 > --- a/doc/guides/rel_notes/release_20_02.rst > +++ b/doc/guides/rel_notes/release_20_02.rst > @@ -66,11 +66,13 @@ New Features >=20 > * Added support for RSS using L3/L4 source/destination only. >=20 > -* **Updated i40e driver to support L2TPv3 over IP flows.** > +* **Updated i40e driver.** >=20 > Updated the i40e PMD to support L2TPv3 over IP profiles which can be > programmed by the dynamic device personalization (DDP) process. >=20 > + Added PF support Malicious Device Drive event catch and notify. > + > * **Updated testpmd to support L2TPv3 over IP flows.** >=20 > Added support for L2TPv3 over IP rte_flow patterns to the testpmd diff= -- > git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c > index afb6f554b..95bfed4d9 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -6760,6 +6760,87 @@ i40e_dev_handle_aq_msg(struct rte_eth_dev > *dev) > rte_free(info.msg_buf); > } >=20 > +static void > +i40e_handle_mdd_event(struct rte_eth_dev *dev) { > + struct i40e_hw *hw =3D I40E_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > + struct i40e_pf *pf =3D I40E_DEV_PRIVATE_TO_PF(dev->data- > >dev_private); > + bool mdd_detected =3D false; > + struct i40e_pf_vf *vf; > + uint32_t reg; > + int i; > + > + /* find what triggered the MDD event */ > + reg =3D I40E_READ_REG(hw, I40E_GL_MDET_TX); > + if (reg & I40E_GL_MDET_TX_VALID_MASK) { > + uint8_t pf_num =3D (reg & > I40E_GL_MDET_TX_PF_NUM_MASK) >> > + I40E_GL_MDET_TX_PF_NUM_SHIFT; > + uint16_t vf_num =3D (reg & > I40E_GL_MDET_TX_VF_NUM_MASK) >> > + I40E_GL_MDET_TX_VF_NUM_SHIFT; > + uint8_t event =3D (reg & I40E_GL_MDET_TX_EVENT_MASK) >> > + I40E_GL_MDET_TX_EVENT_SHIFT; > + uint16_t queue =3D ((reg & > I40E_GL_MDET_TX_QUEUE_MASK) >> > + I40E_GL_MDET_TX_QUEUE_SHIFT) - > + hw->func_caps.base_queue; > + PMD_DRV_LOG(WARNING, "Malicious Driver Detection > event 0x%02x on TX " > + "queue %d PF number 0x%02x VF number 0x%02x > device %s\n", > + event, queue, pf_num, vf_num, dev->data- > >name); > + I40E_WRITE_REG(hw, I40E_GL_MDET_TX, 0xffffffff); > + mdd_detected =3D true; > + } > + reg =3D I40E_READ_REG(hw, I40E_GL_MDET_RX); > + if (reg & I40E_GL_MDET_RX_VALID_MASK) { > + uint8_t func =3D (reg & > I40E_GL_MDET_RX_FUNCTION_MASK) >> > + I40E_GL_MDET_RX_FUNCTION_SHIFT; > + uint8_t event =3D (reg & I40E_GL_MDET_RX_EVENT_MASK) >> > + I40E_GL_MDET_RX_EVENT_SHIFT; > + uint16_t queue =3D ((reg & > I40E_GL_MDET_RX_QUEUE_MASK) >> > + I40E_GL_MDET_RX_QUEUE_SHIFT) - > + hw->func_caps.base_queue; > + > + PMD_DRV_LOG(WARNING, "Malicious Driver Detection > event 0x%02x on RX " > + "queue %d of function 0x%02x device %s\n", > + event, queue, func, dev->data- > >name); > + I40E_WRITE_REG(hw, I40E_GL_MDET_RX, 0xffffffff); > + mdd_detected =3D true; > + } > + > + if (mdd_detected) { > + reg =3D I40E_READ_REG(hw, I40E_PF_MDET_TX); > + if (reg & I40E_PF_MDET_TX_VALID_MASK) { > + I40E_WRITE_REG(hw, I40E_PF_MDET_TX, 0xFFFF); > + PMD_DRV_LOG(WARNING, "TX driver issue > detected on PF\n"); > + } > + reg =3D I40E_READ_REG(hw, I40E_PF_MDET_RX); > + if (reg & I40E_PF_MDET_RX_VALID_MASK) { > + I40E_WRITE_REG(hw, I40E_PF_MDET_RX, 0xFFFF); > + PMD_DRV_LOG(WARNING, "RX driver issue > detected on PF\n"); > + } > + } > + > + /* see if one of the VFs needs its hand slapped */ > + for (i =3D 0; i < pf->vf_num && mdd_detected; i++) { > + vf =3D &pf->vfs[i]; > + reg =3D I40E_READ_REG(hw, I40E_VP_MDET_TX(i)); > + if (reg & I40E_VP_MDET_TX_VALID_MASK) { > + I40E_WRITE_REG(hw, I40E_VP_MDET_TX(i), 0xFFFF); > + vf->num_mdd_events++; > + PMD_DRV_LOG(WARNING, "TX driver issue > detected on VF %d %-" > + PRIu64 "times\n", > + i, vf->num_mdd_events); > + } > + > + reg =3D I40E_READ_REG(hw, I40E_VP_MDET_RX(i)); > + if (reg & I40E_VP_MDET_RX_VALID_MASK) { > + I40E_WRITE_REG(hw, I40E_VP_MDET_RX(i), 0xFFFF); > + vf->num_mdd_events++; > + PMD_DRV_LOG(WARNING, "RX driver issue > detected on VF %d %-" > + PRIu64 "times\n", > + i, vf->num_mdd_events); > + } > + } > +} > + > /** > * Interrupt handler triggered by NIC for handling > * specific interrupt. > @@ -6792,8 +6873,10 @@ i40e_dev_interrupt_handler(void *param) > } > if (icr0 & I40E_PFINT_ICR0_ECC_ERR_MASK) > PMD_DRV_LOG(ERR, "ICR0: unrecoverable ECC error"); > - if (icr0 & I40E_PFINT_ICR0_MAL_DETECT_MASK) > + if (icr0 & I40E_PFINT_ICR0_MAL_DETECT_MASK) { > PMD_DRV_LOG(ERR, "ICR0: malicious programming > detected"); > + i40e_handle_mdd_event(dev); > + } > if (icr0 & I40E_PFINT_ICR0_GRST_MASK) > PMD_DRV_LOG(INFO, "ICR0: global reset requested"); > if (icr0 & I40E_PFINT_ICR0_PCI_EXCEPTION_MASK) > @@ -6837,8 +6920,10 @@ i40e_dev_alarm_handler(void *param) > goto done; > if (icr0 & I40E_PFINT_ICR0_ECC_ERR_MASK) > PMD_DRV_LOG(ERR, "ICR0: unrecoverable ECC error"); > - if (icr0 & I40E_PFINT_ICR0_MAL_DETECT_MASK) > + if (icr0 & I40E_PFINT_ICR0_MAL_DETECT_MASK) { > PMD_DRV_LOG(ERR, "ICR0: malicious programming > detected"); > + i40e_handle_mdd_event(dev); > + } > if (icr0 & I40E_PFINT_ICR0_GRST_MASK) > PMD_DRV_LOG(INFO, "ICR0: global reset requested"); > if (icr0 & I40E_PFINT_ICR0_PCI_EXCEPTION_MASK) > diff --git a/drivers/net/i40e/i40e_ethdev.h > b/drivers/net/i40e/i40e_ethdev.h index bba2b83b4..370e6298f 100644 > --- a/drivers/net/i40e/i40e_ethdev.h > +++ b/drivers/net/i40e/i40e_ethdev.h > @@ -426,6 +426,7 @@ struct i40e_pf_vf { > /* version of the virtchnl from VF */ > struct virtchnl_version_info version; > uint32_t request_caps; /* offload caps requested from VF */ > + uint64_t num_mdd_events; /* num of mdd events detected */ >=20 > /* > * Variables for store the arrival timestamp of VF messages. > -- > 2.17.1