DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Hunt, David" <david.hunt@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] JSON compilation in examples/vm_power_manager
Date: Thu, 01 Nov 2018 15:39:41 +0100	[thread overview]
Message-ID: <6068126.IEL2K3QhUc@xps> (raw)
In-Reply-To: <a0bba2b5-52ba-fa7e-4ca2-fc8932a27dfa@intel.com>

01/11/2018 15:26, Hunt, David:
> Hi Thomas,
> 
> 
> On 1/11/2018 10:47 AM, Thomas Monjalon wrote:
> > Hi Dave,
> >
> > In examples/vm_power_manager/Makefile, jansson lib availability
> > is detected with pkg-config --exists.
> > As we have seen for telemetry lib, we can detect jansson
> > for the wrong arch and enable it no matter the arch being compiled.
> >
> > The solution was to disable it in Makefile and use meson for
> > reliable dependency detection.
> >
> > Would you like to do the same for this app?
> >
> >
> 
> I would prefer that if the user is cross compiling or selecting a 
> different target, that they
> set up their environment variables correctly for compilation. In this 
> case, the user should set
> PKG_CONFIG_LIBDIR to point to the relevant library folder, e.g. for an 
> i386 build:
> 
> export PKG_CONFIG_LIBDIR=/usr/lib/i386-linux-gnu/pkgconfig
> 
> That way the Makefile will pick up the correct library if it's present, 
> and build without the library
> if it is not present.
> 
> Also, if DPDK is being built natively on a machine, the makefile should 
> be fine as it is.
> 
> So, how about I create a patch to add a few lines to the docs around 
> compilation
> describing how to set up PKG_CONFIG_LIBDIR correctly for the 
> vm_power_manager
> sample app?

I think it was the solution I thought about for telemetry.
But in the case of multilib installation (x86_64/i686),
we do not have such separate directory.
I think the only reliable solution is to test compilation
as autotools or meson do.

  reply	other threads:[~2018-11-01 14:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-01 10:47 Thomas Monjalon
2018-11-01 14:26 ` Hunt, David
2018-11-01 14:39   ` Thomas Monjalon [this message]
2018-11-01 14:59     ` Richardson, Bruce
2018-11-01 15:12       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6068126.IEL2K3QhUc@xps \
    --to=thomas@monjalon.net \
    --cc=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).