From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id E67F858FA for ; Thu, 1 Nov 2018 15:39:44 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6CB8821FF8; Thu, 1 Nov 2018 10:39:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 01 Nov 2018 10:39:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=JKUvKcuPhw7lkRSAziew800R5jbh7SqqRdN8Kvna9Oc=; b=DhgwQIdXzRzr br9B8hIWjCpArJH0/2SUP5hicg5vftodjqHUpZG108HLHrlh5ULIgcQZsZuEkAIq 1LiKd+BYqSOtRrtY6OtjQI5ZAXPhvc9Kho7zjjnMMl6skn2X3YR4roEvifSNplxk JdJoIZpqSW5UItbxIR7licaDWBNDMTI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=JKUvKcuPhw7lkRSAziew800R5jbh7SqqRdN8Kvna9 Oc=; b=w+igoBL3tbvy+z6kPkaWAZ1Kbz7GNgJ/X28wKSnHv3A1hChnoidy/MtaJ HspRiuCcG2FdDJUVW7zi9+u9ny5C//aIhrc6LNJembuMTuobVVqeVERJNxqeRrLt J8mJYxDqibX7GotAjbEhmN5kQqOkD3D6oI2DnQ1oHe7lVUyhm1ftNaCQBwaMFNwX GcEXLfYovh9IBiU9aZs68uZTOUoZyaJgwYpPsNXswZihJtD5BcaQXu5wL45zvsxt fdBQZpcmUk1adrRdJRYVYNZstmlBBPFwo1wT3mrgR0i4jmlkC1y++Md0cUEBZm5g 5qHzqQCk6ZkRgkf3AkRIo4kSs/9tA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D9876E467A; Thu, 1 Nov 2018 10:39:42 -0400 (EDT) From: Thomas Monjalon To: "Hunt, David" Cc: dev@dpdk.org Date: Thu, 01 Nov 2018 15:39:41 +0100 Message-ID: <6068126.IEL2K3QhUc@xps> In-Reply-To: References: <8756945.B50ulyzTOh@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] JSON compilation in examples/vm_power_manager X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 14:39:45 -0000 01/11/2018 15:26, Hunt, David: > Hi Thomas, > > > On 1/11/2018 10:47 AM, Thomas Monjalon wrote: > > Hi Dave, > > > > In examples/vm_power_manager/Makefile, jansson lib availability > > is detected with pkg-config --exists. > > As we have seen for telemetry lib, we can detect jansson > > for the wrong arch and enable it no matter the arch being compiled. > > > > The solution was to disable it in Makefile and use meson for > > reliable dependency detection. > > > > Would you like to do the same for this app? > > > > > > I would prefer that if the user is cross compiling or selecting a > different target, that they > set up their environment variables correctly for compilation. In this > case, the user should set > PKG_CONFIG_LIBDIR to point to the relevant library folder, e.g. for an > i386 build: > > export PKG_CONFIG_LIBDIR=/usr/lib/i386-linux-gnu/pkgconfig > > That way the Makefile will pick up the correct library if it's present, > and build without the library > if it is not present. > > Also, if DPDK is being built natively on a machine, the makefile should > be fine as it is. > > So, how about I create a patch to add a few lines to the docs around > compilation > describing how to set up PKG_CONFIG_LIBDIR correctly for the > vm_power_manager > sample app? I think it was the solution I thought about for telemetry. But in the case of multilib installation (x86_64/i686), we do not have such separate directory. I think the only reliable solution is to test compilation as autotools or meson do.