From: Thomas Monjalon <thomas@monjalon.net>
To: Thierry Herbelot <thierry.herbelot@6wind.com>
Cc: dev@dpdk.org, "jerinj@marvell.com" <jerinj@marvell.com>,
"Honnappa Nagarahalli" <Honnappa.Nagarahalli@arm.com>,
"Juraj Linkeš" <juraj.linkes@pantheon.tech>, nd <nd@arm.com>,
"Ruifeng Wang" <Ruifeng.Wang@arm.com>
Subject: Re: [dpdk-dev] [PATCH V6] config/arm: add Qualcomm Centriq 2400 part number
Date: Fri, 09 Jul 2021 17:27:24 +0200 [thread overview]
Message-ID: <6068578.3c3vFoJOcf@thomas> (raw)
In-Reply-To: <AM5PR0802MB2465EC8E283D8906DC3FC3F69E0A9@AM5PR0802MB2465.eurprd08.prod.outlook.com>
21/06/2021 03:52, Ruifeng Wang:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 18/06/2021 10:53, Thierry Herbelot:
> > > On 6/18/21 10:51 AM, Thomas Monjalon wrote:
> > > > 18/06/2021 04:09, Ruifeng Wang:
> > > >> From: Thierry Herbelot <thierry.herbelot@6wind.com>
> > > >>> 'part_number_config': {
> > > >>> - '0xc00': {'machine_args': ['-march=armv8-a+crc']}
> > > >>> + '0x800': {'machine_args': ['-march=armv8-a+crc']},
> > > >>> + '0xc00': {'machine_args': ['-march=armv8-a+crc']},
> > > >> Nit, redundant comma at the end of the line.
> > > >
> > > > What is redundant?
> > >
> > > The comma at the end of the second line is not necessary.
> >
> > It is a good practice to have comma like other lines, so no need to update this
> > line when adding more.
> >
> Looked at style in the rest of the file. Just wanted them to be aligned.
> I'm fine with a trailing comma at the last line.
>
> Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>
Applied, thanks
prev parent reply other threads:[~2021-07-09 15:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 8:16 [dpdk-dev] [PATCH] " Thierry Herbelot
2021-05-25 8:18 ` Thomas Monjalon
2021-05-25 8:24 ` [dpdk-dev] [PATCH v2] " Thierry Herbelot
2021-06-17 7:06 ` Thomas Monjalon
2021-06-17 7:21 ` David Marchand
2021-06-17 7:24 ` Ruifeng Wang
2021-06-17 7:28 ` Ruifeng Wang
2021-06-17 8:16 ` [dpdk-dev] [PATCH V3] " Thierry Herbelot
2021-06-17 10:03 ` Ruifeng Wang
2021-06-17 11:24 ` Thierry Herbelot
2021-06-17 14:46 ` Ruifeng Wang
2021-06-17 11:36 ` [dpdk-dev] [PATCH V4] " Thierry Herbelot
2021-06-17 11:44 ` [dpdk-dev] [PATCH V5] " Thierry Herbelot
2021-06-17 15:13 ` [dpdk-dev] [PATCH V6] " Thierry Herbelot
2021-06-18 2:09 ` Ruifeng Wang
2021-06-18 8:51 ` Thomas Monjalon
2021-06-18 8:53 ` Thierry Herbelot
2021-06-18 8:58 ` Thomas Monjalon
2021-06-21 1:52 ` Ruifeng Wang
2021-07-09 15:27 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6068578.3c3vFoJOcf@thomas \
--to=thomas@monjalon.net \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=juraj.linkes@pantheon.tech \
--cc=nd@arm.com \
--cc=thierry.herbelot@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).