From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCC5AA0548; Fri, 9 Jul 2021 17:27:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 43EA3410F9; Fri, 9 Jul 2021 17:27:29 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 07DBD4014D for ; Fri, 9 Jul 2021 17:27:28 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id A90605C00DE; Fri, 9 Jul 2021 11:27:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 09 Jul 2021 11:27:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= oBv93kz+a2mb4KRNAf6u9jvowVAe3nsxERQbNkqoAT8=; b=wN391UVuMr1RWIo2 sRS6iteRCmakEVZjrnIpf9Ac3WEa7otvS/FkykH3Kh2YT1CpKltjdU8ESgtRPVmc nXKksTlQVDfB3//QHNSJklXlJGuhKaf71jOmpv65RALTy+xmSSwMxWeDgbwPey0H YQuVmIu8UnwE4EeQoYGVRa80FXoQchW2U0jtfxKb9qctSgITT0ap+KysN8ISXrF3 qiyvStRUKp7eToPeUrRJ0JvOdZIFbrnPZymxREf4Ghxqm4rKvyfSdRytoVnrmO7z 1xOQ6CJaAvjBvDnvpBBsNawe/dcO/ilI9VbLtWy0o5HOlN/946E3mpwjxHMKtrBE Z3VpGg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=oBv93kz+a2mb4KRNAf6u9jvowVAe3nsxERQbNkqoA T8=; b=F26se/8OORtJ9pSidZDs3aWT+4uCPCHHnSnEmG2ErNuFIUIkVGFnT/Qsy b3j9c3kDh5nckN7VzGPAzoBJ44ZD11vac9rRaiyD9+k/QKc3VUa2JUeWWwM+FPtE JIfl7yrIWV+BxrhJlt2YPEZ5T8L42hKeDNtyqfvjc1qU20jdsEiR8gYA03AV6eSO o3YJxrRuWmBcv3YMi3fnolB6nUpRgHAQGWczRMb1A+Mfl855A4KCATdHrLZwleA4 r9xgpmPgklCoxNm+Tr8/Y2Q+s8Qvaup/wnck97ZYgPWew089znAIoGdo5tOEgiCC AhIHANn2E9Q9pbYjXm8csTG+gkBjQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrtdeigdekhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 9 Jul 2021 11:27:25 -0400 (EDT) From: Thomas Monjalon To: Thierry Herbelot Cc: dev@dpdk.org, "jerinj@marvell.com" , Honnappa Nagarahalli , Juraj =?utf-8?B?TGlua2XFoQ==?= , nd , Ruifeng Wang Date: Fri, 09 Jul 2021 17:27:24 +0200 Message-ID: <6068578.3c3vFoJOcf@thomas> In-Reply-To: References: <1b58faa5588ee2add217208ef10716ae78c4e52b.1623930249.git.thierry.herbelot@6wind.com> <3167957.VrzZcUUg0p@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH V6] config/arm: add Qualcomm Centriq 2400 part number X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 21/06/2021 03:52, Ruifeng Wang: > From: Thomas Monjalon > > 18/06/2021 10:53, Thierry Herbelot: > > > On 6/18/21 10:51 AM, Thomas Monjalon wrote: > > > > 18/06/2021 04:09, Ruifeng Wang: > > > >> From: Thierry Herbelot > > > >>> 'part_number_config': { > > > >>> - '0xc00': {'machine_args': ['-march=armv8-a+crc']} > > > >>> + '0x800': {'machine_args': ['-march=armv8-a+crc']}, > > > >>> + '0xc00': {'machine_args': ['-march=armv8-a+crc']}, > > > >> Nit, redundant comma at the end of the line. > > > > > > > > What is redundant? > > > > > > The comma at the end of the second line is not necessary. > > > > It is a good practice to have comma like other lines, so no need to update this > > line when adding more. > > > Looked at style in the rest of the file. Just wanted them to be aligned. > I'm fine with a trailing comma at the last line. > > Acked-by: Ruifeng Wang Applied, thanks