From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C877A0A02; Wed, 24 Mar 2021 21:00:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4EC4314101D; Wed, 24 Mar 2021 21:00:14 +0100 (CET) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by mails.dpdk.org (Postfix) with ESMTP id 9E6D1141011 for ; Wed, 24 Mar 2021 21:00:12 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id BADB1580CFB; Wed, 24 Mar 2021 16:00:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 24 Mar 2021 16:00:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= qX7OUOqT5TG0nAbHSwGfsn/Pu5/0rcGP6IN3HQXH66Q=; b=l7Ol3/bJIZL9W+dS rbJLKW3GnrijtDfSrpUBMW4v05a2c69bR5soucBxAioWvZFnuZywWm3yMF00Biku VEjtTut5oTQUGFLlx2eAv/fySq89E5ASlvADJ6/5BcMMnIreD8kW1/vk4vCngpeO ne05eE9FBUqg45fD3H1X0AJnfJkw+JTAQIDCub/qFeRl/PnZ5N3310Su7nIGXzau s23C/BDrb9XR8DW0HijOy9H5ZuJL6OvhfS0Ekg/SqnxUTrNWYZyvOA3yULxiIFYu AR5ZeuM8kq4FgdkLDKgwJopAD461tYYn+++o3PG9+p2kShxxIL7FrMgypEFuXnWq 43opWg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=qX7OUOqT5TG0nAbHSwGfsn/Pu5/0rcGP6IN3HQXH6 6Q=; b=Ac5DZikdEjugCNRxMLMUZMtTVVMUtsyhtFS6Dg8ygkWIuUhkZ6kNhZv3o egbauJ66ZKQHZqW3bZ+SKE5jrYz+6CJTBjTYmbdvqzSyrEJJurhCmx7dYbOrn6cZ eBryPq40DwZX5OcmCSzlINNJGwV/bm5EjQNSXFX5rPkmtPn3KSlBFu2mJ4EyK89T OCuZpOM9Y2UeaD2Qxp0v+fZbLPO2RamZFZdkZEYkJWlGcELPjapORHdfQiuxSIXJ 21wuZwi4hMcba+Fkv3hGusrsfk3KXR+9kRyFtB2XD1JniQaeMwjS0D1M4xoXIg93 KmThhvw7iVJBKTTwOpKzhIe12Qn9g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudegkedgudeftdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C2ED61080063; Wed, 24 Mar 2021 16:00:09 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Rosen Xu , Hemant Agrawal , Sachin Saxena , Jingjing Wu , Beilei Xing , Qiming Yang , Qi Zhang , Jeff Guo , Haiyue Wang Date: Wed, 24 Mar 2021 21:00:07 +0100 Message-ID: <6076825.RBgRJtLnUj@thomas> In-Reply-To: References: <20210311221742.3750589-1-thomas@monjalon.net> <20210321090002.595744-3-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 2/2] drivers/net: remove explicit include of legacy filtering X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/03/2021 19:08, Ferruh Yigit: > On 3/21/2021 9:00 AM, Thomas Monjalon wrote: > > The header file rte_eth_ctrl.h should not be needed because > > this legacy filtering API is completely replaced with the rte_flow API. > > However some definitions from this file are still used by some drivers, > > but such usage is already covered by an implicit include via rte_ethdev.h. > > > > Signed-off-by: Thomas Monjalon > > Acked-by: Rosen Xu > > Acked-by: Hemant Agrawal > > --- > > drivers/net/dpaa2/dpaa2_ptp.c | 1 - > > drivers/net/iavf/iavf_hash.c | 1 - > > drivers/net/ice/ice_acl_filter.c | 1 - > > drivers/net/ice/ice_hash.c | 1 - > > drivers/net/ice/ice_switch_filter.c | 1 - > > drivers/net/igc/igc_filter.h | 1 - > > drivers/net/ipn3ke/ipn3ke_flow.c | 1 - > > Although this will work, if the above drives are using the defines from the > header file, isn't it better to include it explicitly? > > What is the benefit of including the header implicitly? The benefit is to progressively remove rte_eth_ctrl.h. I want it to disappear.