From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BAE9A0C4E; Mon, 25 Oct 2021 17:10:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8BB3B40E32; Mon, 25 Oct 2021 17:10:49 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id CE41D4003E; Mon, 25 Oct 2021 17:10:47 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 47E9F5C0163; Mon, 25 Oct 2021 11:10:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 25 Oct 2021 11:10:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= XKxVvVx9Mzd/XsOn2Kg096r/OxjZqdPngVoW+EwJpoM=; b=n6Hs0TaKn3AG8qPm RH4dKywLv6V3KC0axBgOpzGj0Khu+RbXk3tu4yaZ+0Bhs5gfG0zB4ddVm3Vi8NMQ nmc4YRYqa1s8a3osFG6j06v6NHwGW1hrDH1bTb2mXBnT29D2t+jK+E09Q667aPjU A1xfEsCMPnc/IhJMPfA1vYUk2ZeGBiC1fyidBs4mXWs+eqHXoReyeepgsyIKPg2i hj+o215GcoHmLMkXj8qvTD6Y6KqUaBA/I0bwq4uGQHvMBGk2/YLkB/tTD2BrUZUI B4feWXWMjWLvqv3DPO/Jgp9VFIFtbkLX9EjW5M90vNgjnxSTRytTCYhKU8uUG0W9 XCuoeg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=XKxVvVx9Mzd/XsOn2Kg096r/OxjZqdPngVoW+EwJp oM=; b=ANOuThqHNhh4A5Wp38EUKqKqEJcjV8E8LpwkVqCmvrYzxjVCZhsmhwm8e DctDj0xtl06BIRL9CyzwJIX1dHvnmW+z+WNAiGBkCjn3vRvh5XqQnwnUK+oFLXYn oR0vSnVQjxMVNvtjZku1+eoKItDF0xTnjr6VQZ1PxPs1J7NwOPcCZ3hZR8Qp2X1i Jj79ecPRbKIl5bGL8tRURUoesYJQueVmBk5NqQJOrNyZQp6rptFNVbfgBWGzctFP iIHAXwaZ9ipCR3EUgA9io2PYQ1OLI9NTBmRk6To2ILr2SSrKjUjk0Day2edTMzQD vti9n4+3GJO5/OTLkcO3iwi/XDhOQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdefhedgheehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepueeuhfevheeuhfehkeekudefhfetheektdevjedufedvheetvedu tddutdfhudevnecuffhomhgrihhnpehphigtohguvghquhdrrghlnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Oct 2021 11:10:45 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, stable@dpdk.org, Neil Horman , Dmitry Kozlyuk , Stephen Hemminger , Bruce Richardson , Robin Jarry Date: Mon, 25 Oct 2021 17:10:43 +0200 Message-ID: <6080797.aUBtZAhkRH@thomas> In-Reply-To: <20211020193136.6tkty3fcxg4fk2ck@6wind.com> References: <20211019125230.27480-1-david.marchand@redhat.com> <20211020193136.6tkty3fcxg4fk2ck@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] usertools/pmdinfo: fix plugin auto scan X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/10/2021 21:31, Robin Jarry: > Hello, > > 2021-10-19, David Marchand: > > Migration to argparse was incomplete. > > > > $ dpdk-pmdinfo.py -p $(which dpdk-testpmd) > > Traceback (most recent call last): > > File "/usr/bin/dpdk-pmdinfo.py", line 626, in > > main() > > File "/usr/bin/dpdk-pmdinfo.py", line 596, in main > > exit(scan_for_autoload_pmds(args[0])) > > TypeError: 'Namespace' object does not support indexing > > > > Fixes: 81255f27c65c ("usertools: replace optparse with argparse") > > Cc: stable@dpdk.org > > > > Signed-off-by: David Marchand > > It is sad that pylint does not report an error: > > https://pycodequ.al/docs/pylint-messages/e1136-unsubscriptable-object.html > > Anyway, this fix looks good. > > Reviewed-by: Robin Jarry Applied, thanks.