From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 90C921D09F; Sun, 13 May 2018 23:17:25 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1908225BF4; Sun, 13 May 2018 17:17:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 13 May 2018 17:17:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=e3zQErRcSSWG4NgTFHWUdHNrWi VfiD/3REtsN6wp0wA=; b=Nttwu1/E8IRHHENEVG0LagRGBh0EyS+Or/L8+K4cOl aF7A0YqnD+Fjr3+tcTU3Isg4kUCBtAawEWE6klEypiKnmukPuE206yBTRZ2K247G zQogSkvoklHnv/biv9yXL2SIZfrG6ZHgP3XkfKn0aZfbgGEnVofkuc3QgTvZP86e w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=e3zQEr RcSSWG4NgTFHWUdHNrWiVfiD/3REtsN6wp0wA=; b=e5JBgUawMalbqhxCvSyoLI WKYdxf+CH3iMfrlP4wl83L0CCiUx9eV9OtsY77Qhd/e0kOBNX3g25Rokje2Y+Onb PD9ho56WjN1Iit8GddstcSbp0BJzb+ZNMr2drOP/eAdqKP/KoMBXz/zO14riPYQi CmbaOq8mhJ+zdaYuygGElas9p+22AeEr5tUHa1wwrRN8hqlPGha/VD7y86mCw+u2 qj91d1twInfomZUIqjDLBwQt/b/JS+LymvSNNrfw2r8mKG08ttbUTd93+8Q8QkJM v9O3yVWk41PfP7UL+b8srVJ9f4FzWaZnn1GpzGRAsXrCldv0xzfvaWY1bxvJM/SQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 640D2E4076; Sun, 13 May 2018 17:17:24 -0400 (EDT) From: Thomas Monjalon To: Reshma Pattan Cc: dev@dpdk.org, david.hunt@intel.com, stable@dpdk.org Date: Sun, 13 May 2018 23:17:23 +0200 Message-ID: <6086013.0aasqvtn8f@xps> In-Reply-To: <1525430826-17772-1-git-send-email-reshma.pattan@intel.com> References: <1525365403-32529-1-git-send-email-reshma.pattan@intel.com> <1525430826-17772-1-git-send-email-reshma.pattan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] app/test: fix reorder test failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 May 2018 21:17:25 -0000 04/05/2018 12:47, Reshma Pattan: > mbufs are being freed twice in error, once in rte_mempool_put_bulk() > and then in rte_reorder_free(). Refactor the code so that we use > rte_reorder_free() to free mbufs in the reorder buffer, and use > rte_pktmbuf_free() to free any unused or drained mbufs. > > Fixes: d0c9b58d71 ("app/test: new reorder unit test") > Cc: stable@dpdk.org backport > Cc: david.hunt@intel.com > Signed-off-by: Reshma Pattan > Reviewed-by: David Hunt Applied, thanks