From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB38EA04B1; Wed, 9 Sep 2020 12:51:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 02E031BF8D; Wed, 9 Sep 2020 12:51:55 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 42F12160 for ; Wed, 9 Sep 2020 12:51:53 +0200 (CEST) IronPort-SDR: 2LfcPzIAfvUpZrON2OY09WBwg9kqyRGLOQBZk//RFu+iNpk+4zcwa7+Vq+sotxnqUt5DttcGAh A8ejwf6HsR2Q== X-IronPort-AV: E=McAfee;i="6000,8403,9738"; a="146025466" X-IronPort-AV: E=Sophos;i="5.76,409,1592895600"; d="scan'208";a="146025466" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2020 03:51:51 -0700 IronPort-SDR: 9EOEXizu5ZYV4m1sve/xWZRlWVrZducocsGT3gIuJX+3pU+xmUKptT04e0JM83xcW4rQiTrttu NrhoEFP1EgjA== X-IronPort-AV: E=Sophos;i="5.76,409,1592895600"; d="scan'208";a="505413343" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.225.110]) ([10.213.225.110]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2020 03:51:50 -0700 To: Adam Dybkowski , dev@dpdk.org, fiona.trahe@intel.com, akhil.goyal@nxp.com, john.mcnamara@intel.com References: <20200908142047.331-1-adamx.dybkowski@intel.com> <20200908161950.601-1-adamx.dybkowski@intel.com> <20200908161950.601-2-adamx.dybkowski@intel.com> From: "Burakov, Anatoly" Message-ID: <6087c0a7-9321-d337-f5fb-57d93b8ac991@intel.com> Date: Wed, 9 Sep 2020 11:51:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200908161950.601-2-adamx.dybkowski@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/1] doc: document vfio-pci usage with QAT PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 08-Sep-20 5:19 PM, Adam Dybkowski wrote: > This patch marks the old igb-uio driver as unsecure when used > with the QAT PMD and updates all examples to recommend using > vfio-pci instead. > It also mentions security issues with the QAT CPM and provides > information about the new vfio-pci parameter 'disable_denylist' > available in Linux kernels 5.9 and later. > > Signed-off-by: Adam Dybkowski > Acked-by: Fiona Trahe > --- > > cd to the top-level DPDK directory > modprobe uio No need to modprobe uio if you're using VFIO. > - insmod ./build/kmod/igb_uio.ko > - echo "8086 37c9" > /sys/bus/pci/drivers/igb_uio/new_id > + modprobe vfio-pci > + echo "8086 37c9" > /sys/bus/pci/drivers/vfio-pci/new_id This seems like very outdated instructions from when we had a PCI ID filtering in igb_uio. Devbind way is better in every way, so why keep this at all? > lspci -vvd:37c9 > > +Use ``modprobe vfio-pci disable_denylist=1`` from kernel 5.9 onwards. > +See note in the section `Binding the available VFs to the vfio-pci driver`_ > +above. > > -Another way to bind the VFs to the DPDK UIO driver is by using the > +Another way to bind the VFs to the vfio-pci driver is by using the > ``dpdk-devbind.py`` script:: > > cd to the top-level DPDK directory > - ./usertools/dpdk-devbind.py -b igb_uio 0000:03:01.1 > + ./usertools/dpdk-devbind.py -b vfio-pci 0000:03:01.1 > > Testing > ~~~~~~~ > -- Thanks, Anatoly