From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75224A0528; Sat, 11 Jul 2020 15:46:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1DA671D954; Sat, 11 Jul 2020 15:46:09 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 57F5A1D654 for ; Sat, 11 Jul 2020 15:46:07 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 46592B33; Sat, 11 Jul 2020 09:46:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sat, 11 Jul 2020 09:46:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 6FRGvvQjIJxCD3+m1uyIElHlEvMwJx/5zSmRO/ND93c=; b=SUaTanUDqtzrufkb sihMdfHp1A1a+jvek7pQkCxPgiwFBoUP7YW3fk8m257URP2L28ydAb2tebv3BIJc 33avtgF0XbIMOl6LJGxSSV50fnNpVy/QsajtH0tycIMrNEwNaLV0M9/b0HNh2EXy aYl95PoiJkVxgocoJF74eJJ/eRHupbsF+rBdtzptiBvCsu+OSvs4MPMzkVZxMvaZ 8VyMlyo/3UeonZmynkmWbPkMlxgDhtzkgSQYgGZEAW85Kr7Ld8P9dmEOIHLyHltI e0oHeYzDGsfrL/E9EoKjuR4LLKZ8JEMrE2FgNdu4xt1q/dte1UdUdB1YQ9RSy4FW L0wd2Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=6FRGvvQjIJxCD3+m1uyIElHlEvMwJx/5zSmRO/ND9 3c=; b=d1xY/XHkloiirZZrmiEIVbu9ByRZ81Zo1cYE4I7YkR3dsrS/KE5ycQWnf mPm5wCoAvUjeOfDSZsdsevRucsM7PyqRf7yVHc7G5ecGREBjLUmcLz7NQ/oyvMDK OMCh966L6KjtTpvaSFtt4LRow11wGVAC6HP5glkPO5nEBm9WhwzEVqct5DzyUlBF /zH2wKAsIDupQDF8h+PO903fGq+xCmdXY9DCHZaj+gfy+Rxt44f/h6eqjjvdv0Y5 4Wg7CsjS0HLcvcd9kGO5Mz2CCVajFUevwCRNLHMgQftZ6/nDMtp0CG7FGrL7LM1L WTnZk4Dj789HNultg05EjEa1UtD8Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrvdefgdejtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C88C3328005D; Sat, 11 Jul 2020 09:46:02 -0400 (EDT) From: Thomas Monjalon To: Gagandeep Singh , Hemant Agrawal Cc: dev@dpdk.org, ferruh.yigit@intel.com Date: Sat, 11 Jul 2020 15:46:01 +0200 Message-ID: <6088092.f3ReCXcs2Y@thomas> In-Reply-To: <20200707092244.12791-4-hemant.agrawal@nxp.com> References: <20200527132326.1382-1-hemant.agrawal@nxp.com> <20200707092244.12791-1-hemant.agrawal@nxp.com> <20200707092244.12791-4-hemant.agrawal@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 03/29] net/dpaa2: enable timestamp for Rx offload case as well X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/07/2020 11:22, Hemant Agrawal: > From: Gagandeep Singh > > This patch enables the packet timestamping > conditionally when Rx offload is enabled for timestamp. > > Signed-off-by: Gagandeep Singh > --- > drivers/net/dpaa2/dpaa2_ethdev.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c > index a1f19194d..8edd4b3cd 100644 > --- a/drivers/net/dpaa2/dpaa2_ethdev.c > +++ b/drivers/net/dpaa2/dpaa2_ethdev.c > @@ -524,8 +524,10 @@ dpaa2_eth_dev_configure(struct rte_eth_dev *dev) > return ret; > } > > +#if !defined(RTE_LIBRTE_IEEE1588) > if (rx_offloads & DEV_RX_OFFLOAD_TIMESTAMP) > - dpaa2_enable_ts = true; > +#endif > + dpaa2_enable_ts = true; I don't understand this patch at all. There is no comment in the code, and the commit log is not very explanatory. You are lucky Ferruh is less strict than me. I remember I already said I was bored of the lack of explanations in NXP drivers.