From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 661E92BB8
 for <dev@dpdk.org>; Thu,  5 Apr 2018 12:22:44 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id DF0F421962;
 Thu,  5 Apr 2018 06:22:43 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Thu, 05 Apr 2018 06:22:43 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=xZ5w4FYK6Tp959bgReNoiy0vGL
 oDjKjXTE9FWGWgAJM=; b=RRohiXPMCY/UhLNGw3Vv1bvGVPi3nlvQRNO5K8L0A5
 tCZB4FpSJ0EgTlef49Ib2o4cJTA/Dot4DGsSJZVssWjEzgrYgUpCDYUD4TMm+pI8
 GZLUZfT8Lo6FCb6vr60AnHom30LT4K75MP0mcS8nJcgNQl52yjykv599HsK+mZL6
 4=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=xZ5w4F
 YK6Tp959bgReNoiy0vGLoDjKjXTE9FWGWgAJM=; b=XZVqm3aYdzFjYQvRAylgBx
 EZM+CtK/8cGnyYqX6c4otIeUzpq3HeIfQ/Mtz1nwZ7xUSVFgGdrF1T8hNJtABeMV
 of3dApOtgWBim0Wz5TWVlPPAuzyiqTmkCf9BrhmXrpmgzCwzKCDx4A2+7k1qh13R
 H8rbpSyrM+5Hinw2MqdeSlbkTHyBXoPWAxGnEzLZpS2o5qMOxsH9NHk4FpRBd3QE
 zKZu9nyRfo+pSR5Upn0VH3DK1Qzx3/89McvUe779FouHocCs5HuLN4Flg/iDt590
 sGIbmK+M9HrxYVij3SFL2jRADN/QY7YavcZUPdTXG9kcWppfUwj6jL27V2pmuQ7Q
 ==
X-ME-Sender: <xms:8_jFWlP4geOzVxRIlQiIWUiJ1ugF8A3YwuzDmD0_x0rnMakl8W2cYQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 4E12CE508D;
 Thu,  5 Apr 2018 06:22:43 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Wang, Xiao W" <xiao.w.wang@intel.com>
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "Burakov, Anatoly" <anatoly.burakov@intel.com>
Date: Thu, 05 Apr 2018 12:22:42 +0200
Message-ID: <60929980.gmd1JhcyUE@xps>
In-Reply-To: <B7F2E978279D1D49A3034B7786DACF406F86D36D@SHSMSX101.ccr.corp.intel.com>
References: <1522753815-28718-1-git-send-email-hemant.agrawal@nxp.com>
 <1522828120-16100-2-git-send-email-hemant.agrawal@nxp.com>
 <B7F2E978279D1D49A3034B7786DACF406F86D36D@SHSMSX101.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v5 2/2] eal/vfio: export internal vfio
	functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Apr 2018 10:22:44 -0000

05/04/2018 11:03, Wang, Xiao W:

> > +int rte_vfio_get_group_num(const char *sysfs_base, const char *dev_addr,
> > +			   int *iommu_group_num);
> > +int rte_vfio_get_container_fd(void);
> > +int rte_vfio_get_group_fd(int iommu_group_num);
> 
> Considering the "group_no" field defined in eal_vfio.h, will "iommu_group_num" cause inconsistency
> In naming?

I asked to change the function name to "num" because it is more meaningful.
"group_no" field is private? Can it be renamed?