From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56AD1433E7; Mon, 27 Nov 2023 22:13:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E002B40A6B; Mon, 27 Nov 2023 22:13:05 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 9C36E40156 for ; Mon, 27 Nov 2023 22:13:04 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 32A175C0210; Mon, 27 Nov 2023 16:13:04 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 27 Nov 2023 16:13:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1701119584; x=1701205984; bh=BBS/JscHN8LhhZtdvJ1X2yPa1EoVZ85tre/ OARv+X4w=; b=HN/YzCnDHrQyH4jld0DfPbvJEcfJYLEgWpXaNROua+4qJ9obwkW dolnypylHb7asJLB+B/YAlWxozXkCrONIdk6BDJ2XuYPJkKrNUAouNfnwYncxxzo xyXxA+jrNFd1nwChXUIIObtx7tIcnasRFNVxqtliwk2IX7xX2Ot3DkCyeYgreAg3 e5IUV4EWahJshOA2upjoTLYX/gXefGXZ2fkS6sdf3HmPVKuss2GIjnwaZuWTH81w ZAZkXS33D3xQlWloq9qXe/ts9Co9vSoE0+Er6i7r449bQa8Jr+BGNXXh2pzBKpHl QaCgE5cMiE3gEB+64V26jjGEoFMhNHvbxMg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1701119584; x=1701205984; bh=BBS/JscHN8LhhZtdvJ1X2yPa1EoVZ85tre/ OARv+X4w=; b=b57Zn2qeh75FHF3IREnS02lH/hib/KhRuS7KkLafAn2TcwvJEHN qBoRR/k1v5Dgx0Mc4P65E1teilAt7TS5p+UQxufqNrNr6oBS5ZCc7dxUJRdSdj0A ckn3pKyciMtco2n4hHfYL2kQpGWzUN7N/wVt+StqyyBMXYOH8HaFf2o0rwCL9oKr A0/djjwUxGp0rag2JGnFYz3TAnFl+ztHfzEGTJ5bCWidlCG8GEKEhGW0WP2F+TgO e1boZ+bkyHUUkHwj2/UY6tt6F6SuJWNtxJY1H3Xl5WOGdrPZNthSG86SydSHrEgS 1LihfW7weuEVcZ2kqI2ImpkADt75FwyEAhg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeiuddgudegjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 27 Nov 2023 16:13:02 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, Sivaprasad Tummala , david.hunt@intel.com, anatoly.burakov@intel.com, david.marchand@redhat.com, dev@dpdk.org, john.mcnamara@intel.com, ferruh.yigit@amd.com, karen.kelly@intel.com Subject: Re: [PATCH] examples/l3fwd-power: fix to configure the uncore env Date: Mon, 27 Nov 2023 22:13:01 +0100 Message-ID: <6096744.VdNmn5OnKV@thomas> In-Reply-To: References: <20231026151959.1458112-1-sivaprasad.tummala@amd.com> <25240705.EfDdHjke4D@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 27/11/2023 17:54, Bruce Richardson: > On Thu, Nov 23, 2023 at 02:58:58AM +0100, Thomas Monjalon wrote: > > 26/10/2023 17:19, Sivaprasad Tummala: > > > Updated the l3fwd-power app to configure the uncore env before invoking > > > any uncore APIs. With auto-detection in 'rte_power_uncore_init()' it is > > > too late because other APIs already called. > > > > You are also updating the uncore API. > > > > > + if (env == RTE_UNCORE_PM_ENV_AUTO_DETECT) > > > + /* Currently only intel_uncore is supported. This will be > > > + * extended with auto-detection support for multiple uncore > > > + * implementations. > > > + */ > > > + env = RTE_UNCORE_PM_ENV_INTEL_UNCORE; > > > > It looks like this patch does not make sense without AMD support. > > > This patch is fixing a regression introduced by an earlier patch in this > area (referenced in the fixes line). See bugzilla for more details on it[1] > > This should go into 23.11 as, without it, what was working in earlier > releases no longer does so. Thank you for the heads-up, I've looked at it too much quickly.