From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0054.outbound.protection.outlook.com [104.47.38.54]) by dpdk.org (Postfix) with ESMTP id D74564C9F for ; Tue, 27 Feb 2018 07:57:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=iFJUfHtlVg3OjH4Qbol4FdayEXIk7vyNIFdzRpkKuMI=; b=BjwIjNlfmkVHmjp1Yim5YnsS/vHALyRp1ZaWhK6kfSMJN/gSZi58+/4y3wp1xcNAyf2wEBlN62CQwwjFKlmMT3ftTlTgQvlTRPW5iqhC6GHmQrS8Y3iJoVnMOjULoTg5uMbaYSHKOQQdfgOX8gW/AYKfb64ib5kdg1yg+DmoWoM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from hyd1ajoseph-dt.caveonetworks.com (115.113.156.2) by CO2PR0701MB1062.namprd07.prod.outlook.com (10.160.8.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.527.15; Tue, 27 Feb 2018 06:57:11 +0000 To: "Nicolau, Radu" , Akhil Goyal , "Doherty, Declan" Cc: Jerin Jacob , Narayana Prasad , Nelio Laranjeiro , "dev@dpdk.org" References: <1516626668-9031-0-git-send-email-anoob.joseph@caviumnetworks.com> <1519191430-19201-1-git-send-email-anoob.joseph@caviumnetworks.com> <1519191430-19201-2-git-send-email-anoob.joseph@caviumnetworks.com> <763A2F19A5EFF34F8B7F1657C992EE297B32AFD8@IRSMSX104.ger.corp.intel.com> From: Anoob Joseph Message-ID: <609b5c35-4f5e-b6c5-6522-63b73504e711@caviumnetworks.com> Date: Tue, 27 Feb 2018 12:26:52 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <763A2F19A5EFF34F8B7F1657C992EE297B32AFD8@IRSMSX104.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: CY4PR06CA0026.namprd06.prod.outlook.com (10.173.44.12) To CO2PR0701MB1062.namprd07.prod.outlook.com (10.160.8.141) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 385b6ee8-3ef0-4505-9467-08d57daf553b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:CO2PR0701MB1062; X-Microsoft-Exchange-Diagnostics: 1; CO2PR0701MB1062; 3:b62w27EQMNRdOdXtJJCGGm1hG3WR5O+63ClV9B68/t5ATbXCNNAzeFwN2+b5ot2hmqGaOAsXtP/zRclHjUCs4j5GWb5sI5DT51FXlP7ojPtDzHkwtR7fqtjfrxL8Kh6TaMSYLqelqjrTCbPYzAa2od4AIvxTN4Wxxx8nAKc795/X9WoYGHSjMFK6CCQygrX89sNrOXepPUGNwubDR3UgldDTkUWiMGCj+HsnDrgIXS6v5wuSm2ymATXdJiIMjNOu; 25:Du5nBIj6rw0oNavRBX84N0uZigrkQl6dpHg1y4fz6vZ6B9OGDtiCzHgl56qBGW8SgMTzvjoL2LP5K32PuIFJZF92dIoRbh6i02MvvUl9PQP4ThsN9fgqBIY76XZ4z8yG2kltDnArBZkWA//igrup+qhGSzgO6lQyv+Sm0tP4S9dVN4epk3I0fxst6L3s0vVSsVKgnqvfdEHcCcSyxtgskLNAm7mvpdDfxnn+GuN7OCO0SPOxDgDX4KZsb3sXFTsJ153Z3js99+HaHFs2qvp1TXbTXc0K0cBbLQrrNsXnpIL1rqnwXjqgaU5UXSmvHOD4tpoIH97E+UasjT3Jtt8mLA==; 31:TqZgS5ZOg0QBSnT35pdyGYQGtdvAiJlyKqoMm2nIWnltExi/Ph7Ebpknsqo8p1mNzN9BLfukWbksaW3otVrH0YyjfS+GnENxeTnE3aG+IIzCBufS8wYs3sc0M6vWaWxz4dMnzwsyRE0VPhA84iR8inKgfTUUioD46gJZjd20G2rLI+oA2Ble85y2fv5be6xwbqK/rBRAgCX1Z9yY25oYJDofZ7peyB6gphlz7IObQho= X-MS-TrafficTypeDiagnostic: CO2PR0701MB1062: X-Microsoft-Exchange-Diagnostics: 1; CO2PR0701MB1062; 20:vW+pCk9Bn9Pf249jlEKgqrmKGzgLyu6Nl2oOc5mUcNHVpNH/b2+lOfHY+ij8A4K7hjE0ITCEwFnzooAbEdX7OrA26uHFcYIPvCIwCIQRVPBzaKHkYrUs+snazBbtlS/cl3nK/UDhPXpAGjwUFXg5oQZcEcpRWWS/8TyLxzRN0HwFtLaxh01Bmspq1oDWhH8lhgaPZgrLdipAXv9hWdsQbkFdj9Zk+r4evMgaxExe0HF4HC94D/VVtMJOwZyBlb0WCvG88FmZVbAQChHhC9EcCQRL7tS73xLX1TgmhvEAHYHq5bBQERNQ2p0Y7YKWoYlMYeYkpFIPH41UjbgqjLHIzu6g19ZeRIc/QsI3z9dT2zwykiGoSkdz3VJHzes5/ocUCF1tHrH+SVjiF0ty4H2nnhGF9jhHDXSGOraV3iUtBYKdd/0IuVcHdgZPqytUnL8pRdO5waqdI9Q6ooPpn7tIVdGfKTx/eYu0luh1gRYraAF25YTNVRPuY1FYuohHaKH/z+n3bgfqGOwSELIAPozUu+Fz/wbFzkUA/5K/3Fxlcb5YFGV1wV5QjXtfuiP6uaXFgBLKiHIbGCgVRz2dfBvL79PKlz1rzOtI8aYyhvyf/dk= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192374486261705)(185117386973197)(211171220733660)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231220)(944501161)(52105095)(93006095)(6041288)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:CO2PR0701MB1062; BCL:0; PCL:0; RULEID:; SRVR:CO2PR0701MB1062; X-Microsoft-Exchange-Diagnostics: 1; CO2PR0701MB1062; 4:QMmDnPJF2udR1HtkgUSurV5BzNu6yH24h+MxHeVQt0KKladd2Kb8+qX33PI5NWZJBYBvif0YLfDiaypIFA/oHjeMn+oyYHaHejKDwPfsmDvsK1GXMfAkLm9SROg8ap/ERLtJSI8zudUjo5aU5s9WEe+Hb0M3i15ghHEwBiS4xcv+OIoiL4n9NIChAynI+FOJAhL6yak/TZsUEgelk0g9RkIF8MA1pjLZt4ahkZInekK0xDm8UdUL2S4j08QmX4s9TPn9JR4QavVY+0ZejOxayreRN3WmC3kIoMYKPEaC5y9D403vB5H/yAHKvNfljFNuPnWZQkmguOihEsis8gAppCLE7ujcSkELtb7ccc98d+Vmz6S42BMWTg6F1eXVoJXsCehErXmyEeN0exwwBbP5+TG9C7xM2Oy4VzEUIuvqeLw= X-Forefront-PRVS: 05961EBAFC X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(346002)(366004)(39380400002)(39860400002)(376002)(13464003)(199004)(189003)(386003)(6506007)(229853002)(65826007)(93886005)(25786009)(26005)(55236004)(106356001)(31686004)(2906002)(53416004)(16526019)(478600001)(186003)(5660300001)(36756003)(6246003)(6512007)(6486002)(4326008)(64126003)(53936002)(53546011)(72206003)(68736007)(8676002)(23676004)(2486003)(52146003)(59450400001)(52116002)(2950100002)(97736004)(81156014)(42882006)(67846002)(8656006)(105586002)(47776003)(65956001)(7736002)(69596002)(81166006)(6666003)(54906003)(50466002)(76176011)(58126008)(8936002)(230700001)(316002)(31696002)(3846002)(110136005)(305945005)(65806001)(66066001)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR0701MB1062; H:hyd1ajoseph-dt.caveonetworks.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDTzJQUjA3MDFNQjEwNjI7MjM6OFl5WGFFTWR5c0M4NVVYa2hPM3lmRnlZ?= =?utf-8?B?eW5IekprTHppTDBPbEt2YW9MTHFyMXBOaXp1NlVmNlNxQnRZZ09mWlc1aUNo?= =?utf-8?B?TVRNd0dLM1V1WUg5eUV2SzFNaUNNN2ZXSnJvck5HN2ozc0hiNU1MWlpTaDJD?= =?utf-8?B?TENiWk45anhvR3IyekVoVklYamN5VjFFcVhqb1loejBDMUV4YkVaWkxySlpz?= =?utf-8?B?cVVPZU40ZisxM2J2dXZ2TWd5UTVteWJhVTFJeHRGNnRoMU9OQWpibUpZOGhM?= =?utf-8?B?MmgxRmlBRHErYnFzS09pMG82YW1mQk1Hek9XcFBiSnluemZqWFJSUW9qdndR?= =?utf-8?B?Y3Y3M3N6aVFwZm5nMXlwMlEwOU9EVWx5QnhTRjNTSUdPOVBYYWRwVGJsWFY4?= =?utf-8?B?Q0xKRlJjWWt0WW5FTW9lQ0NJRmNuQ2RZalhxWGFEcnJiMG4vNnUrU09MelY5?= =?utf-8?B?WVdlQUxxQTdsNnViSzhIY3VzS2VZSnNrNGp0Z2pSYXd1alRiZGRIVkFnWWdp?= =?utf-8?B?U0NmblFQdWdOVGx3VTAxdWZQQXZCMHN6Y2hmaCtpdW9IZzd5Z3puZmMyVmF6?= =?utf-8?B?ODY0TE8wRmttNUtGUzBwR2l6Q05tQVhzZTg5eE43VWJuVzRjVGM0Z0dTLzIy?= =?utf-8?B?emswdjM2UUNpeXYyYzdCNFNySzd6T3lnSEFKRTZpMzVNNHRTZTdSd2VPWUxZ?= =?utf-8?B?dHlSeWNick9ncnFUSGdaYUc1em5CMUtRL09lV2RJaFRabUVvbHUrM1pyWXNl?= =?utf-8?B?RlVGUDk0ZjcvSWtDS1lkVkxPTEtQTWJjQTVvcDVNV0NySE9wU0FTbVNhdHFY?= =?utf-8?B?MzluaDgveHErTXdmd3JtbWN5ZHM1eDVSTnU3TlJLMmh6bXNmVksrTE1EVHVq?= =?utf-8?B?K0E1V0RHNmg5VlZjZ3drSU5LQ1psbUhLeGZqc1Jhb3pDMG1wLzAyWjhzM0pR?= =?utf-8?B?Wm1Kemw0STFFQ01pUjg4Zy9uL1V2MTl3MmNnbnVVd3dEcDZTRzVVTXd3SVo5?= =?utf-8?B?dzBkWTNkL3p1TGszYmFkbEVjamlrMk5zN3JvUUxPVWxodGF3dys4a0JLUXht?= =?utf-8?B?YVJpM25tV1J5RmVkbmtidWZPb1FSY2VkcGFYSEt0bEdqeUF3eFVySDJyRHlH?= =?utf-8?B?WXM5bWFKbFY0UVN3NmxNU0hyVUFhbUtueTc0cXN4d0VlRXNkeEIvWnBGUnVl?= =?utf-8?B?ZXZmWFgvQnhhMlV1bkpHdFR2c1piRFhsNDNSQ2dkSlVQLzFTb3R2eEZMMEJl?= =?utf-8?B?c2hVUGQ0eHF3YWw1T1AyZ3pxcVFKVlNUd0N6OTRDbHROTXpDcWRydEVId0Fj?= =?utf-8?B?OFNWbkVSaDU2R3NLRCtzNjA3WTgzUWxvdG1ZbWE1QzRZK3VJaGoxbXBRazFK?= =?utf-8?B?TkFLU2pzdEliTEI0RnduUy8vT0R1bDhPOWNVTGRPdG85dS9Fb1lZaG9sRnQy?= =?utf-8?B?bmJkSlBiSmh1bHFlZFh2Z1I5azN4bmU4dEFhcEdlT0E0MWhpdW1tNW0rZzRM?= =?utf-8?B?bXBVeCtXb25KQUI0STYzcklOUVZLaThsVmErTmFMdkhYeXUwQk5tRkQ3WUFO?= =?utf-8?B?cGJkSTNoMFRudEFSQXdZT2p1V0ttL25lSUdzZDA5RGNKbEovNkQxeFUvVHB2?= =?utf-8?B?eDQzRThaWmcvU1BzWEdpaTRlQzJoenY5SE1MV3o2SnpyUy9teGYyUWZCMkFJ?= =?utf-8?B?bFRxNVMvZkNVL2lmZVp2cFIrd1luUjVrVkF3UnRDOHRyNWxVdnphR1QxU0Rv?= =?utf-8?B?c000dTRhU1paRHVSN29wQzFxUG9WMDdvQytxTW96ZUhEeTYyUEgrajdKeGlV?= =?utf-8?B?Vk5MSVZ4VEVkaUFVdm9iNXZzbnl3OVlnR3BvejdDYVhVQmxPT0p6S21yU2or?= =?utf-8?B?Y0FlVVQvL2R2UmdlV2NhczVSOC9LTU1yR1NIT2RXa2ZBM1dwMXAvaTVieTlQ?= =?utf-8?B?ajlqVDcyRVZMazJlT2lWZ2U1anpXZ0Q2NFNFeE94dzUxT2hzam9qdGZPR2xr?= =?utf-8?B?d1JmWGRnbFdxSTZiUjJhU3dBcUZjQVZNQ2pFNjZTM3V6bDlwVEYrMDlPR1Qr?= =?utf-8?Q?OFA7uFP9sMLhdZdU8RCVOYBq+n8?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR0701MB1062; 6:AKiKMpgXY3I1iJsqL47aOEKDHR5BdWZ48yaYhyaeb4ZqIQ+e4JxjRy2DVfdRlTAXz4C8n/2U+5Pt/6HYtXEAttQnW+afSQ5ATa5tWO2ZhS9c2dXMGI0HPo3XnpYZsPLxilBnaoEzYUpu3ErTzpYKT1YgLudVYjPAq0ugHmNB1TioJM+I1phzI9tvoy6xN2OBxN52VAX38rYS71g+3eBePeeNWwjNGjs5YSiYP9ycCTU4X2txe8OW921Wt//ft/DS3SAql7lp9xENJVWkBPZCAZk8TFj+EIJ7Nda98OHHdepJB6kiQPNVxoDpczWMBp8G4BYrxy7md1LRIv6BOxwN2qXCa/C0pX7ALIF1xFyd65Q=; 5:ONweOea7cfvIhHKCWbp++6wiU/bC6zdXH03G69Euaz3tmX513Yr9ZMPDBW/0FjVAexcwSqQ6l6pwNAwpkYmBOWNtquiYYbjBpDYDyXj8gej53YE/Zhpmr8PdgJLXAEUb3fcOMsG7O/GaK8XKnc0TeMF31Zd0TST9gZKU1+dLilI=; 24:srLkQUuGrH3bdBTJPGWSpt3wJ34a5mkXL/sIC9htE+PPbAGF2/OoiqRZHj17ivUQQxXwrNbeYcuxprGk7mvDWGol4b4ut0rxRw8MrbhsyQw=; 7:CnHp1PntOBtgJNB96+MEVlx9WvjtOWkPm+6E2DFSpBVyfgzPVib1g3Yo0C64EDegs/e0KL+6QIB+1Y/KX2DsS+E0gIwk45XutISQ8r7SaRtSuTkH3Hv1vg9iAqDU/ma8b0cJ3ox8pMkAFb3U9/FxspIaF/+sNOcvd1AMVKEjdUdLUmatWpjtA/drJtziBov4BoWoNoctm2qbMDFOahDOo1bZxOUGzQBiazK5a3S9lxeQTYfdkwX8PYKiwKdn+ydc SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2018 06:57:11.9885 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 385b6ee8-3ef0-4505-9467-08d57daf553b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR0701MB1062 Subject: Re: [dpdk-dev] [PATCH 1/5] lib/ethdev: support for inline IPsec events X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2018 06:57:18 -0000 Hi Radu, Please see inline. Thanks, Anoob On 26/02/18 15:05, Nicolau, Radu wrote: > >> -----Original Message----- >> From: Anoob Joseph [mailto:anoob.joseph@caviumnetworks.com] >> Sent: Wednesday, February 21, 2018 5:37 AM >> To: Akhil Goyal ; Doherty, Declan >> ; Nicolau, Radu >> Cc: Anoob Joseph ; Jerin Jacob >> ; Narayana Prasad >> ; Nelio Laranjeiro >> ; dev@dpdk.org >> Subject: [PATCH 1/5] lib/ethdev: support for inline IPsec events >> >> Adding support for IPsec events in rte_eth_event framework. In inline IPsec >> offload, the per packet protocol defined variables, like ESN, would be >> managed by PMD. In such cases, PMD would need IPsec events to notify >> application about various conditions like, ESN overflow. >> >> Signed-off-by: Anoob Joseph >> --- >> lib/librte_ether/rte_ethdev.h | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h >> index 0361533..4e4e18d 100644 >> --- a/lib/librte_ether/rte_ethdev.h >> +++ b/lib/librte_ether/rte_ethdev.h >> @@ -2438,6 +2438,27 @@ int >> rte_eth_tx_done_cleanup(uint16_t port_id, uint16_t queue_id, uint32_t >> free_cnt); >> >> /** >> + * Subtypes for IPsec offload events raised by eth device. >> + */ >> +enum rte_eth_event_ipsec_subtype { >> + RTE_ETH_EVENT_IPSEC_ESN_OVERFLOW, >> + /** Sequence number overflow in security offload */ >> + RTE_ETH_EVENT_IPSEC_MAX >> + /** Max value of this enum */ >> +}; > I would add some more events to the list (to make it look less like a very specific case implementation): crypto/auth failed and undefined/unspecified being the most obvious. > Apart from this, the patchset looks fine. Understood your point. But crypto/auth failed would be per packet, right? How are we handling such error cases presently? Just want to make sure we are not adding two error reporting mechanisms. > >> + >> +/** >> + * Descriptor for IPsec event. Used by eth dev to send extra >> +information of the >> + * event. >> + */ >> +struct rte_eth_event_ipsec_desc { >> + enum rte_eth_event_ipsec_subtype stype; >> + /** Type of IPsec event */ >> + uint64_t md; >> + /** Event specific metadata */ >> +}; >> + >> +/** >> * The eth device event type for interrupt, and maybe others in the future. >> */ >> enum rte_eth_event_type { >> @@ -2448,6 +2469,7 @@ enum rte_eth_event_type { >> RTE_ETH_EVENT_INTR_RESET, >> /**< reset interrupt event, sent to VF on PF reset */ >> RTE_ETH_EVENT_VF_MBOX, /**< message from the VF received by >> PF */ >> + RTE_ETH_EVENT_IPSEC, /**< IPsec offload related event */ >> RTE_ETH_EVENT_MACSEC, /**< MACsec offload related event */ >> RTE_ETH_EVENT_INTR_RMV, /**< device removal event */ >> RTE_ETH_EVENT_NEW, /**< port is probed */ >> -- >> 2.7.4