From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Wei Dai <wei.dai@intel.com>, <ferruh.yigit@intel.com>,
<thomas@monjalon.net>, <declan.doherty@intel.com>,
<linville@tuxdriver.com>, <mw@semihalf.com>, <mk@semihalf.com>,
<gtzalik@amazon.com>, <evgenys@amazon.com>, <ravi1.kumar@amd.com>,
<shepard.siegel@atomicrules.com>, <ed.czeck@atomicrules.com>,
<john.miller@atomicrules.com>, <ajit.khaparde@broadcom.com>,
<somnath.kotur@broadcom.com>, <jerin.jacob@caviumnetworks.com>,
<maciej.czekaj@caviumnetworks.com>, <shijith.thotton@cavium.com>,
<ssrinivasan@cavium.com>, <santosh.shukla@caviumnetworks.com>,
<rahul.lakkireddy@chelsio.com>, <ohndale@cisco.com>,
<hyonkim@cisco.com>, <wenzhuo.lu@intel.com>,
<konstantin.ananyev@intel.com>, <beilei.xing@intel.com>,
<qi.z.zhang@intel.com>, <xiao.w.wang@intel.com>,
<jingjing.wu@intel.com>, <tdu@semihalf.com>, <dima@marvell.com>,
<nsamsono@marvell.com>, <jianbo.liu@arm.com>,
<adrien.mazarguil@6wind.com>, <nelio.laranjeiro@6wind.com>,
<yskoh@mellanox.com>, <matan@mellanox.com>, <vido@cesnet.cz>,
<alejandro.lucero@netronome.com>, <emant.agrawal@nxp.com>,
<shreyansh.jain@nxp.com>, <hemant.agrawal@nxp.com>,
<harish.patil@cavium.com>, <rasesh.mody@cavium.com>,
<asesh.mody@cavium.com>, <shahed.shaikh@cavium.com>,
<yongwang@vmware.com>, <maxime.coquelin@redhat.com>,
<mtetsuyah@gmail.com>, <tiwei.bie@intel.com>,
<allain.legacy@windriver.com>, <matt.peters@windriver.com>,
<pascal.mazon@6wind.com>, <bruce.richardson@intel.com>,
<gaetan.rivet@6wind.com>, <jasvinder.singh@intel.com>,
<cristian.dumitrescu@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads
Date: Tue, 8 May 2018 13:41:26 +0300 [thread overview]
Message-ID: <60bdea5d-2b90-0986-9f0f-c952bc722ce7@solarflare.com> (raw)
In-Reply-To: <1525773917-62792-1-git-send-email-wei.dai@intel.com>
On 05/08/2018 01:05 PM, Wei Dai wrote:
[...]
> In the beginning of [rt]x_queue_setup( ) of underlying PMD,
> add offloads = [rt]xconf->offloads |
> dev->data->dev_conf.[rt]xmode.offloads; to keep same as offload API
> defined in 17.11 to avoid upper application broken due to offload
> API change.
> PMD can use the info that input [rt]xconf->offloads only carry
> the new added per-queue offloads to do some optimization or some
> code change on base of this patch.
It looks like I've missed why PMDs should be updated to
add device offloads to per-queue offloads.
Cannot it be done on ethdev layer? PMD still can find out
which offloads were enabled on device level by
checking [rt]xmode->offlaods.
> Signed-off-by: Wei Dai <wei.dai@intel.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
[...]
next prev parent reply other threads:[~2018-05-08 10:41 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 13:53 [dpdk-dev] [PATCH] ethdev: check consistency of per port offloads Wei Dai
2018-03-28 8:57 ` [dpdk-dev] [PATCH v2] ethdev: check Rx/Tx offloads Wei Dai
2018-04-13 17:31 ` Ferruh Yigit
2018-04-15 10:37 ` Thomas Monjalon
2018-04-16 3:06 ` Dai, Wei
2018-04-25 11:26 ` [dpdk-dev] [PATCH] " Wei Dai
2018-04-25 11:31 ` [dpdk-dev] [PATCH v3] " Wei Dai
2018-04-25 11:49 ` Wei Dai
2018-04-25 11:50 ` [dpdk-dev] [PATCH v4] " Wei Dai
2018-04-25 17:04 ` Ferruh Yigit
2018-04-26 7:59 ` Zhang, Qi Z
2018-04-26 8:18 ` Thomas Monjalon
2018-04-26 8:51 ` Zhang, Qi Z
2018-04-26 14:45 ` Dai, Wei
2018-04-26 14:37 ` [dpdk-dev] [PATCH v5] " Wei Dai
2018-04-26 15:50 ` Ferruh Yigit
2018-04-26 15:56 ` Thomas Monjalon
2018-04-26 15:59 ` Ferruh Yigit
2018-04-26 16:11 ` Ferruh Yigit
2018-05-03 1:30 ` [dpdk-dev] [PATCH v6] " Wei Dai
2018-05-04 11:12 ` Ferruh Yigit
2018-05-04 14:02 ` [dpdk-dev] [PATCH v7] " Wei Dai
2018-05-04 14:42 ` Ferruh Yigit
2018-05-04 14:45 ` Ferruh Yigit
2018-05-05 18:59 ` Shahaf Shuler
2018-05-07 7:15 ` Dai, Wei
2018-05-08 10:58 ` Ferruh Yigit
2018-05-08 10:05 ` [dpdk-dev] [PATCH v8] " Wei Dai
2018-05-08 10:41 ` Andrew Rybchenko [this message]
2018-05-08 11:02 ` Ferruh Yigit
2018-05-08 11:22 ` Andrew Rybchenko
2018-05-08 11:37 ` Andrew Rybchenko
2018-05-08 12:34 ` Dai, Wei
2018-05-08 12:12 ` Ferruh Yigit
2018-05-09 12:45 ` Dai, Wei
2018-05-10 0:49 ` [dpdk-dev] [PATCH v9] ethdev: new Rx/Tx offloads API Wei Dai
2018-05-10 0:56 ` [dpdk-dev] [PATCH v10] " Wei Dai
2018-05-10 1:28 ` Ferruh Yigit
2018-05-10 2:35 ` Thomas Monjalon
2018-05-10 11:27 ` Dai, Wei
2018-05-10 9:25 ` Andrew Rybchenko
2018-05-10 19:47 ` Ferruh Yigit
2018-05-10 11:30 ` [dpdk-dev] [PATCH v11] " Wei Dai
2018-05-10 11:56 ` [dpdk-dev] [PATCH v12] " Wei Dai
2018-05-10 21:39 ` Thomas Monjalon
2018-05-14 8:37 ` Thomas Monjalon
2018-05-14 11:19 ` Dai, Wei
2018-05-10 21:48 ` Ferruh Yigit
2018-05-14 12:00 ` [dpdk-dev] [PATCH v13] " Wei Dai
2018-05-14 12:54 ` Thomas Monjalon
2018-05-14 13:26 ` Dai, Wei
2018-05-14 13:20 ` [dpdk-dev] [PATCH v14] " Wei Dai
2018-05-14 14:11 ` Thomas Monjalon
2018-05-14 14:46 ` Ferruh Yigit
2018-05-10 21:08 ` [dpdk-dev] [PATCH v10] " Ferruh Yigit
2018-05-08 10:10 ` [dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads Wei Dai
2018-05-08 17:51 ` Andrew Rybchenko
2018-05-09 2:10 ` Dai, Wei
2018-05-09 14:11 ` Ferruh Yigit
2018-05-09 22:40 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60bdea5d-2b90-0986-9f0f-c952bc722ce7@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=adrien.mazarguil@6wind.com \
--cc=ajit.khaparde@broadcom.com \
--cc=alejandro.lucero@netronome.com \
--cc=allain.legacy@windriver.com \
--cc=asesh.mody@cavium.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=dima@marvell.com \
--cc=ed.czeck@atomicrules.com \
--cc=emant.agrawal@nxp.com \
--cc=evgenys@amazon.com \
--cc=ferruh.yigit@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=gtzalik@amazon.com \
--cc=harish.patil@cavium.com \
--cc=hemant.agrawal@nxp.com \
--cc=hyonkim@cisco.com \
--cc=jasvinder.singh@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jianbo.liu@arm.com \
--cc=jingjing.wu@intel.com \
--cc=john.miller@atomicrules.com \
--cc=konstantin.ananyev@intel.com \
--cc=linville@tuxdriver.com \
--cc=maciej.czekaj@caviumnetworks.com \
--cc=matan@mellanox.com \
--cc=matt.peters@windriver.com \
--cc=maxime.coquelin@redhat.com \
--cc=mk@semihalf.com \
--cc=mtetsuyah@gmail.com \
--cc=mw@semihalf.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=nsamsono@marvell.com \
--cc=ohndale@cisco.com \
--cc=pascal.mazon@6wind.com \
--cc=qi.z.zhang@intel.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=rasesh.mody@cavium.com \
--cc=ravi1.kumar@amd.com \
--cc=santosh.shukla@caviumnetworks.com \
--cc=shahed.shaikh@cavium.com \
--cc=shepard.siegel@atomicrules.com \
--cc=shijith.thotton@cavium.com \
--cc=shreyansh.jain@nxp.com \
--cc=somnath.kotur@broadcom.com \
--cc=ssrinivasan@cavium.com \
--cc=tdu@semihalf.com \
--cc=thomas@monjalon.net \
--cc=tiwei.bie@intel.com \
--cc=vido@cesnet.cz \
--cc=wei.dai@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=yongwang@vmware.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).