From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B3EBA0524; Thu, 7 Jan 2021 10:33:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8301A140F0D; Thu, 7 Jan 2021 10:33:23 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 37EA9140F0B for ; Thu, 7 Jan 2021 10:33:22 +0100 (CET) IronPort-SDR: 4mPTxI05WBaKzp6i/iIlt3hhW0zQi0QOUrVsA999rK3yoBbxEFqYuNNpkNflM7Uqm3MjJKH/Xo aMW8W8z2o0/Q== X-IronPort-AV: E=McAfee;i="6000,8403,9856"; a="195956896" X-IronPort-AV: E=Sophos;i="5.79,329,1602572400"; d="scan'208";a="195956896" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2021 01:33:21 -0800 IronPort-SDR: klMHdBA68OsBE8OmnsHJU+F/OQBBxwj+hc6XZklh0wp3NG9L1ZmN98h7XAfAj/OB3OO/u8FO1D OGggACAnzaIA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,329,1602572400"; d="scan'208";a="398555762" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga002.fm.intel.com with ESMTP; 07 Jan 2021 01:33:21 -0800 Received: from shsmsx604.ccr.corp.intel.com (10.109.6.214) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 7 Jan 2021 01:33:20 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX604.ccr.corp.intel.com (10.109.6.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 7 Jan 2021 17:33:18 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Thu, 7 Jan 2021 17:33:18 +0800 From: "Guo, Jia" To: "Yang, MurphyX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Zhang, Qi Z" , "Yang, SteveX" , "Wu, Jingjing" , "Xing, Beilei" , "Yang, MurphyX" Thread-Topic: [PATCH v8] net/iavf: fix invalid RSS combinations rule can be created Thread-Index: AQHW5NZnBnGimZe0WkmvxHJ0GJKeWKob5onA Date: Thu, 7 Jan 2021 09:33:18 +0000 Message-ID: <60dba504aba0403e942e7d5692e05773@intel.com> References: <20210107075815.78873-1-murphyx.yang@intel.com> <20210107091710.84719-1-murphyx.yang@intel.com> In-Reply-To: <20210107091710.84719-1-murphyx.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v8] net/iavf: fix invalid RSS combinations rule can be created X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Acked-by: Jeff Guo > -----Original Message----- > From: Murphy Yang > Sent: Thursday, January 7, 2021 5:17 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Guo, Jia ; > Zhang, Qi Z ; Yang, SteveX ; > Wu, Jingjing ; Xing, Beilei ; > Yang, MurphyX > Subject: [PATCH v8] net/iavf: fix invalid RSS combinations rule can be cr= eated >=20 > Currently, when use 'flow' command to create a rule with following invali= d > RSS type combination, it can be created successfully. >=20 > Invalid RSS combinations list: > - ETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_TCP > - ETH_RSS_IPV6 | ETH_RSS_NONFRAG_IPV6_TCP >=20 > This patch adds these combinations in 'invalid_rss_comb' array to do vali= d > check, if the combination check failed, the rule will be created unsucces= sful. >=20 > Fixes: 91f27b2e39ab ("net/iavf: refactor RSS") >=20 > Signed-off-by: Murphy Yang > --- > v8: > - Update the comments. > v7: > - Remove unsupported RSS combinations array. > - Restored 'ETH_RSS_GTPU' in input set mask. > v6: > - Add unsupported RSS combinations array. > v5: > - Remove 'ETH_RSS_GTPU' from input set mask. > v4: > - Use 'ETH_RSS_XXX' replace 'IAVF_RSS_TYPE_INNER_XXX' > v3: > - Update the comments. > v2: > - Add invalid RSS combinations. > drivers/net/iavf/iavf_hash.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c = index > 7620876b58..ebaac58254 100644 > --- a/drivers/net/iavf/iavf_hash.c > +++ b/drivers/net/iavf/iavf_hash.c > @@ -863,7 +863,9 @@ static void iavf_refine_proto_hdrs(struct > virtchnl_proto_hdrs *proto_hdrs, >=20 > static uint64_t invalid_rss_comb[] =3D { > ETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_UDP, > + ETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_TCP, > ETH_RSS_IPV6 | ETH_RSS_NONFRAG_IPV6_UDP, > + ETH_RSS_IPV6 | ETH_RSS_NONFRAG_IPV6_TCP, > RTE_ETH_RSS_L3_PRE32 | RTE_ETH_RSS_L3_PRE40 | > RTE_ETH_RSS_L3_PRE48 | RTE_ETH_RSS_L3_PRE56 | > RTE_ETH_RSS_L3_PRE96 > -- > 2.17.1