* [dpdk-dev] [PATCH] net/virtio: fix reporting of mbufs allocated on RxQ setup
@ 2021-08-20 12:47 Andrew Rybchenko
2021-09-13 19:21 ` Maxime Coquelin
2021-09-14 11:25 ` Maxime Coquelin
0 siblings, 2 replies; 3+ messages in thread
From: Andrew Rybchenko @ 2021-08-20 12:47 UTC (permalink / raw)
To: Maxime Coquelin, Chenbo Xia, Marvin Liu; +Cc: dev, Ivan Ilchenko, stable
From: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>
Rx queue setup finish function may report wrong number of
allocated mbufs in case of in-order feature. Fix the
function to not ignore allocation error and count only
successfully allocated number of buffers.
Fixes: e5f456a98d3 ("net/virtio: support in-order Rx and Tx")
Cc: stable@dpdk.org
Signed-off-by: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
---
drivers/net/virtio/virtio_rxtx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c
index d0365ce4bf..8a48fba5cc 100644
--- a/drivers/net/virtio/virtio_rxtx.c
+++ b/drivers/net/virtio/virtio_rxtx.c
@@ -768,10 +768,11 @@ virtio_dev_rx_queue_setup_finish(struct rte_eth_dev *dev, uint16_t queue_idx)
if (unlikely(error)) {
for (i = 0; i < free_cnt; i++)
rte_pktmbuf_free(pkts[i]);
+ } else {
+ nbufs += free_cnt;
}
}
- nbufs += free_cnt;
vq_update_avail_idx(vq);
}
} else {
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/virtio: fix reporting of mbufs allocated on RxQ setup
2021-08-20 12:47 [dpdk-dev] [PATCH] net/virtio: fix reporting of mbufs allocated on RxQ setup Andrew Rybchenko
@ 2021-09-13 19:21 ` Maxime Coquelin
2021-09-14 11:25 ` Maxime Coquelin
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2021-09-13 19:21 UTC (permalink / raw)
To: Andrew Rybchenko, Chenbo Xia, Marvin Liu; +Cc: dev, Ivan Ilchenko, stable
On 8/20/21 2:47 PM, Andrew Rybchenko wrote:
> From: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>
>
> Rx queue setup finish function may report wrong number of
> allocated mbufs in case of in-order feature. Fix the
> function to not ignore allocation error and count only
> successfully allocated number of buffers.
>
> Fixes: e5f456a98d3 ("net/virtio: support in-order Rx and Tx")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> ---
> drivers/net/virtio/virtio_rxtx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/virtio: fix reporting of mbufs allocated on RxQ setup
2021-08-20 12:47 [dpdk-dev] [PATCH] net/virtio: fix reporting of mbufs allocated on RxQ setup Andrew Rybchenko
2021-09-13 19:21 ` Maxime Coquelin
@ 2021-09-14 11:25 ` Maxime Coquelin
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2021-09-14 11:25 UTC (permalink / raw)
To: Andrew Rybchenko, Chenbo Xia, Marvin Liu; +Cc: dev, Ivan Ilchenko, stable
On 8/20/21 2:47 PM, Andrew Rybchenko wrote:
> From: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>
>
> Rx queue setup finish function may report wrong number of
> allocated mbufs in case of in-order feature. Fix the
> function to not ignore allocation error and count only
> successfully allocated number of buffers.
>
> Fixes: e5f456a98d3 ("net/virtio: support in-order Rx and Tx")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> ---
> drivers/net/virtio/virtio_rxtx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Applied to dpdk-next-virtio/main.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-14 11:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-20 12:47 [dpdk-dev] [PATCH] net/virtio: fix reporting of mbufs allocated on RxQ setup Andrew Rybchenko
2021-09-13 19:21 ` Maxime Coquelin
2021-09-14 11:25 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).