DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Min Hu (Connor)" <humin29@huawei.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org>
Cc: Huisong Li <lihuisong@huawei.com>, <stable@dpdk.org>,
	Xiaoyun Li <xiaoyun.li@intel.com>,
	Aman Singh <aman.deep.singh@intel.com>,
	Yuying Zhang <yuying.zhang@intel.com>,
	Lijun Ou <oulijun@huawei.com>,
	Ajit Khaparde <ajit.khaparde@broadcom.com>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [PATCH v3] app/testpmd: add help messages for multi-process
Date: Fri, 4 Mar 2022 09:28:42 +0800	[thread overview]
Message-ID: <60e38bf6-3845-7ce4-9b50-0e61ff16ac99@huawei.com> (raw)
In-Reply-To: <9c520fcc-2035-fbe3-2ecf-bf370a0f5520@intel.com>

Hi, Ferruh,
	V4 has been sent to fix it, thanks.

在 2022/3/3 20:09, Ferruh Yigit 写道:
> On 3/1/2022 9:16 AM, Min Hu (Connor) wrote:
>> From: Huisong Li <lihuisong@huawei.com>
>>
>> This patch adds help messages for multi-process.
>>
>> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> ---
>> v3,v2:
>> * adjust the position of parameters.
>> ---
>>   app/test-pmd/parameters.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
>> index daf6a31b2b..44698046b4 100644
>> --- a/app/test-pmd/parameters.c
>> +++ b/app/test-pmd/parameters.c
>> @@ -61,6 +61,8 @@ usage(char* progname)
>>              "extended statistics to show. Used with --stats-period "
>>              "specified or interactive commands that show Rx/Tx 
>> statistics "
>>              "(i.e. 'show port stats').\n");
>> +    printf("  --num-procs: the number of processes which will be 
>> used\n");
>> +    printf("  --proc-id  : the id of the current process (id < 
>> num-procs)\n");
> 
> Hi Connor,
> 
> For people new to dpdk/test-pmd, it may be hard to figure out these two
> parameter is related to multi-process support. What do you think updating
> the description to clarify these are for multi-process support?
> 
>>       printf("  --nb-cores=N: set the number of forwarding cores "
>>              "(1 <= N <= %d).\n", nb_lcores);
>>       printf("  --nb-ports=N: set the number of forwarding ports "
> 
> .

  parent reply	other threads:[~2022-03-04  1:28 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-28  3:26 [PATCH] " Min Hu (Connor)
2022-02-28  8:57 ` Thomas Monjalon
2022-03-01  3:41   ` Min Hu (Connor)
2022-03-01  8:36     ` Thomas Monjalon
2022-03-01  9:19       ` Min Hu (Connor)
2022-03-01  3:39 ` [PATCH v2] " Min Hu (Connor)
2022-03-01  8:35   ` Thomas Monjalon
2022-03-01  9:17     ` Min Hu (Connor)
2022-03-01  9:16 ` [PATCH v3] " Min Hu (Connor)
2022-03-03 12:09   ` Ferruh Yigit
2022-03-03 14:59     ` Ajit Khaparde
2022-03-04  1:28     ` Min Hu (Connor) [this message]
2022-03-04  1:22 ` [PATCH] 1 version Min Hu (Connor)
2022-03-04  1:22   ` [PATCH] app/testpmd: add help messages for multi-process Min Hu (Connor)
2022-03-04  1:25     ` Min Hu (Connor)
2022-03-04  1:22   ` [PATCH] dpdk: show dev basic info Min Hu (Connor)
2022-03-04  1:25     ` Min Hu (Connor)
2022-03-04  1:22   ` [PATCH v4] ethdev: introduce dump API Min Hu (Connor)
2022-03-04  1:26     ` Min Hu (Connor)
2022-03-04  1:22   ` [PATCH] net/bonding: fix slaves initializing on mtu setting Min Hu (Connor)
2022-03-04  1:27     ` Min Hu (Connor)
2022-03-04  1:25   ` [PATCH] 1 version Min Hu (Connor)
2022-03-04  1:27 ` [PATCH v4] app/testpmd: add help messages for multi-process Min Hu (Connor)
2022-03-04  2:50   ` Zhang, Yuying
2022-03-04  6:29     ` Min Hu (Connor)
2022-03-04  6:26 ` [PATCH v5] " Min Hu (Connor)
2022-03-04  9:11   ` Zhang, Yuying
2022-03-04 15:35     ` Ferruh Yigit
2022-03-06 22:52       ` Thomas Monjalon
2022-03-07  1:05         ` Min Hu (Connor)
2022-03-04 14:46   ` Ferruh Yigit
2022-03-07  1:04 ` Min Hu (Connor)
2022-04-25  6:51   ` Min Hu (Connor)
2022-06-02  2:24   ` Min Hu (Connor)
2022-06-02 23:08     ` Ferruh Yigit
2022-06-09  8:07       ` Dongdong Liu
2022-06-09  8:52 ` [PATCH v6] " Dongdong Liu
2022-06-09 14:06   ` Ferruh Yigit
2022-06-09 14:58     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60e38bf6-3845-7ce4-9b50-0e61ff16ac99@huawei.com \
    --to=humin29@huawei.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=aman.deep.singh@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=lihuisong@huawei.com \
    --cc=oulijun@huawei.com \
    --cc=stable@dpdk.org \
    --cc=xiaoyun.li@intel.com \
    --cc=yuying.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).