From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7EDCCA04A2; Fri, 4 Mar 2022 02:28:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6FA62406A2; Fri, 4 Mar 2022 02:28:45 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 8F5D6406A2; Fri, 4 Mar 2022 02:28:43 +0100 (CET) Received: from dggeme756-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4K8qwC5WHWzdZLm; Fri, 4 Mar 2022 09:27:23 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.21; Fri, 4 Mar 2022 09:28:42 +0800 Subject: Re: [PATCH v3] app/testpmd: add help messages for multi-process To: Ferruh Yigit , CC: Huisong Li , , Xiaoyun Li , Aman Singh , Yuying Zhang , Lijun Ou , Ajit Khaparde , Andrew Rybchenko References: <20220228032617.46618-1-humin29@huawei.com> <20220301091650.2260-1-humin29@huawei.com> <9c520fcc-2035-fbe3-2ecf-bf370a0f5520@intel.com> From: "Min Hu (Connor)" Message-ID: <60e38bf6-3845-7ce4-9b50-0e61ff16ac99@huawei.com> Date: Fri, 4 Mar 2022 09:28:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <9c520fcc-2035-fbe3-2ecf-bf370a0f5520@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggeme756-chm.china.huawei.com (10.3.19.102) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Ferruh, V4 has been sent to fix it, thanks. 在 2022/3/3 20:09, Ferruh Yigit 写道: > On 3/1/2022 9:16 AM, Min Hu (Connor) wrote: >> From: Huisong Li >> >> This patch adds help messages for multi-process. >> >> Fixes: a550baf24af9 ("app/testpmd: support multi-process") >> Cc: stable@dpdk.org >> >> Signed-off-by: Huisong Li >> --- >> v3,v2: >> * adjust the position of parameters. >> --- >>   app/test-pmd/parameters.c | 2 ++ >>   1 file changed, 2 insertions(+) >> >> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c >> index daf6a31b2b..44698046b4 100644 >> --- a/app/test-pmd/parameters.c >> +++ b/app/test-pmd/parameters.c >> @@ -61,6 +61,8 @@ usage(char* progname) >>              "extended statistics to show. Used with --stats-period " >>              "specified or interactive commands that show Rx/Tx >> statistics " >>              "(i.e. 'show port stats').\n"); >> +    printf("  --num-procs: the number of processes which will be >> used\n"); >> +    printf("  --proc-id  : the id of the current process (id < >> num-procs)\n"); > > Hi Connor, > > For people new to dpdk/test-pmd, it may be hard to figure out these two > parameter is related to multi-process support. What do you think updating > the description to clarify these are for multi-process support? > >>       printf("  --nb-cores=N: set the number of forwarding cores " >>              "(1 <= N <= %d).\n", nb_lcores); >>       printf("  --nb-ports=N: set the number of forwarding ports " > > .