DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Hu, Jiayu" <jiayu.hu@intel.com>
Cc: stable@dpdk.org, "Kovacevic, Marko" <marko.kovacevic@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v6] doc: add GRO limitations in prog_guide
Date: Thu, 17 Jan 2019 23:08:07 +0100	[thread overview]
Message-ID: <6102338.UvBRKH1dAI@xps> (raw)
In-Reply-To: <6DC05C7C5F25994B81B3F2F214251F660207DB1F@IRSMSX104.ger.corp.intel.com>

17/01/2019 14:55, Kovacevic, Marko:
> > +GRO Library Limitations
> > +-----------------------
> > +
> > +- GRO library uses MBUF->l2_len/l3_len/l4_len/outer_l2_len/
> > +  outer_l3_len/packet_type to get protocol headers for the
> > +  input packet, rather than parsing the packet header. Therefore,
> > +  before call GRO APIs to merge packets, user applications
> > +  must set MBUF->l2_len/l3_len/l4_len/outer_l2_len/outer_l3_len/
> > +  packet_type to the same values as the protocol headers of the
> > +  packet.
> > +
> > +- GRO library doesn't support to process the packets with IPv4
> > +  Options or VLAN tagged.
> > +
> > +- GRO library just supports to process the packet organized
> > +  in a single MBUF. If the input packet consists of multiple
> > +  MBUFs (i.e. chained MBUFs), GRO reassembly behaviors are
> > +  unknown.
> > --
> 
> Would it be better said like this ??
> 
> - GRO library uses different MBUF->packet_types for example
>   ``l2_len, l3_len, l4_len, outer_l2_len, outer_l3_len`` to get protocol
>   headers for the input packet, rather than parsing the packet header.
>   Therefore, before calling GRO APIs to merge packets, user applications
>   must set MBUF->packet_type to the same values as the protocol headers of
>   the packet.

packet_type is really a field in mbuf.
I think the wording from Jiayu is more correct.

  reply	other threads:[~2019-01-17 22:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-18  4:25 [dpdk-dev] [PATCH] doc: add GRO API requirement " Jiayu Hu
2018-12-26  4:04 ` [dpdk-dev] [PATCH v2] doc: add GRO API limitations " Jiayu Hu
2019-01-04  7:16   ` [dpdk-dev] [PATCH v3] " Jiayu Hu
2019-01-09  3:00     ` [dpdk-dev] [PATCH V4] " Jiayu Hu
2019-01-09  4:25       ` Varghese, Vipin
2019-01-09  4:27         ` Varghese, Vipin
2019-01-09  5:18           ` Hu, Jiayu
2019-01-09  8:19       ` [dpdk-dev] [PATCH v5] " Jiayu Hu
2019-01-09 18:20         ` Stephen Hemminger
2019-01-09 18:40           ` Ananyev, Konstantin
2019-01-09 21:31             ` Morten Brørup
2019-01-10  8:06               ` Hu, Jiayu
2019-01-10  8:28                 ` Morten Brørup
2019-01-16  2:13         ` [dpdk-dev] [PATCH v6] doc: add GRO " Jiayu Hu
2019-01-16  9:50           ` Ananyev, Konstantin
2019-01-17 22:08             ` Thomas Monjalon
2019-01-17 13:55           ` Kovacevic, Marko
2019-01-17 22:08             ` Thomas Monjalon [this message]
2019-01-04 19:35 ` [dpdk-dev] [PATCH] doc: add GRO API requirement " Stephen Hemminger
2019-01-08  2:35   ` Hu, Jiayu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6102338.UvBRKH1dAI@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=jiayu.hu@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).