From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40FC0A0C5B; Thu, 4 Nov 2021 18:32:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D031941223; Thu, 4 Nov 2021 18:32:11 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 62435411C9 for ; Thu, 4 Nov 2021 18:32:10 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 2A1903201C26; Thu, 4 Nov 2021 13:32:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 04 Nov 2021 13:32:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= hIibVDzjOJtQIaSuHmV1oOgBf7++feP5Q7cEK4E26RE=; b=Fnw372wK/Cx3lLXO ozszJ6GEp8QFCGWRo1VIkSLgycqHyo+9Qpb8m6jfcemOuPdLXb0k/jI7wUeUvrxf ozQg7ka143RenbrNOxIVsaRcsCDpd9GpY/DVkk8JGY2sczjP5oHLZoJHwmzK3+9r fms9trO+66au0CsxrZ7bIAKzIOx20ISx75qrw9EeNdtcgI5s9l6J84939oFO3p5m ClwTRezEGYFRDQgx1H6ECj8yMvJ3bViq2jODRTB0QeYO/cjOUqobCJJNxtYZ1hD5 QhZqJmKAcpgd8KMqmL/vwGHX9j/tgnDYWZtmo4UMcA+fbemKol1nzJ6n2vK35zq7 trthMQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=hIibVDzjOJtQIaSuHmV1oOgBf7++feP5Q7cEK4E26 RE=; b=Vq2uGcElH2VTdYNCdex7+AC3+KhgAbegH3/Up+IkuGbcYx7LSTiu3MLFu U6ghaRCFgN7aRDNR0rgO0u07LVGjNgnQlV91CD+GOYWJdDhyGmJk1Z4RHcNnWWNg ylLnRhjgPdpz+ZHWsjZR5+ys9xpFVF8dOFNqhKarETDGFhJCGknMmsmjboNg5DXm RfHS0yNWMa/Qec3gWdL/jKh/4MgMNv3i3V0r6+ZF5SYJfP2uXVsoPH60Qjy7eeIU yuqbjLGFcOGQ6G8dYha2evjOtH7NKBHfrmOFzRs1z2vKevmGMa+C1x7n0eF0aATA 5nHzdYDQ51zh3T794LR76L1iiyoXg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrtdeggdeljecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 4 Nov 2021 13:32:07 -0400 (EDT) From: Thomas Monjalon To: Jim Harris Cc: dev , David Hunt , David Marchand Date: Thu, 04 Nov 2021 18:32:06 +0100 Message-ID: <6106734.XMRzD8n4ft@thomas> In-Reply-To: References: <20211029171550.330229-1-james.r.harris@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] power: fix unused-but-set variable error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/10/2021 20:53, David Marchand: > On Fri, Oct 29, 2021 at 7:17 PM Jim Harris wrote: > > > > clang-13 rightfully complains that the tot_ppi > > variable in update_stats is set but not used, since > > the final accumulated tot_ppi results isn't used > > anywhere. So just remove the tot_ppi variable. > > Dead code, from the start... > Fixes: 450f0791312c ("power: add traffic pattern aware power control") > > > @@ -237,7 +237,6 @@ update_stats(struct priority_worker *poll_stats) > > > > for (j = 0; j < BINS_AV; j++) { > > tot_edpi += s->edpi_av[j]; > > - tot_ppi += s->ppi_av[j]; > > } > > I don't think keeping ppi_av[] (and related data struct) is that > useful.. but in any case patch lgtm: > > Reviewed-by: David Marchand I understand that a v2 removing ppi_av would be better.