From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id A4FA558D8 for <dev@dpdk.org>; Thu, 4 Feb 2016 09:40:14 +0100 (CET) Received: by mail-wm0-f50.google.com with SMTP id r129so200420869wmr.0 for <dev@dpdk.org>; Thu, 04 Feb 2016 00:40:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=S32kXr9PFxJ6vN3DriQEHjrltNu9rAKR65sYMy8qpPw=; b=CdOL0cJoXhPQVK5+jguSEsCknuEoq1/h2H1fx4EpnCV0JUIPsJYQSDdapVegSdUXzi 0PPJYVmt/g2JA22o87efvwMtfYYo66O1bie7n3EJ2wOcHCqsMz88D2sO8vrC+U9fJlbN a7TVi4G3MJFKIoeusl2Ud4UzeW3Z49vjIFfH+uxhqJNSllAORu62xplefBJnqB9u7MV7 RhXzIX+8zQU0F/K8lsjuazcEqFUP8CYVzU9UfsZpI7QXAY5kJIckX8pme0Uos+XoaMHz ExwbvACUWDhQWk46pE6YhoYkQH3hVi53Jm+0u5DrqqWZUaTCZmRKBZfioolvQwDdon8T jn2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=S32kXr9PFxJ6vN3DriQEHjrltNu9rAKR65sYMy8qpPw=; b=aVSh4+vRiBnXdzzhcT3z9MeSj93lSe40//GK4sy3UDtrzuFUfGwMir1IvIuEYFtPUB nmxAkaS/wzl0nZ83vuaV1IcQQ3I28GutLIzueY9FstVuhWclJ06WhX56ARvfHJnKlkA2 0nCYcQY3Yps8xXpLfrcGPbG7Bqu7Cd+YCp/C/+zaRnGt5YfFapQ+C3nIloYADkCXXEGz 2Nda2s+SUFCfcsVbhfQwey+Bi9NsLMrFS47KwAGsShaQzAyXFuyf4up5xwtiRdyGranf CXKtxGahFvJNOTDFgmXIRNqVZQoiCyHnCX9pnjb6ygq2974OnYbzKjA648MdrBvXM5Gd XKBQ== X-Gm-Message-State: AG10YORMGYzfg0waLoC808a3RqSkUTfTeLm1gty9zv6FYUm88iWyumM9YU71/yS2kBgRaLcQ X-Received: by 10.194.242.67 with SMTP id wo3mr6613496wjc.180.1454575214499; Thu, 04 Feb 2016 00:40:14 -0800 (PST) Received: from xps13.localnet (136.21.90.92.rev.sfr.net. [92.90.21.136]) by smtp.gmail.com with ESMTPSA id u4sm10216504wjz.4.2016.02.04.00.40.13 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 04 Feb 2016 00:40:13 -0800 (PST) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: "Zhang, Helin" <helin.zhang@intel.com> Date: Thu, 04 Feb 2016 09:38:54 +0100 Message-ID: <6113889.ZXPIxxScSZ@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A992C27@SHSMSX104.ccr.corp.intel.com> References: <1453137515-19195-1-git-send-email-julien.meunier@6wind.com> <56B1E54A.3000900@6wind.com> <F35DEAC7BCE34641BA9FAC6BCA4A12E70A992C27@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Julien Meunier <julien.meunier@6wind.com> Subject: Re: [dpdk-dev] [PATCH v2] i40e: fix vlan filtering X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 04 Feb 2016 08:40:14 -0000 2016-02-04 00:41, Zhang, Helin: > From: Julien Meunier [mailto:julien.meunier@6wind.com] > > INFO log level is used in order to keep code homogeneity: > > i40e_vsi_config_vlan_stripping or i40e_dev_init_vlan use this log level during > > failure for example. > > > > Tell me if ERR log level for VLAN filtering issue must be set. > There is a failure, and may result in uncertain behaviors which cannot be ignored. > I'd suggest to use ERR but not INFO, though I am not so confident on that. > Could Thomas help give some guidance on that? Helin, about i40e internals, I follow your guidance :) If you consider it as a real error, yes we must log an error. About code homogeneity, Julien seems to have seen some errors in the driver which should be logged as such, right? It may be a separate effort to fix them. Thanks