From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 086AA4408B; Wed, 5 Jun 2024 09:13:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A827240649; Wed, 5 Jun 2024 09:13:56 +0200 (CEST) Received: from fout4-smtp.messagingengine.com (fout4-smtp.messagingengine.com [103.168.172.147]) by mails.dpdk.org (Postfix) with ESMTP id F211E402E5 for ; Wed, 5 Jun 2024 09:13:54 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfout.nyi.internal (Postfix) with ESMTP id 6A9FE13801B8; Wed, 5 Jun 2024 03:13:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 05 Jun 2024 03:13:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1717571634; x=1717658034; bh=eeUTlP7vVp4DLL0i+0BbS+tLiuGMDL5ogO6TyQDtKWk=; b= aJAMJqx4ix3OBLVeQpD8hRKn3vmh7gFXjAXPkB2xu3yJh6DfPAMyJOw+CYnfE7m9 xmhCO7jtRp+CjuMZhwHfh+ZHMGkN8dhrJ6ZzGbm6tnD/KyNCMLA6LFaQUaKAxVM/ MYvvrJjX+yC/ygeuLz7c+eXm/tC9RGXJOOXlR9W7Pu9WGMKDZagWmFW9qY6qhqYq RGgs9AeiJKwHptC59lTWKucExKbbdZdMR5WaTo0ple6ZnAzsHRL/cEEoh1b4mmLS uJ4XpM7U1JR4KC8VsUACQtpRvRQoywWCB9IsiAYBPyzXH8/vttRl6qpz3cMphC6z bVHobZ0HAmtxHNHFE5gXhw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1717571634; x= 1717658034; bh=eeUTlP7vVp4DLL0i+0BbS+tLiuGMDL5ogO6TyQDtKWk=; b=H IW7AbLbw1Tnhb8iQXHr78GT4n/1a/fOwE5d9hFRq/adio2bRq80L+M0jBcyFABDS C1z0lyeyXdyFm/nF6rxGIY1DrkO90HB4gAISr4FzlSOr/zcALJH0KYiCLy77It6j bSFds0PxeIztUVk9B9BXI8YsPDjnksJW0Ll9uVQicve4xq44dKqW24Z59zuQSajs HdB73AL/z6+LX/HuDmDXkegC+uxqGQFHqt2wP1+094qJkIBdk5nVgl4GbmFJiNHS X5dP2qzldLPMiZvgYgWmNbiSnelDBcg2kKcVfMxO/AeXaBnq0WQXFXGc0U/4oj0t b7FV2ifs78NbAlqk7gMRQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdelhedguddujecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeuveejffejgedtgeeg kefgvdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Jun 2024 03:13:52 -0400 (EDT) From: Thomas Monjalon To: Dariusz Sosnowski , rongwei liu Cc: "dev@dpdk.org" , Matan Azrad , Slava Ovsiienko , Ori Kam , Suanming Mou , Aman Singh , Yuying Zhang , Ferruh Yigit , Andrew Rybchenko Subject: Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved field Date: Wed, 05 Jun 2024 09:13:49 +0200 Message-ID: <6114865.NeCsiYhmir@thomas> In-Reply-To: References: <14937324.O6BkTfRZtg@thomas> <5068960.a9HWlOh95j@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 05/06/2024 03:16, rongwei liu: > From: Thomas Monjalon > > 04/06/2024 18:40, Dariusz Sosnowski: > > > > > 04/06/2024 14:38, Rongwei Liu: > > > > > > --- a/app/test-pmd/cmdline_flow.c > > > > > > +++ b/app/test-pmd/cmdline_flow.c > > > > > > @@ -1006,6 +1006,7 @@ static const char *const flow_field_ids[] = > > > > > > { > > > > > > > > > > > > "ipv6_flow_label", "ipv6_traffic_class", > > > > > > "esp_spi", "esp_seq_num", "esp_proto", > > > > > > "random", > > > > > > > > > > > > + "vxlan_last_rsvd", > > > > > > > > > > > > NULL > > > > > > > > > > > > }; > > > > > > > > > > How vxlan_last_rsvd is linked to RTE_FLOW_FIELD_VXLAN_RSVD1 in > > > > > testpmd? > > > > > Just because it is the same order? > > > > > > Yes, it's because of the order. > > > We should refactor this to use array designators. > > > > > > > > > --- a/lib/ethdev/rte_flow.h > > > > > > +++ b/lib/ethdev/rte_flow.h > > > > > > @@ -2428,6 +2428,7 @@ enum rte_flow_field_id { > > > > > > > > > > > > RTE_FLOW_FIELD_ESP_SEQ_NUM, /**< ESP Sequence Number. */ > > > > > > RTE_FLOW_FIELD_ESP_PROTO, /**< ESP next protocol > > > > > > value. */ > > > > > > RTE_FLOW_FIELD_RANDOM, /**< Random value. */ > > > > > > > > > > > > + RTE_FLOW_FIELD_VXLAN_RSVD1, /**< VXLAN last reserved > > > > > > byte. */ > > > > > > > > > > > > }; > > > > > > > > > > I think we should use the same naming as in testpmd. > > > > > What about RTE_FLOW_FIELD_VXLAN_LAST_RSVD? > > > > > > > > To be honest, no strong objection per my personal thought. > > > > Considering the API "vxlan_hdr" names this field as "uint8_t rsvd1", > > > > maybe RTE_FLOW_FIELD_VXLAN_RSVD1 will be clearer for user as 1 vs 1 > > > > mapping?> > > > > > +1 on using RSVD1 so it matches rte_vxlan_hdr definition. > > > > > > In this patch, "vxlan_last_rsvd" is used in testpmd, so it matches > > > existing "last_rsvd" field in VXLAN item. If we choose to use "rsvd1", > > > we should probably rename all other instances of "last_rsvd" to match.> > > > I prefer "vxlan_last_rsvd" for 2 reasons: > > - it is more meaningful > > - we are adding first, second and third reserved fields to match > > the 3 bytes of rsvd0 (patch to come) > > Sound clear and reasonable. I would like to propose the alignment between rte_flow_field_id and rte_vxlan_hdr: > > 1. > RTE_FLOW_FIELD_VXLAN_RSVD1 ---> RTE_FLOW_FIELD_VXLAN_LAST_RSVD > 2. > "uint8_t rsvd1" ----> "uint8_t last_rsvd" We don't change rte_vxlan_hdr, because we avoid breaking compatibility.