* [dpdk-dev] [PATCH v1] mk: fix external build failure
@ 2018-02-05 10:22 Marko Kovacevic
2018-02-05 10:37 ` Thomas Monjalon
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Marko Kovacevic @ 2018-02-05 10:22 UTC (permalink / raw)
To: dev; +Cc: thomas, olivier.matz, vipin.varghese, Marko Kovacevic, stable
Updated the make build to fix external build issues
Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project")
Cc: stable@dpdk.org
Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
---
mk/internal/rte.extvars.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mk/internal/rte.extvars.mk b/mk/internal/rte.extvars.mk
index 19594da..98c8606 100644
--- a/mk/internal/rte.extvars.mk
+++ b/mk/internal/rte.extvars.mk
@@ -20,7 +20,7 @@ ifeq ("$(origin M)", "command line")
RTE_EXTMK := $(abspath $(M))
endif
endif
-RTE_EXTMK ?= $(RTE_SRCDIR)/$(firstword $(MAKEFILE_LIST))
+RTE_EXTMK ?= $(RTE_SRCDIR)/$(notdir $(firstword $(MAKEFILE_LIST)))
export RTE_EXTMK
# RTE_SDK_BIN must point to .config, include/ and lib/.
--
2.9.5
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH v1] mk: fix external build failure
2018-02-05 10:22 [dpdk-dev] [PATCH v1] mk: fix external build failure Marko Kovacevic
@ 2018-02-05 10:37 ` Thomas Monjalon
2018-02-05 10:53 ` Kovacevic, Marko
2018-02-05 15:45 ` [dpdk-dev] [PATCH v2] " Marko Kovacevic
2018-02-05 18:26 ` [dpdk-dev] [dpdk-stable] [PATCH v1] " Thomas Monjalon
2 siblings, 1 reply; 8+ messages in thread
From: Thomas Monjalon @ 2018-02-05 10:37 UTC (permalink / raw)
To: Marko Kovacevic; +Cc: dev, olivier.matz, vipin.varghese
05/02/2018 11:22, Marko Kovacevic:
> Updated the make build to fix external build issues
Please explain what is the issue.
> Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project")
> Cc: stable@dpdk.org
No need to Cc stable when fixing a bug which is not in a major release.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH v1] mk: fix external build failure
2018-02-05 10:37 ` Thomas Monjalon
@ 2018-02-05 10:53 ` Kovacevic, Marko
2018-02-05 14:07 ` Thomas Monjalon
2018-02-05 22:38 ` Thomas Monjalon
0 siblings, 2 replies; 8+ messages in thread
From: Kovacevic, Marko @ 2018-02-05 10:53 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, olivier.matz, Varghese, Vipin
> 05/02/2018 11:22, Marko Kovacevic:
> > Updated the make build to fix external build issues
>
> Please explain what is the issue.
>
> > Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project")
> > Cc: stable@dpdk.org
>
> No need to Cc stable when fixing a bug which is not in a major release.
Olivier reported an issue this morning, that my commit was breaking
the build of one of our external module:
make[5]: /path/to/ext-module//path/to/ext-module/Makefile: No such file or directory
make[5]: *** No rule to make target '/path/to/ext-module//path/to/ext-module/Makefile'. Stop.
The reason is that entries in $(MAKEFILE_LIST) can be absolute.
Marko.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH v1] mk: fix external build failure
2018-02-05 10:53 ` Kovacevic, Marko
@ 2018-02-05 14:07 ` Thomas Monjalon
2018-02-05 22:38 ` Thomas Monjalon
1 sibling, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2018-02-05 14:07 UTC (permalink / raw)
To: Kovacevic, Marko; +Cc: dev, olivier.matz, Varghese, Vipin
05/02/2018 11:53, Kovacevic, Marko:
> > 05/02/2018 11:22, Marko Kovacevic:
> > > Updated the make build to fix external build issues
> >
> > Please explain what is the issue.
> >
> > > Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project")
> > > Cc: stable@dpdk.org
> >
> > No need to Cc stable when fixing a bug which is not in a major release.
>
> Olivier reported an issue this morning, that my commit was breaking
> the build of one of our external module:
>
> make[5]: /path/to/ext-module//path/to/ext-module/Makefile: No such file or directory
> make[5]: *** No rule to make target '/path/to/ext-module//path/to/ext-module/Makefile'. Stop.
>
> The reason is that entries in $(MAKEFILE_LIST) can be absolute.
I know that :)
I was asking to update the commit message in a v2 actually.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH v1] mk: fix external build failure
2018-02-05 10:53 ` Kovacevic, Marko
2018-02-05 14:07 ` Thomas Monjalon
@ 2018-02-05 22:38 ` Thomas Monjalon
1 sibling, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2018-02-05 22:38 UTC (permalink / raw)
To: Kovacevic, Marko; +Cc: dev, olivier.matz, Varghese, Vipin
05/02/2018 11:53, Kovacevic, Marko:
> > 05/02/2018 11:22, Marko Kovacevic:
> > > Updated the make build to fix external build issues
> >
> > Please explain what is the issue.
> >
> > > Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project")
> > > Cc: stable@dpdk.org
> >
> > No need to Cc stable when fixing a bug which is not in a major release.
Sorry for the confusion.
In this case, Cc stable is needed because it fixes a fix of a bug
seen with previous releases.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-dev] [PATCH v2] mk: fix external build failure
2018-02-05 10:22 [dpdk-dev] [PATCH v1] mk: fix external build failure Marko Kovacevic
2018-02-05 10:37 ` Thomas Monjalon
@ 2018-02-05 15:45 ` Marko Kovacevic
2018-02-05 22:39 ` Thomas Monjalon
2018-02-05 18:26 ` [dpdk-dev] [dpdk-stable] [PATCH v1] " Thomas Monjalon
2 siblings, 1 reply; 8+ messages in thread
From: Marko Kovacevic @ 2018-02-05 15:45 UTC (permalink / raw)
To: dev; +Cc: thomas, olivier.matz, vipin.varghese, Marko Kovacevic
Code commit for 'make -f' support, breaks the build in cases where
entries in $(MAKEFILE_LIST) are absolute paths. This commit uses
notdir and firstword to ensure that only the local filename is used.
Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project")
Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
---
mk/internal/rte.extvars.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mk/internal/rte.extvars.mk b/mk/internal/rte.extvars.mk
index 19594da..98c8606 100644
--- a/mk/internal/rte.extvars.mk
+++ b/mk/internal/rte.extvars.mk
@@ -20,7 +20,7 @@ ifeq ("$(origin M)", "command line")
RTE_EXTMK := $(abspath $(M))
endif
endif
-RTE_EXTMK ?= $(RTE_SRCDIR)/$(firstword $(MAKEFILE_LIST))
+RTE_EXTMK ?= $(RTE_SRCDIR)/$(notdir $(firstword $(MAKEFILE_LIST)))
export RTE_EXTMK
# RTE_SDK_BIN must point to .config, include/ and lib/.
--
2.9.5
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH v2] mk: fix external build failure
2018-02-05 15:45 ` [dpdk-dev] [PATCH v2] " Marko Kovacevic
@ 2018-02-05 22:39 ` Thomas Monjalon
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2018-02-05 22:39 UTC (permalink / raw)
To: Marko Kovacevic; +Cc: dev, olivier.matz, vipin.varghese
05/02/2018 16:45, Marko Kovacevic:
> Code commit for 'make -f' support, breaks the build in cases where
> entries in $(MAKEFILE_LIST) are absolute paths. This commit uses
> notdir and firstword to ensure that only the local filename is used.
>
> Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project")
>
> Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
Applied, thanks
(please ignore previous reply to v1, the applied version is v2)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH v1] mk: fix external build failure
2018-02-05 10:22 [dpdk-dev] [PATCH v1] mk: fix external build failure Marko Kovacevic
2018-02-05 10:37 ` Thomas Monjalon
2018-02-05 15:45 ` [dpdk-dev] [PATCH v2] " Marko Kovacevic
@ 2018-02-05 18:26 ` Thomas Monjalon
2 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2018-02-05 18:26 UTC (permalink / raw)
To: Marko Kovacevic; +Cc: dev, olivier.matz, vipin.varghese
05/02/2018 11:22, Marko Kovacevic:
> Updated the make build to fix external build issues
>
> Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project")
> Cc: stable@dpdk.org
>
> Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-02-05 22:39 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-05 10:22 [dpdk-dev] [PATCH v1] mk: fix external build failure Marko Kovacevic
2018-02-05 10:37 ` Thomas Monjalon
2018-02-05 10:53 ` Kovacevic, Marko
2018-02-05 14:07 ` Thomas Monjalon
2018-02-05 22:38 ` Thomas Monjalon
2018-02-05 15:45 ` [dpdk-dev] [PATCH v2] " Marko Kovacevic
2018-02-05 22:39 ` Thomas Monjalon
2018-02-05 18:26 ` [dpdk-dev] [dpdk-stable] [PATCH v1] " Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).