[dpdk-dev] [PATCH 0/2] Change optimization flag for Intel QuickAssist Technology driver Makefile

[dpdk-dev] [PATCH 0/2] Change optimization flag for Intel QuickAssist Technology driver Makefile

[Arek Kusztal]

This patch changes to -O3 optimization flag in Intel QuickAssist Technology driver Makefile

Arek Kusztal (2):
  qat: add aad_len variable to avoid GCC break strict-aliasing rules
    warning
  qat: change optimization flag for Intel QuickAssist Technology
    Makefile

 drivers/crypto/qat/Makefile                      | 1 +
 drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 8 +++++---
 2 files changed, 6 insertions(+), 3 deletions(-)

-- 
2.1.0

[dpdk-dev] [PATCH 1/2] qat: add aad_len variable to avoid GCC break strict-aliasing rules warning

[Arek Kusztal]

To avoid GCC warning about "dereferencing type-punned pointer will break
strict-aliasing rules" aad_len pointer is dereferenced instead of direct
dereferencing of uint32_t* cast of the middle of an array.

Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
 drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c b/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
index bcccdf4..a5210d2 100644
--- a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
+++ b/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
@@ -616,10 +616,12 @@ int qat_alg_aead_session_create_content_desc_auth(struct qat_session *cdesc,
 		 * Write (the length of AAD) into bytes 16-19 of state2
 		 * in big-endian format. This field is 8 bytes
 		 */
-		*(uint32_t *)&(hash->sha.state1[
+		uint32_t *aad_len = (uint32_t *)&hash->sha.state1[
 					ICP_QAT_HW_GALOIS_128_STATE1_SZ +
-					ICP_QAT_HW_GALOIS_H_SZ]) =
-			rte_bswap32(add_auth_data_length);
+						ICP_QAT_HW_GALOIS_H_SZ];
+
+		*aad_len = rte_bswap32(add_auth_data_length);
+
 		proto = ICP_QAT_FW_LA_GCM_PROTO;
 	} else if (cdesc->qat_hash_alg == ICP_QAT_HW_AUTH_ALGO_SNOW_3G_UIA2)  {
 		proto = ICP_QAT_FW_LA_SNOW_3G_PROTO;
-- 
2.1.0

[dpdk-dev] [PATCH 2/2] qat: change optimization flag for Intel QuickAssist Technology Makefile

[Arek Kusztal]

Changed to -O3 optimization flag in Intel QuickAssist Technology Makefile

Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
 drivers/crypto/qat/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/qat/Makefile b/drivers/crypto/qat/Makefile
index 258c2d5..ee72a61 100644
--- a/drivers/crypto/qat/Makefile
+++ b/drivers/crypto/qat/Makefile
@@ -38,6 +38,7 @@ LIBABIVER := 1
 
 # build flags
 CFLAGS += $(WERROR_FLAGS)
+CFLAGS += -O3
 
 # external library include paths
 CFLAGS += -I$(SRCDIR)/qat_adf
-- 
2.1.0

Re: [dpdk-dev] [PATCH 0/2] Change optimization flag for Intel QuickAssist Technology driver Makefile

[Jain, Deepak K]

> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Tuesday, June 7, 2016 5:58 PM
> To: dev@dpdk.org
> Cc: Trahe, Fiona <fiona.trahe@intel.com>; Griffin, John
> <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>;
> Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH 0/2] Change optimization flag for Intel QuickAssist
> Technology driver Makefile
> 
> This patch changes to -O3 optimization flag in Intel QuickAssist Technology
> driver Makefile
> 
> Arek Kusztal (2):
>   qat: add aad_len variable to avoid GCC break strict-aliasing rules
>     warning
>   qat: change optimization flag for Intel QuickAssist Technology
>     Makefile
> 
>  drivers/crypto/qat/Makefile                      | 1 +
>  drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 8 +++++---
>  2 files changed, 6 insertions(+), 3 deletions(-)
> 
> --
> 2.1.0

Series-Acked-by: Deepak Kumar JAIN <deepak.k.jain@intel.com

Re: [dpdk-dev] [PATCH 0/2] Change optimization flag for Intel QuickAssist Technology driver Makefile

[Thomas Monjalon]

> > This patch changes to -O3 optimization flag in Intel QuickAssist Technology
> > driver Makefile
> > 
> > Arek Kusztal (2):
> >   qat: add aad_len variable to avoid GCC break strict-aliasing rules
> >     warning
> >   qat: change optimization flag for Intel QuickAssist Technology
> >     Makefile
> 
> Series-Acked-by: Deepak Kumar JAIN <deepak.k.jain@intel.com

Applied with spacing fix, thanks