* [dpdk-dev] [PATCH] eal: add missing include to debug header
@ 2016-05-04 16:37 Bruce Richardson
2016-05-05 12:59 ` Bruce Richardson
0 siblings, 1 reply; 4+ messages in thread
From: Bruce Richardson @ 2016-05-04 16:37 UTC (permalink / raw)
To: dev; +Cc: thomas.monjalon, Bruce Richardson
The header file rte_debug.h makes use of the "unlikely" macro which
means it should include the rte_branch_prediction.h header file.
Fixes: 50705e8e3cdd ("eal: add assert macro for debug")
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
lib/librte_eal/common/include/rte_debug.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/common/include/rte_debug.h b/lib/librte_eal/common/include/rte_debug.h
index 9260eda..cab6fb4 100644
--- a/lib/librte_eal/common/include/rte_debug.h
+++ b/lib/librte_eal/common/include/rte_debug.h
@@ -44,6 +44,7 @@
*/
#include "rte_log.h"
+#include "rte_branch_prediction.h"
#ifdef __cplusplus
extern "C" {
--
2.5.5
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] eal: add missing include to debug header
2016-05-04 16:37 [dpdk-dev] [PATCH] eal: add missing include to debug header Bruce Richardson
@ 2016-05-05 12:59 ` Bruce Richardson
2016-05-05 16:07 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Bruce Richardson @ 2016-05-05 12:59 UTC (permalink / raw)
To: dev; +Cc: thomas.monjalon
On Wed, May 04, 2016 at 05:37:56PM +0100, Bruce Richardson wrote:
> The header file rte_debug.h makes use of the "unlikely" macro which
> means it should include the rte_branch_prediction.h header file.
>
> Fixes: 50705e8e3cdd ("eal: add assert macro for debug")
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> lib/librte_eal/common/include/rte_debug.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_eal/common/include/rte_debug.h b/lib/librte_eal/common/include/rte_debug.h
> index 9260eda..cab6fb4 100644
> --- a/lib/librte_eal/common/include/rte_debug.h
> +++ b/lib/librte_eal/common/include/rte_debug.h
> @@ -44,6 +44,7 @@
> */
>
> #include "rte_log.h"
> +#include "rte_branch_prediction.h"
>
> #ifdef __cplusplus
> extern "C" {
Ping on this patch - any comments or concerns?
It's a fairly trivial fix that prevents issues with testing some other patches
on the mainline.
Regards,
/Bruce
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] eal: add missing include to debug header
2016-05-05 12:59 ` Bruce Richardson
@ 2016-05-05 16:07 ` Ferruh Yigit
2016-05-05 20:49 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2016-05-05 16:07 UTC (permalink / raw)
To: Bruce Richardson, dev; +Cc: thomas.monjalon
On 5/5/2016 1:59 PM, Bruce Richardson wrote:
> On Wed, May 04, 2016 at 05:37:56PM +0100, Bruce Richardson wrote:
>> The header file rte_debug.h makes use of the "unlikely" macro which
>> means it should include the rte_branch_prediction.h header file.
>>
>> Fixes: 50705e8e3cdd ("eal: add assert macro for debug")
>>
>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>> ---
>> lib/librte_eal/common/include/rte_debug.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/librte_eal/common/include/rte_debug.h b/lib/librte_eal/common/include/rte_debug.h
>> index 9260eda..cab6fb4 100644
>> --- a/lib/librte_eal/common/include/rte_debug.h
>> +++ b/lib/librte_eal/common/include/rte_debug.h
>> @@ -44,6 +44,7 @@
>> */
>>
>> #include "rte_log.h"
>> +#include "rte_branch_prediction.h"
>>
>> #ifdef __cplusplus
>> extern "C" {
>
> Ping on this patch - any comments or concerns?
> It's a fairly trivial fix that prevents issues with testing some other patches
> on the mainline.
>
Tested on top of David Marchand's 12123-12139 patchset.
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] eal: add missing include to debug header
2016-05-05 16:07 ` Ferruh Yigit
@ 2016-05-05 20:49 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2016-05-05 20:49 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, Ferruh Yigit
2016-05-05 17:07, Ferruh Yigit:
> On 5/5/2016 1:59 PM, Bruce Richardson wrote:
> > On Wed, May 04, 2016 at 05:37:56PM +0100, Bruce Richardson wrote:
> >> The header file rte_debug.h makes use of the "unlikely" macro which
> >> means it should include the rte_branch_prediction.h header file.
> >>
> >> Fixes: 50705e8e3cdd ("eal: add assert macro for debug")
> >>
> >> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> >
> > Ping on this patch - any comments or concerns?
> > It's a fairly trivial fix that prevents issues with testing some other patches
> > on the mainline.
> >
>
> Tested on top of David Marchand's 12123-12139 patchset.
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
Sorry for the delay, I was gardening today :)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-05-05 20:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-04 16:37 [dpdk-dev] [PATCH] eal: add missing include to debug header Bruce Richardson
2016-05-05 12:59 ` Bruce Richardson
2016-05-05 16:07 ` Ferruh Yigit
2016-05-05 20:49 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).