From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49])
 by dpdk.org (Postfix) with ESMTP id F399D69FE
 for <dev@dpdk.org>; Wed,  6 Jul 2016 11:10:50 +0200 (CEST)
Received: by mail-wm0-f49.google.com with SMTP id r201so184005170wme.1
 for <dev@dpdk.org>; Wed, 06 Jul 2016 02:10:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=09JPfEKiJRe4G9LuWqoTszqN8lBWfGHpUWNJ2k9hIZc=;
 b=mSrqFjw+cy+C66Euh1X2CqVGNGfyqErvsrgjmKUl4EFHwyoJrGUboCLwypqMe0e4Y9
 r+idmjPXigTc00wp4pWYbmoYpTm8qG391jDUebvvfni00kS4GkW9hns5driFVhxyc6Sk
 y+GmZTRMdi07x1NEeWm3T6egXIRWGLuNRbOZo+0cDMbkEVs9Rwt5nbaVix8MAw+/1rxN
 C9Jw6AXNAJlNMTTz6IDCmQFbNaKEaDv6qJx0a4feapvpj6eTaThkMg9/jgbII4LOYafw
 LN+cl65Q7+9uJxN+j9TNMtsiGwAiDU9MfINnCjVImk9qFw//I3n4sXyk0/37JoehLFNe
 /XFw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=09JPfEKiJRe4G9LuWqoTszqN8lBWfGHpUWNJ2k9hIZc=;
 b=XDGJvNJlVBBwyJoR5gn+SAiDFm87WwWDOGCb0luTsUHtadfssLpyvReubV1suK5j82
 WTBcbbLbhwC0nsYFBc3LXSSxqvKgtliox+js16VKPJ7BjIHReS3RDDNQFLw6833Mtkdx
 3KWy0YivXsE/13iSgG6odpUJM1f8Wxlw6I21dCtg1EQHK2cSZA5n96TimShwU4k9KpIA
 POpSDbqoAkBBtdD9pzDzewSxNKgJiAwMsMjfjXuchzzmGDPdo0ggOVVEcxFtNkRnGyjF
 Hn06h7gpo1k/2uDEgU70B1j7Ro4A3H2cmy8r9j7g5Ln02iK7Nrntzp6ovXGi5ZvIhU+F
 VhQg==
X-Gm-Message-State: ALyK8tJEFEgEgwxdqy2rCiACPglafLTm0OqUy5njzgV3Wi+uR2/SH1b6P30fOyKomP8faYR5
X-Received: by 10.194.116.134 with SMTP id jw6mr5167805wjb.0.1467796250761;
 Wed, 06 Jul 2016 02:10:50 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id q63sm2850504wma.0.2016.07.06.02.10.49
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 06 Jul 2016 02:10:49 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, nelio.laranjeiro@6wind.com
Date: Wed, 06 Jul 2016 11:10:48 +0200
Message-ID: <6142444.k3HLHFvhXo@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1467729650-925-1-git-send-email-bruce.richardson@intel.com>
References: <1467729650-925-1-git-send-email-bruce.richardson@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] scripts: add check for net driver names
	without net prefix
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Jul 2016 09:10:51 -0000

2016-07-05 15:40, Bruce Richardson:
> +# check headline label for net/ prefix if needed
> +bad=$(echo "$headlines" | grep -E --color=always \
> +	-e "^($(ls drivers/net | grep -v Makefile | tr '\n' '|')):" \
> +	| sed 's,^,\t,')
> +[ -z "$bad" ] || printf "Headline missing 'net/' prefix:\n$bad\n"

This check is definitely a good idea.
We need the same thing for crypto.
Few nits:
- -E is not needed for this regex
- "/base:" cases are not handled because of the colon at the end
of the regex.
- patches touching several drivers are not handled. Examples:
  "mlx:" -> "net/mlx:"
  "drivers/net:" -> "net:"

By the way, I am looking at an idea, that Nelio sent me, based on
modified files. It can complete this check.