DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v3] Modify tools/setup.sh to be compatible with fedora 21
@ 2014-10-10 10:08 Daniel Mrzyglod
  2014-10-10 11:33 ` Neil Horman
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Mrzyglod @ 2014-10-10 10:08 UTC (permalink / raw)
  To: dev

script was expecting /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko but in fedora 21
there are Compressed kernel modules - xz (LZMA)

V3 patch: Remove sudo
V2 patch: Use modinfo instead ls
V1 patch: use ls instead checking if specific file exist

Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
---
 tools/setup.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/setup.sh b/tools/setup.sh
index 369e09e..14e319c 100755
--- a/tools/setup.sh
+++ b/tools/setup.sh
@@ -169,7 +169,8 @@ load_igb_uio_module()
 
 	/sbin/lsmod | grep -s uio > /dev/null
 	if [ $? -ne 0 ] ; then
-		if [ -f /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko ] ; then
+		modinfo uio > /dev/null
+		if [ $? -eq 0 ]; then
 			echo "Loading uio module"
 			sudo /sbin/modprobe uio
 		fi
-- 
2.1.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH v3] Modify tools/setup.sh to be compatible with fedora 21
  2014-10-10 10:08 [dpdk-dev] [PATCH v3] Modify tools/setup.sh to be compatible with fedora 21 Daniel Mrzyglod
@ 2014-10-10 11:33 ` Neil Horman
  2014-10-10 15:58   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Neil Horman @ 2014-10-10 11:33 UTC (permalink / raw)
  To: Daniel Mrzyglod; +Cc: dev

On Fri, Oct 10, 2014 at 11:08:08AM +0100, Daniel Mrzyglod wrote:
> script was expecting /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko but in fedora 21
> there are Compressed kernel modules - xz (LZMA)
> 
> V3 patch: Remove sudo
> V2 patch: Use modinfo instead ls
> V1 patch: use ls instead checking if specific file exist
> 
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> ---
>  tools/setup.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/setup.sh b/tools/setup.sh
> index 369e09e..14e319c 100755
> --- a/tools/setup.sh
> +++ b/tools/setup.sh
> @@ -169,7 +169,8 @@ load_igb_uio_module()
>  
>  	/sbin/lsmod | grep -s uio > /dev/null
>  	if [ $? -ne 0 ] ; then
> -		if [ -f /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko ] ; then
> +		modinfo uio > /dev/null
> +		if [ $? -eq 0 ]; then
>  			echo "Loading uio module"
>  			sudo /sbin/modprobe uio
>  		fi
> -- 
> 2.1.0
> 
> 
Acked-by: Neil Horman <nhorman@tuxdriver.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH v3] Modify tools/setup.sh to be compatible with fedora 21
  2014-10-10 11:33 ` Neil Horman
@ 2014-10-10 15:58   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2014-10-10 15:58 UTC (permalink / raw)
  To: Daniel Mrzyglod; +Cc: dev

> > script was expecting /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko but in fedora 21
> > there are Compressed kernel modules - xz (LZMA)
> > 
> > V3 patch: Remove sudo
> > V2 patch: Use modinfo instead ls
> > V1 patch: use ls instead checking if specific file exist
> > 
> > Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> 
> Acked-by: Neil Horman <nhorman@tuxdriver.com>

Applied

Thanks
-- 
Thomas

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-10-10 15:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-10 10:08 [dpdk-dev] [PATCH v3] Modify tools/setup.sh to be compatible with fedora 21 Daniel Mrzyglod
2014-10-10 11:33 ` Neil Horman
2014-10-10 15:58   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).