From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 008DFA09E4; Fri, 29 Jan 2021 16:47:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7964A4067B; Fri, 29 Jan 2021 16:47:43 +0100 (CET) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by mails.dpdk.org (Postfix) with ESMTP id 7A9C740395 for ; Fri, 29 Jan 2021 16:47:42 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 93C9658080C; Fri, 29 Jan 2021 10:47:41 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 29 Jan 2021 10:47:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= 2kLddwZo83JWqmjQ3BLq6w//1qBeSPNT+Ivsu3Hitwo=; b=OXHHlPA/Vcar+7YZ ImBQ4+n8UmrcMFZfKncKe6ZuJaH6FEliEpIEt670D2awwW8Guyfo+FOgsg/QmbUR JG00Dj/fmxpwfacGV9uJO0LJKyflTj9eNGdj16FyU09xVIEMfy2MROZZhJWnD5W9 oCAohBiH7kaUsBfIS036X8sDto9E/DxEQG9W3Nz5eAjQzbFoPBfSfwu0rXUs2LuI //msCOf8zntn5S6W5toH6umOAky7vhkPuIpwXsHIOI8Ykeo3qK0GRLUMgbdCuQqf RqAXwnFT4y5gt6EzWEaBk3E4e7rCJHJpPyXPd+VQU8pNEC/zn5u5FfO4r6xWvc2h lb2/Zw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=2kLddwZo83JWqmjQ3BLq6w//1qBeSPNT+Ivsu3Hit wo=; b=BjTQUP41KkrAbvak9Mo+gzxsbaHP916G7y7r7DFxSn1/GKE5txtx+RIxq 3dV2/LvMytR3Zm/RddZUR7NukVkmehErQO9RkrCRZsZ1VVNGsTzuU41/5rQPtGUD UalWK5W96Ink/08clt1NbERALUNZNtDSg91laYaPR6jXmS2DubnuqiYZWqrF1UuQ waKDFqPtc2rDmpd/rWovrgHQ02hCFbbT/zM3ac8agSOrXKkkw2S/5eJtdsvSfPls kqHgtTde7XUBOe1uB32lfIwMK57on2AzDIYDreKIBE898US4ivXXlmu68/b5xaaE UzbDRffpT8paweK98Nx8Yr6W24e0w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedvgdektdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeettefguefgkefgieevleejjeelvedvjedvveekueekheefvddvkeff tdffheetudenucffohhmrghinhepvgigihhsthdruggvrghlpdhgnhhurdhorhhgnecukf hppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E6AC31080063; Fri, 29 Jan 2021 10:47:36 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, Gregory Etelson , Bruce Richardson , Nicolas Chautru , Chas Williams , "Min Hu (Connor)" , Olivier Matz , David Hunt , Harry van Haaren , Marko Kovacevic , Bernard Iremonger , Ori Kam , Konstantin Ananyev , Cristian Dumitrescu , Radu Nicolau , Akhil Goyal , Ferruh Yigit , Tomasz Kantecki , Declan Doherty , Sunil Kumar Kori , Pavan Nikhilesh , Jerin Jacob , Kiran Kumar K , Nithin Dabilpuram , Anatoly Burakov , Xiaoyun Li , Jingjing Wu , Reshma Pattan , John McNamara , Kirill Rybalchenko , Jasvinder Singh , Byron Marohn , Yipeng Wang , Robert Sanford , Erik Gabriel Carrillo , Maxime Coquelin , Chenbo Xia Date: Fri, 29 Jan 2021 16:47:35 +0100 Message-ID: <6153571.i5FVJI79gW@thomas> In-Reply-To: <20210119130324.154030-1-bruce.richardson@intel.com> References: <20210119130324.154030-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] examples: warn about broken pkg-config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/01/2021 14:03, Bruce Richardson: > Since the examples are designed to be built by end-users using Make, we > can detect and warn about broken pkg-config on the user's system as part > of the build process. > > Signed-off-by: Bruce Richardson > --- > examples/bbdev_app/Makefile | 8 ++++++++ > examples/bond/Makefile | 8 ++++++++ > examples/cmdline/Makefile | 8 ++++++++ > examples/distributor/Makefile | 8 ++++++++ > examples/ethtool/ethtool-app/Makefile | 8 ++++++++ > examples/eventdev_pipeline/Makefile | 8 ++++++++ > examples/fips_validation/Makefile | 8 ++++++++ > examples/flow_classify/Makefile | 8 ++++++++ > examples/flow_filtering/Makefile | 8 ++++++++ > examples/helloworld/Makefile | 8 ++++++++ > examples/ioat/Makefile | 8 ++++++++ > examples/ip_fragmentation/Makefile | 11 ++++++++++- > examples/ip_pipeline/Makefile | 8 ++++++++ > examples/ip_reassembly/Makefile | 8 ++++++++ > examples/ipsec-secgw/Makefile | 8 ++++++++ > examples/ipv4_multicast/Makefile | 8 ++++++++ > examples/kni/Makefile | 8 ++++++++ > examples/l2fwd-cat/Makefile | 8 ++++++++ > examples/l2fwd-crypto/Makefile | 8 ++++++++ > examples/l2fwd-event/Makefile | 8 ++++++++ > examples/l2fwd-jobstats/Makefile | 8 ++++++++ > examples/l2fwd-keepalive/Makefile | 8 ++++++++ > examples/l2fwd-keepalive/ka-agent/Makefile | 8 ++++++++ > examples/l2fwd/Makefile | 8 ++++++++ > examples/l3fwd-acl/Makefile | 8 ++++++++ > examples/l3fwd-graph/Makefile | 12 +++++++++++- > examples/l3fwd-power/Makefile | 8 ++++++++ > examples/l3fwd/Makefile | 8 ++++++++ > examples/link_status_interrupt/Makefile | 8 ++++++++ > .../client_server_mp/mp_client/Makefile | 8 ++++++++ > .../client_server_mp/mp_server/Makefile | 8 ++++++++ > examples/multi_process/hotplug_mp/Makefile | 8 ++++++++ > examples/multi_process/simple_mp/Makefile | 8 ++++++++ > examples/multi_process/symmetric_mp/Makefile | 8 ++++++++ > examples/ntb/Makefile | 11 ++++++++++- > examples/packet_ordering/Makefile | 8 ++++++++ > examples/performance-thread/l3fwd-thread/Makefile | 8 ++++++++ > examples/performance-thread/pthread_shim/Makefile | 8 ++++++++ > examples/pipeline/Makefile | 8 ++++++++ > examples/ptpclient/Makefile | 8 ++++++++ > examples/qos_meter/Makefile | 8 ++++++++ > examples/qos_sched/Makefile | 8 ++++++++ > examples/rxtx_callbacks/Makefile | 8 ++++++++ > examples/server_node_efd/node/Makefile | 8 ++++++++ > examples/server_node_efd/server/Makefile | 8 ++++++++ > examples/service_cores/Makefile | 8 ++++++++ > examples/skeleton/Makefile | 8 ++++++++ > examples/timer/Makefile | 8 ++++++++ > examples/vdpa/Makefile | 8 ++++++++ > examples/vhost/Makefile | 8 ++++++++ > examples/vhost_blk/Makefile | 8 ++++++++ > examples/vhost_crypto/Makefile | 8 ++++++++ > examples/vm_power_manager/Makefile | 8 ++++++++ > examples/vm_power_manager/guest_cli/Makefile | 8 ++++++++ > examples/vmdq/Makefile | 8 ++++++++ > examples/vmdq_dcb/Makefile | 8 ++++++++ > 56 files changed, 455 insertions(+), 3 deletions(-) That's a lot of duplicated code that may need some extension in future. What about having a file examples/common.mk to include? With the special syntax -include there will be no error in case ../common.mk does not exist. Deal? ref: https://www.gnu.org/software/make/manual/html_node/Include.html