From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Qiu, Michael" <michael.qiu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] lib/librte_eal: Fix compile issue with gcc 5.3.1
Date: Thu, 28 Jan 2016 09:34:55 +0100 [thread overview]
Message-ID: <6157230.jKGj62o0dz@xps13> (raw)
In-Reply-To: <8F6C2BD409508844A0EFC19955BE0941033AB5E7@SHSMSX103.ccr.corp.intel.com>
2016-01-28 08:01, Wang, Zhihong:
> > In fedora 22 with GCC version 5.3.1, when compile,
> > will result an error:
> >
> > include/rte_memcpy.h:309:7: error: "RTE_MACHINE_CPUFLAG_AVX2"
> > is not defined [-Werror=undef]
> > #elif RTE_MACHINE_CPUFLAG_AVX2
> >
> > Fixes: 9484092baad3 ("eal/x86: optimize memcpy for AVX512 platforms")
> >
> > Signed-off-by: Michael Qiu <michael.qiu@intel.com>
>
> There's issue in the original code.
>
> #elif works with statements:
> #elif < statement: true or false>
>
> But what it meant is whether the identifier has been defined:
> #elif defined <identifier>
>
> Thanks for correcting this!
>
> Acked-by: Wang, Zhihong <zhihong.wang@intel.com>
Applied, thanks
next prev parent reply other threads:[~2016-01-28 8:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 7:30 Michael Qiu
2016-01-28 8:01 ` Wang, Zhihong
2016-01-28 8:34 ` Thomas Monjalon [this message]
2016-01-28 8:30 ` Thomas Monjalon
2016-01-28 8:37 ` Qiu, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6157230.jKGj62o0dz@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=michael.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).