From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 28A6B1B656 for ; Mon, 23 Oct 2017 16:50:29 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8B10D208B2; Mon, 23 Oct 2017 10:50:28 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 23 Oct 2017 10:50:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=UBwPe2dWEYI4gWcx1MUKRG628Q nE8RhkPUHYqjHmks0=; b=SYoWF+n4J2LgIXSqSEP3OEuegLfJfYPI/MqX7L8dFE 6tZa+yg9g3rXBRs0w0/KIF1JJ7WR5y9P0Qmn71nH+MvPWE5UzIwKd2IC4dXNSJ19 4wyfxCtPgEVvxZeG15JDvwLZkJse8JJuBSQyJGQFq7lXPt39sWqMh2IRRqHbvCWA M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=UBwPe2 dWEYI4gWcx1MUKRG628QnE8RhkPUHYqjHmks0=; b=Ay2DG8TvfqiLFOYvXjq21e Q4SwLTpmHjOs2RKyVcZBYighRBAyEvsahLLd4F0vYTKcaHXnJ8HwKvedagMGPoWw 15860XPxC0i07sJVZ3kmhrmkwRL8hYNHZQMVAjV2clyDPip6aXZ2IXCfrDnuTXMW 3ItRpon1gCpbd5cv4U2ZnSFZe1lC36WVpFV2VK/2tkz8rnaYfsdu2LzZxWWIxz3F aGOCI8NQraPfUD38I8q2uJFELA6BsphBj4CG5FoZ/Uto3T4+nIRoaYEdGQsL6pR+ 9VzmSO4B4ep4OGMCFHFRvSWpzTOz13Siut0ZgjEfUbfYEaE78QzuhfsL/BRO63Sg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3CC757FA80; Mon, 23 Oct 2017 10:50:28 -0400 (EDT) From: Thomas Monjalon To: Santosh Shukla Cc: dev@dpdk.org, olivier.matz@6wind.com, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com Date: Mon, 23 Oct 2017 16:50:27 +0200 Message-ID: <6160278.vMk2a8irLz@xps> In-Reply-To: <20171016134247.5431-1-santosh.shukla@caviumnetworks.com> References: <20171016134247.5431-1-santosh.shukla@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 1/2] mempool/octeontx: move mbox from event to mempool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2017 14:50:29 -0000 16/10/2017 15:42, Santosh Shukla: > Octeontx mempool pmd need mailbox for pool setup. > That mailbox was defined at drivers/event/octeontx. > So mempool has dependency on event/octeontx driver and > commit:8700239f7767 has added make rule which makes sure event/* > get build before mempool, but this rule introduces > cyclic dependency and may create problem to future > feature addition in drivers/Makefile. > > Same problem noticed and reported in below thread: > http://dpdk.org/ml/archives/dev/2017-October/079187.html > > The patch solves problem by moving mbox definition from > drivers/event/octeontx to drivers/mempool/octeontx. > Moving mbox files involves below changes: > > * Renamed ssovf_mbox.[ch] --> octeontx_mbox.[ch] > * Renamed ssovf_probe.c --> octeontx_ssovf.c > * Introduced pool logger file. > * Moved API from rte_pmd_octeontx_ssovf_version.map to > rte_mempool_octeontx_version.map. > * Respective Makefile changes done in > drivers/event/octeontx/Makefile and drivers/mempool/octeontx/Makefile. > > Fixes: 8700239f7767 ("mempool/octeontx: add build and log infrastructure") > > Reported-by: Hemant Agrawal > Signed-off-by: Santosh Shukla There is a 32-bit compilation issues: - fpavf_log_dbg("buffer exist in pool cnt %ld\n", cnt); + fpavf_log_dbg("buffer exist in pool cnt %" PRId64 "\n", cnt); Fixed when applying