Re: [dpdk-dev] [PATCH v5 1/3] net/thunderx: enable build only on 64-bit Linux

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 10/4/2021 6:56 AM, pbhagavatula@marvell.com wrote:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Due to Linux kernel AF(Admin function) driver dependency, only enable
> build for 64-bit Linux.
> 

Hi Pavan,

Isn't it possible to provide a commit log in the kernel side etc, that let
others to verify why only 64 bit is required, or if someone want to support
32bit that may help them to investigate the source of the restriction.

> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
>  v5 Changes
>  - s/fuction/function.
> 
>  v4 Changes:
>  - Update commit message regarding dependency on AF driver.
> 
>  drivers/net/thunderx/meson.build | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/thunderx/meson.build b/drivers/net/thunderx/meson.build
> index 4bbcea7f93..da665bd76f 100644
> --- a/drivers/net/thunderx/meson.build
> +++ b/drivers/net/thunderx/meson.build
> @@ -1,9 +1,9 @@
>  # SPDX-License-Identifier: BSD-3-Clause
>  # Copyright(c) 2017 Cavium, Inc
> 
> -if is_windows
> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
>      build = false
> -    reason = 'not supported on Windows'
> +    reason = 'only supported on 64-bit Linux'
>      subdir_done()
>  endif
> 
> --
> 2.17.1
>