[dpdk-dev] [PATCH 1/7] common/octeontx: enable build only on 64bit Linux

[dpdk-dev] [PATCH 1/7] common/octeontx: enable build only on 64bit Linux

[pbhagavatula]

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Due to Linux kernel dependency, only enable build for 64bit Linux.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
 drivers/common/octeontx/meson.build  | 6 ++++++
 drivers/common/octeontx2/meson.build | 4 ++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/common/octeontx/meson.build b/drivers/common/octeontx/meson.build
index 203d1ef49..f29b58320 100644
--- a/drivers/common/octeontx/meson.build
+++ b/drivers/common/octeontx/meson.build
@@ -2,4 +2,10 @@
 # Copyright(c) 2018 Cavium, Inc
 #
 
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
+	build = false
+	reason = 'only supported on 64-bit Linux'
+	subdir_done()
+endif
+
 sources = files('octeontx_mbox.c')
diff --git a/drivers/common/octeontx2/meson.build b/drivers/common/octeontx2/meson.build
index 84fb11524..3ae106792 100644
--- a/drivers/common/octeontx2/meson.build
+++ b/drivers/common/octeontx2/meson.build
@@ -2,9 +2,9 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #
 
-if not dpdk_conf.get('RTE_ARCH_64')
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
 	build = false
-	reason = 'only supported on 64-bit'
+	reason = 'only supported on 64-bit Linux'
 	subdir_done()
 endif
 
-- 
2.17.1

[dpdk-dev] [PATCH 2/7] mempool/octeontx: enable build only on 64bit Linux

[pbhagavatula]

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Due to Linux kernel dependency, only enable build for 64bit Linux.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
 drivers/mempool/octeontx/meson.build  | 5 +++--
 drivers/mempool/octeontx2/meson.build | 9 ++-------
 2 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/drivers/mempool/octeontx/meson.build b/drivers/mempool/octeontx/meson.build
index b5695a932..4607dfe23 100644
--- a/drivers/mempool/octeontx/meson.build
+++ b/drivers/mempool/octeontx/meson.build
@@ -1,9 +1,10 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Cavium, Inc
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
 	build = false
-	reason = 'not supported on Windows'
+	reason = 'only supported on 64-bit Linux'
+	subdir_done()
 endif
 
 sources = files('octeontx_fpavf.c',
diff --git a/drivers/mempool/octeontx2/meson.build b/drivers/mempool/octeontx2/meson.build
index 0586321ab..c67d8e2d2 100644
--- a/drivers/mempool/octeontx2/meson.build
+++ b/drivers/mempool/octeontx2/meson.build
@@ -2,14 +2,9 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
 	build = false
-	reason = 'not supported on Windows'
-	subdir_done()
-endif
-if not dpdk_conf.get('RTE_ARCH_64')
-	build = false
-	reason = 'only supported on 64-bit'
+	reason = 'only supported on 64-bit Linux'
 	subdir_done()
 endif
 
-- 
2.17.1

[dpdk-dev] [PATCH 3/7] net/octeontx: enable build only on 64bit Linux

[pbhagavatula]

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Due to Linux kernel dependency, only enable build for 64bit Linux.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
 drivers/net/octeontx/meson.build  |  4 ++--
 drivers/net/octeontx2/meson.build | 10 ++--------
 drivers/net/thunderx/meson.build  |  4 ++--
 3 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/drivers/net/octeontx/meson.build b/drivers/net/octeontx/meson.build
index 4e784b948..a0d0fb80e 100644
--- a/drivers/net/octeontx/meson.build
+++ b/drivers/net/octeontx/meson.build
@@ -1,9 +1,9 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Cavium, Inc
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
 	build = false
-	reason = 'not supported on Windows'
+	reason = 'only supported on 64-bit Linux'
 	subdir_done()
 endif
 
diff --git a/drivers/net/octeontx2/meson.build b/drivers/net/octeontx2/meson.build
index e2c139a8b..6f639fa7e 100644
--- a/drivers/net/octeontx2/meson.build
+++ b/drivers/net/octeontx2/meson.build
@@ -2,15 +2,9 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
 	build = false
-	reason = 'not supported on Windows'
-	subdir_done()
-endif
-
-if not dpdk_conf.get('RTE_ARCH_64')
-	build = false
-	reason = 'only supported on 64-bit'
+	reason = 'only supported on 64-bit Linux'
 	subdir_done()
 endif
 
diff --git a/drivers/net/thunderx/meson.build b/drivers/net/thunderx/meson.build
index dad5c5924..97a84d587 100644
--- a/drivers/net/thunderx/meson.build
+++ b/drivers/net/thunderx/meson.build
@@ -1,9 +1,9 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Cavium, Inc
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
 	build = false
-	reason = 'not supported on Windows'
+	reason = 'only supported on 64-bit Linux'
 	subdir_done()
 endif
 
-- 
2.17.1

[dpdk-dev] [PATCH 4/7] crypto/octeontx: enable build only on 64bit Linux

[pbhagavatula]

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Due to Linux kernel dependency, only enable build for 64bit Linux.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
 drivers/crypto/octeontx/meson.build | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/octeontx/meson.build b/drivers/crypto/octeontx/meson.build
index a353d37a1..2e5838641 100644
--- a/drivers/crypto/octeontx/meson.build
+++ b/drivers/crypto/octeontx/meson.build
@@ -1,8 +1,11 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2018 Cavium, Inc
-if not is_linux
+#
+
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
 	build = false
-	reason = 'only supported on Linux'
+	reason = 'only supported on 64-bit Linux'
+	subdir_done()
 endif
 
 deps += ['bus_pci']
-- 
2.17.1

[dpdk-dev] [PATCH 5/7] event/octeontx: enable build only on 64bit Linux

[pbhagavatula]

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Due to Linux kernel dependency, only enable build for 64bit Linux.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
 drivers/event/octeontx/meson.build  | 6 ++++++
 drivers/event/octeontx2/meson.build | 4 ++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/event/octeontx/meson.build b/drivers/event/octeontx/meson.build
index 41e367684..0e3b61044 100644
--- a/drivers/event/octeontx/meson.build
+++ b/drivers/event/octeontx/meson.build
@@ -1,6 +1,12 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Cavium, Inc
 
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
+        build = false
+	reason = 'only supported on 64-bit Linux'
+	subdir_done()
+endif
+
 sources = files('ssovf_worker.c',
 		'ssovf_evdev.c',
 		'ssovf_evdev_selftest.c',
diff --git a/drivers/event/octeontx2/meson.build b/drivers/event/octeontx2/meson.build
index 22e7e4cb6..c81950cef 100644
--- a/drivers/event/octeontx2/meson.build
+++ b/drivers/event/octeontx2/meson.build
@@ -2,9 +2,9 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #
 
-if not dpdk_conf.get('RTE_ARCH_64')
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
 	build = false
-	reason = 'only supported on 64-bit'
+	reason = 'only supported on 64-bit Linux'
 	subdir_done()
 endif
 
-- 
2.17.1

[dpdk-dev] [PATCH 6/7] raw/octeontx2: enable build only for 64bit Linux

[pbhagavatula]

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Due to Linux kernel dependency, only enable build for 64bit Linux.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
 drivers/raw/octeontx2_dma/meson.build | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/raw/octeontx2_dma/meson.build b/drivers/raw/octeontx2_dma/meson.build
index 11f74680a..191035125 100644
--- a/drivers/raw/octeontx2_dma/meson.build
+++ b/drivers/raw/octeontx2_dma/meson.build
@@ -2,14 +2,16 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #
 
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
+	build = false
+	reason = 'only supported on 64-bit Linux'
+	subdir_done()
+endif
+
 deps += ['bus_pci', 'common_octeontx2', 'rawdev']
 sources = files('otx2_dpi_rawdev.c', 'otx2_dpi_msg.c', 'otx2_dpi_test.c')
 
 extra_flags = []
-# This integrated controller runs only on a arm64 machine, remove 32bit warnings
-if not dpdk_conf.get('RTE_ARCH_64')
-	extra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast']
-endif
 
 foreach flag: extra_flags
 	if cc.has_argument(flag)
-- 
2.17.1

Re: [dpdk-dev] [PATCH 6/7] raw/octeontx2: enable build only for 64bit Linux

[Radha Mohan]

On Thu, Feb 25, 2021 at 10:33 PM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Due to Linux kernel dependency, only enable build for 64bit Linux.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
>  drivers/raw/octeontx2_dma/meson.build | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/raw/octeontx2_dma/meson.build b/drivers/raw/octeontx2_dma/meson.build
> index 11f74680a..191035125 100644
> --- a/drivers/raw/octeontx2_dma/meson.build
> +++ b/drivers/raw/octeontx2_dma/meson.build
> @@ -2,14 +2,16 @@
>  # Copyright(C) 2019 Marvell International Ltd.
>  #
>
> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
> +       build = false
> +       reason = 'only supported on 64-bit Linux'
> +       subdir_done()
> +endif
> +
>  deps += ['bus_pci', 'common_octeontx2', 'rawdev']
>  sources = files('otx2_dpi_rawdev.c', 'otx2_dpi_msg.c', 'otx2_dpi_test.c')
>
>  extra_flags = []
> -# This integrated controller runs only on a arm64 machine, remove 32bit warnings
> -if not dpdk_conf.get('RTE_ARCH_64')
> -       extra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast']
> -endif
>
>  foreach flag: extra_flags
>         if cc.has_argument(flag)
> --
> 2.17.1
>
Acked-by: Radha Mohan Chintakuntla <radhac@marvell.com>

[dpdk-dev] [PATCH 7/7] compress/octeontx: enable build only for 64bit Linux

[pbhagavatula]

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Due to Linux kernel dependency, only enable build for 64bit Linux.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
 drivers/compress/octeontx/meson.build | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/compress/octeontx/meson.build b/drivers/compress/octeontx/meson.build
index e1b7bed42..cd8687fde 100644
--- a/drivers/compress/octeontx/meson.build
+++ b/drivers/compress/octeontx/meson.build
@@ -1,6 +1,12 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2018 Cavium, Inc
 
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
+	build = false
+	reason = 'only supported on 64-bit Linux'
+	subdir_done()
+endif
+
 sources = files('otx_zip.c', 'otx_zip_pmd.c')
 includes += include_directories('include')
 deps += ['mempool_octeontx', 'bus_pci']
-- 
2.17.1

Re: [dpdk-dev] [PATCH 7/7] compress/octeontx: enable build only for 64bit Linux

[Ashish Gupta]

> -----Original Message-----
> From: pbhagavatula@marvell.com <pbhagavatula@marvell.com>
> Sent: Thursday, February 25, 2021 10:33 PM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Ashish Gupta
> <ashishg@marvell.com>; Fiona Trahe <fiona.trahe@intel.com>
> Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>
> Subject: [dpdk-dev] [PATCH 7/7] compress/octeontx: enable build only for
> 64bit Linux
> 
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Due to Linux kernel dependency, only enable build for 64bit Linux.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
>  drivers/compress/octeontx/meson.build | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/compress/octeontx/meson.build
> b/drivers/compress/octeontx/meson.build
> index e1b7bed42..cd8687fde 100644
> --- a/drivers/compress/octeontx/meson.build
> +++ b/drivers/compress/octeontx/meson.build
> @@ -1,6 +1,12 @@
>  # SPDX-License-Identifier: BSD-3-Clause  # Copyright(c) 2018 Cavium, Inc
> 
> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
> +	build = false
> +	reason = 'only supported on 64-bit Linux'
> +	subdir_done()
> +endif
> +
>  sources = files('otx_zip.c', 'otx_zip_pmd.c')  includes +=
> include_directories('include')  deps += ['mempool_octeontx', 'bus_pci']
> --
> 2.17.1

Acked-by: Ashish Gupta <ashishg@marvell.com>

Re: [dpdk-dev] [PATCH 1/7] common/octeontx: enable build only on 64bit Linux

[Jerin Jacob]

On Thu, Feb 25, 2021 at 10:33 PM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Due to Linux kernel dependency, only enable build for 64bit Linux.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>


Series Acked-by: Jerin Jacob <jerinj@marvell.com>



> ---
>  drivers/common/octeontx/meson.build  | 6 ++++++
>  drivers/common/octeontx2/meson.build | 4 ++--
>  2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/common/octeontx/meson.build b/drivers/common/octeontx/meson.build
> index 203d1ef49..f29b58320 100644
> --- a/drivers/common/octeontx/meson.build
> +++ b/drivers/common/octeontx/meson.build
> @@ -2,4 +2,10 @@
>  # Copyright(c) 2018 Cavium, Inc
>  #
>
> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
> +       build = false
> +       reason = 'only supported on 64-bit Linux'
> +       subdir_done()
> +endif
> +
>  sources = files('octeontx_mbox.c')
> diff --git a/drivers/common/octeontx2/meson.build b/drivers/common/octeontx2/meson.build
> index 84fb11524..3ae106792 100644
> --- a/drivers/common/octeontx2/meson.build
> +++ b/drivers/common/octeontx2/meson.build
> @@ -2,9 +2,9 @@
>  # Copyright(C) 2019 Marvell International Ltd.
>  #
>
> -if not dpdk_conf.get('RTE_ARCH_64')
> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
>         build = false
> -       reason = 'only supported on 64-bit'
> +       reason = 'only supported on 64-bit Linux'
>         subdir_done()
>  endif
>
> --
> 2.17.1
>

Re: [dpdk-dev] [PATCH 1/7] common/octeontx: enable build only on 64bit Linux

[Thomas Monjalon]

24/03/2021 11:55, Jerin Jacob:
> On Thu, Feb 25, 2021 at 10:33 PM <pbhagavatula@marvell.com> wrote:
> >
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > Due to Linux kernel dependency, only enable build for 64bit Linux.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> 
> Series Acked-by: Jerin Jacob <jerinj@marvell.com>

I've reorganized the commits per family of drivers,
so it makes more sense than grouping per driver class
with "common/octeontx" for title for all:

net/thunderx: enable build only on 64-bit Linux
common/octeontx: enable build only on 64-bit Linux
common/octeontx2: enable build only on 64-bit Linux

and applied.

Re: [dpdk-dev] [PATCH 1/7] common/octeontx: enable build only on 64bit Linux

[Thomas Monjalon]

25/03/2021 11:42, Thomas Monjalon:
> 24/03/2021 11:55, Jerin Jacob:
> > On Thu, Feb 25, 2021 at 10:33 PM <pbhagavatula@marvell.com> wrote:
> > >
> > > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > >
> > > Due to Linux kernel dependency, only enable build for 64bit Linux.
> > >
> > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > 
> > Series Acked-by: Jerin Jacob <jerinj@marvell.com>
> 
> I've reorganized the commits per family of drivers,
> so it makes more sense than grouping per driver class
> with "common/octeontx" for title for all:
> 
> net/thunderx: enable build only on 64-bit Linux
> common/octeontx: enable build only on 64-bit Linux
> common/octeontx2: enable build only on 64-bit Linux
> 
> and applied.

Actually not applied yet.
I'm not sure what to do for the ABI check which is broken
because some drivers are not compiled anymore in 32-bit build.
I've workarounded locally by removing the dump files in the reference build.
Should we add an exception in libabigail.abignore?

Re: [dpdk-dev] [PATCH 1/7] common/octeontx: enable build only on 64bit Linux

[Kinsella, Ray]

On 25/03/2021 10:46, Thomas Monjalon wrote:
> 25/03/2021 11:42, Thomas Monjalon:
>> 24/03/2021 11:55, Jerin Jacob:
>>> On Thu, Feb 25, 2021 at 10:33 PM <pbhagavatula@marvell.com> wrote:
>>>>
>>>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>>
>>>> Due to Linux kernel dependency, only enable build for 64bit Linux.
>>>>
>>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>
>>> Series Acked-by: Jerin Jacob <jerinj@marvell.com>
>>
>> I've reorganized the commits per family of drivers,
>> so it makes more sense than grouping per driver class
>> with "common/octeontx" for title for all:
>>
>> net/thunderx: enable build only on 64-bit Linux
>> common/octeontx: enable build only on 64-bit Linux
>> common/octeontx2: enable build only on 64-bit Linux
>>
>> and applied.
> 
> Actually not applied yet.
> I'm not sure what to do for the ABI check which is broken
> because some drivers are not compiled anymore in 32-bit build.
> I've workarounded locally by removing the dump files in the reference build.
> Should we add an exception in libabigail.abignore?
> 
In the past we said that depreciating HW support would be considered to be same as an ABI Breakage.

From the policy ... 
"Updates to the minimum hardware requirements, which drop support for hardware which was previously supported, should be treated as an ABI change."

Re: [dpdk-dev] [PATCH 1/7] common/octeontx: enable build only on 64bit Linux

[Thomas Monjalon]

25/03/2021 11:58, Kinsella, Ray:
> On 25/03/2021 10:46, Thomas Monjalon wrote:
> > 25/03/2021 11:42, Thomas Monjalon:
> >> 24/03/2021 11:55, Jerin Jacob:
> >>> On Thu, Feb 25, 2021 at 10:33 PM <pbhagavatula@marvell.com> wrote:
> >>>>
> >>>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >>>>
> >>>> Due to Linux kernel dependency, only enable build for 64bit Linux.
> >>>>
> >>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >>>
> >>> Series Acked-by: Jerin Jacob <jerinj@marvell.com>
> >>
> >> I've reorganized the commits per family of drivers,
> >> so it makes more sense than grouping per driver class
> >> with "common/octeontx" for title for all:
> >>
> >> net/thunderx: enable build only on 64-bit Linux
> >> common/octeontx: enable build only on 64-bit Linux
> >> common/octeontx2: enable build only on 64-bit Linux
> >>
> >> and applied.
> > 
> > Actually not applied yet.
> > I'm not sure what to do for the ABI check which is broken
> > because some drivers are not compiled anymore in 32-bit build.
> > I've workarounded locally by removing the dump files in the reference build.
> > Should we add an exception in libabigail.abignore?
> > 
> In the past we said that depreciating HW support would be considered to be same as an ABI Breakage.
> 
> From the policy ... 
> "Updates to the minimum hardware requirements, which drop support for hardware which was previously supported, should be treated as an ABI change."

So the patches should wait 21.11.
Everybody agree?

Re: [dpdk-dev] [PATCH 1/7] common/octeontx: enable build only on 64bit Linux

[Jerin Jacob]

On Thu, Mar 25, 2021 at 4:33 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 25/03/2021 11:58, Kinsella, Ray:
> > On 25/03/2021 10:46, Thomas Monjalon wrote:
> > > 25/03/2021 11:42, Thomas Monjalon:
> > >> 24/03/2021 11:55, Jerin Jacob:
> > >>> On Thu, Feb 25, 2021 at 10:33 PM <pbhagavatula@marvell.com> wrote:
> > >>>>
> > >>>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > >>>>
> > >>>> Due to Linux kernel dependency, only enable build for 64bit Linux.
> > >>>>
> > >>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > >>>
> > >>> Series Acked-by: Jerin Jacob <jerinj@marvell.com>
> > >>
> > >> I've reorganized the commits per family of drivers,
> > >> so it makes more sense than grouping per driver class
> > >> with "common/octeontx" for title for all:
> > >>
> > >> net/thunderx: enable build only on 64-bit Linux
> > >> common/octeontx: enable build only on 64-bit Linux
> > >> common/octeontx2: enable build only on 64-bit Linux
> > >>
> > >> and applied.
> > >
> > > Actually not applied yet.
> > > I'm not sure what to do for the ABI check which is broken
> > > because some drivers are not compiled anymore in 32-bit build.
> > > I've workarounded locally by removing the dump files in the reference build.
> > > Should we add an exception in libabigail.abignore?
> > >
> > In the past we said that depreciating HW support would be considered to be same as an ABI Breakage.
> >
> > From the policy ...
> > "Updates to the minimum hardware requirements, which drop support for hardware which was previously supported, should be treated as an ABI change."
>
> So the patches should wait 21.11.
> Everybody agree?

Looks good to me to postpone.

@Ray Kinsella @Thomas Monjalon  @McDaniel, Timothy @David Marchand @Neil Horman

Currently, I merged DLB v1 driver removal patch to next-eventdev. Is
this ABI breakge[1]?

http://patches.dpdk.org/project/dpdk/patch/20210316210812.15614-1-timothy.mcdaniel@intel.com/

[1]
From the policy ...
"Updates to the minimum hardware requirements, which drop support for
hardware which was previously supported, should be treated as an ABI
change."

Re: [dpdk-dev] [PATCH 1/7] common/octeontx: enable build only on 64bit Linux

[Kinsella, Ray]

On 25/03/2021 12:46, Jerin Jacob wrote:
> On Thu, Mar 25, 2021 at 4:33 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>>
>> 25/03/2021 11:58, Kinsella, Ray:
>>> On 25/03/2021 10:46, Thomas Monjalon wrote:
>>>> 25/03/2021 11:42, Thomas Monjalon:
>>>>> 24/03/2021 11:55, Jerin Jacob:
>>>>>> On Thu, Feb 25, 2021 at 10:33 PM <pbhagavatula@marvell.com> wrote:
>>>>>>>
>>>>>>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>>>>>
>>>>>>> Due to Linux kernel dependency, only enable build for 64bit Linux.
>>>>>>>
>>>>>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>>>>
>>>>>> Series Acked-by: Jerin Jacob <jerinj@marvell.com>
>>>>>
>>>>> I've reorganized the commits per family of drivers,
>>>>> so it makes more sense than grouping per driver class
>>>>> with "common/octeontx" for title for all:
>>>>>
>>>>> net/thunderx: enable build only on 64-bit Linux
>>>>> common/octeontx: enable build only on 64-bit Linux
>>>>> common/octeontx2: enable build only on 64-bit Linux
>>>>>
>>>>> and applied.
>>>>
>>>> Actually not applied yet.
>>>> I'm not sure what to do for the ABI check which is broken
>>>> because some drivers are not compiled anymore in 32-bit build.
>>>> I've workarounded locally by removing the dump files in the reference build.
>>>> Should we add an exception in libabigail.abignore?
>>>>
>>> In the past we said that depreciating HW support would be considered to be same as an ABI Breakage.
>>>
>>> From the policy ...
>>> "Updates to the minimum hardware requirements, which drop support for hardware which was previously supported, should be treated as an ABI change."
>>
>> So the patches should wait 21.11.
>> Everybody agree?
> 
> Looks good to me to postpone.
> 
> @Ray Kinsella @Thomas Monjalon  @McDaniel, Timothy @David Marchand @Neil Horman
> 
> Currently, I merged DLB v1 driver removal patch to next-eventdev. Is
> this ABI breakge[1]?
> 
> http://patches.dpdk.org/project/dpdk/patch/20210316210812.15614-1-timothy.mcdaniel@intel.com/
> 
> [1]
> From the policy ...
> "Updates to the minimum hardware requirements, which drop support for
> hardware which was previously supported, should be treated as an ABI
> change."

+1 

Re: [dpdk-dev] [PATCH 1/7] common/octeontx: enable build only on 64bit Linux

[Jerin Jacob]

On Thu, Mar 25, 2021 at 6:17 PM Kinsella, Ray <mdr@ashroe.eu> wrote:
>
>
>
> On 25/03/2021 12:46, Jerin Jacob wrote:
> > On Thu, Mar 25, 2021 at 4:33 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> >>
> >> 25/03/2021 11:58, Kinsella, Ray:
> >>> On 25/03/2021 10:46, Thomas Monjalon wrote:
> >>>> 25/03/2021 11:42, Thomas Monjalon:
> >>>>> 24/03/2021 11:55, Jerin Jacob:
> >>>>>> On Thu, Feb 25, 2021 at 10:33 PM <pbhagavatula@marvell.com> wrote:
> >>>>>>>
> >>>>>>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >>>>>>>
> >>>>>>> Due to Linux kernel dependency, only enable build for 64bit Linux.
> >>>>>>>
> >>>>>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >>>>>>
> >>>>>> Series Acked-by: Jerin Jacob <jerinj@marvell.com>
> >>>>>
> >>>>> I've reorganized the commits per family of drivers,
> >>>>> so it makes more sense than grouping per driver class
> >>>>> with "common/octeontx" for title for all:
> >>>>>
> >>>>> net/thunderx: enable build only on 64-bit Linux
> >>>>> common/octeontx: enable build only on 64-bit Linux
> >>>>> common/octeontx2: enable build only on 64-bit Linux
> >>>>>
> >>>>> and applied.
> >>>>
> >>>> Actually not applied yet.
> >>>> I'm not sure what to do for the ABI check which is broken
> >>>> because some drivers are not compiled anymore in 32-bit build.
> >>>> I've workarounded locally by removing the dump files in the reference build.
> >>>> Should we add an exception in libabigail.abignore?
> >>>>
> >>> In the past we said that depreciating HW support would be considered to be same as an ABI Breakage.
> >>>
> >>> From the policy ...
> >>> "Updates to the minimum hardware requirements, which drop support for hardware which was previously supported, should be treated as an ABI change."
> >>
> >> So the patches should wait 21.11.
> >> Everybody agree?
> >
> > Looks good to me to postpone.
> >
> > @Ray Kinsella @Thomas Monjalon  @McDaniel, Timothy @David Marchand @Neil Horman
> >
> > Currently, I merged DLB v1 driver removal patch to next-eventdev. Is
> > this ABI breakge[1]?
> >
> > http://patches.dpdk.org/project/dpdk/patch/20210316210812.15614-1-timothy.mcdaniel@intel.com/
> >
> > [1]
> > From the policy ...
> > "Updates to the minimum hardware requirements, which drop support for
> > hardware which was previously supported, should be treated as an ABI
> > change."
>
> +1

Is +1 for not to remove the dlb driver or remove it?

Re: [dpdk-dev] [PATCH 1/7] common/octeontx: enable build only on 64bit Linux

[Kinsella, Ray]

On 25/03/2021 12:58, Jerin Jacob wrote:
> On Thu, Mar 25, 2021 at 6:17 PM Kinsella, Ray <mdr@ashroe.eu> wrote:
>>
>>
>>
>> On 25/03/2021 12:46, Jerin Jacob wrote:
>>> On Thu, Mar 25, 2021 at 4:33 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>>>>
>>>> 25/03/2021 11:58, Kinsella, Ray:
>>>>> On 25/03/2021 10:46, Thomas Monjalon wrote:
>>>>>> 25/03/2021 11:42, Thomas Monjalon:
>>>>>>> 24/03/2021 11:55, Jerin Jacob:
>>>>>>>> On Thu, Feb 25, 2021 at 10:33 PM <pbhagavatula@marvell.com> wrote:
>>>>>>>>>
>>>>>>>>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>>>>>>>
>>>>>>>>> Due to Linux kernel dependency, only enable build for 64bit Linux.
>>>>>>>>>
>>>>>>>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>>>>>>
>>>>>>>> Series Acked-by: Jerin Jacob <jerinj@marvell.com>
>>>>>>>
>>>>>>> I've reorganized the commits per family of drivers,
>>>>>>> so it makes more sense than grouping per driver class
>>>>>>> with "common/octeontx" for title for all:
>>>>>>>
>>>>>>> net/thunderx: enable build only on 64-bit Linux
>>>>>>> common/octeontx: enable build only on 64-bit Linux
>>>>>>> common/octeontx2: enable build only on 64-bit Linux
>>>>>>>
>>>>>>> and applied.
>>>>>>
>>>>>> Actually not applied yet.
>>>>>> I'm not sure what to do for the ABI check which is broken
>>>>>> because some drivers are not compiled anymore in 32-bit build.
>>>>>> I've workarounded locally by removing the dump files in the reference build.
>>>>>> Should we add an exception in libabigail.abignore?
>>>>>>
>>>>> In the past we said that depreciating HW support would be considered to be same as an ABI Breakage.
>>>>>
>>>>> From the policy ...
>>>>> "Updates to the minimum hardware requirements, which drop support for hardware which was previously supported, should be treated as an ABI change."
>>>>
>>>> So the patches should wait 21.11.
>>>> Everybody agree?
>>>
>>> Looks good to me to postpone.
>>>
>>> @Ray Kinsella @Thomas Monjalon  @McDaniel, Timothy @David Marchand @Neil Horman
>>>
>>> Currently, I merged DLB v1 driver removal patch to next-eventdev. Is
>>> this ABI breakge[1]?
>>>
>>> http://patches.dpdk.org/project/dpdk/patch/20210316210812.15614-1-timothy.mcdaniel@intel.com/
>>>
>>> [1]
>>> From the policy ...
>>> "Updates to the minimum hardware requirements, which drop support for
>>> hardware which was previously supported, should be treated as an ABI
>>> change."
>>
>> +1
> 
> Is +1 for not to remove the dlb driver or remove it?
> 

You'll note the original reply pointing at the ABI Policy was from myself.
So I would be in favor of retention until 21.11. 

Thats said...

We should think about making the rules less strict for 32bit in future, from 21.11 onwards perhaps.
How many OS Vendors are shipping 32bit OSs these days for example?

Re: [dpdk-dev] [PATCH 1/7] common/octeontx: enable build only on 64bit Linux

[Jerin Jacob]

On Thu, Mar 25, 2021 at 6:32 PM Kinsella, Ray <mdr@ashroe.eu> wrote:
>
>
>
> On 25/03/2021 12:58, Jerin Jacob wrote:
> > On Thu, Mar 25, 2021 at 6:17 PM Kinsella, Ray <mdr@ashroe.eu> wrote:
> >>
> >>
> >>
> >> On 25/03/2021 12:46, Jerin Jacob wrote:
> >>> On Thu, Mar 25, 2021 at 4:33 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> >>>>
> >>>> 25/03/2021 11:58, Kinsella, Ray:
> >>>>> On 25/03/2021 10:46, Thomas Monjalon wrote:
> >>>>>> 25/03/2021 11:42, Thomas Monjalon:
> >>>>>>> 24/03/2021 11:55, Jerin Jacob:
> >>>>>>>> On Thu, Feb 25, 2021 at 10:33 PM <pbhagavatula@marvell.com> wrote:
> >>>>>>>>>
> >>>>>>>>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >>>>>>>>>
> >>>>>>>>> Due to Linux kernel dependency, only enable build for 64bit Linux.
> >>>>>>>>>
> >>>>>>>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >>>>>>>>
> >>>>>>>> Series Acked-by: Jerin Jacob <jerinj@marvell.com>
> >>>>>>>
> >>>>>>> I've reorganized the commits per family of drivers,
> >>>>>>> so it makes more sense than grouping per driver class
> >>>>>>> with "common/octeontx" for title for all:
> >>>>>>>
> >>>>>>> net/thunderx: enable build only on 64-bit Linux
> >>>>>>> common/octeontx: enable build only on 64-bit Linux
> >>>>>>> common/octeontx2: enable build only on 64-bit Linux
> >>>>>>>
> >>>>>>> and applied.
> >>>>>>
> >>>>>> Actually not applied yet.
> >>>>>> I'm not sure what to do for the ABI check which is broken
> >>>>>> because some drivers are not compiled anymore in 32-bit build.
> >>>>>> I've workarounded locally by removing the dump files in the reference build.
> >>>>>> Should we add an exception in libabigail.abignore?
> >>>>>>
> >>>>> In the past we said that depreciating HW support would be considered to be same as an ABI Breakage.
> >>>>>
> >>>>> From the policy ...
> >>>>> "Updates to the minimum hardware requirements, which drop support for hardware which was previously supported, should be treated as an ABI change."
> >>>>
> >>>> So the patches should wait 21.11.
> >>>> Everybody agree?
> >>>
> >>> Looks good to me to postpone.
> >>>
> >>> @Ray Kinsella @Thomas Monjalon  @McDaniel, Timothy @David Marchand @Neil Horman
> >>>
> >>> Currently, I merged DLB v1 driver removal patch to next-eventdev. Is
> >>> this ABI breakge[1]?
> >>>
> >>> http://patches.dpdk.org/project/dpdk/patch/20210316210812.15614-1-timothy.mcdaniel@intel.com/
> >>>
> >>> [1]
> >>> From the policy ...
> >>> "Updates to the minimum hardware requirements, which drop support for
> >>> hardware which was previously supported, should be treated as an ABI
> >>> change."
> >>
> >> +1
> >
> > Is +1 for not to remove the dlb driver or remove it?
> >
>
> You'll note the original reply pointing at the ABI Policy was from myself.
> So I would be in favor of retention until 21.11.
>
> Thats said...
>
> We should think about making the rules less strict for 32bit in future, from 21.11 onwards perhaps.
> How many OS Vendors are shipping 32bit OSs these days for example?

Agree on 32bit.

The DLB driver removal patch from @McDaniel, Timothy
http://patches.dpdk.org/project/dpdk/patch/20210316210812.15614-1-timothy.mcdaniel@intel.com/
is deleting the complete driver. So it does not look like it is
updating the minimum HW requirements
as mentioned in the policy.

So IMO, it is OK to accept his patch for 21.05(ie. remove the driver).
Let me know if there is any objection on this?

Re: [dpdk-dev] [PATCH 1/7] common/octeontx: enable build only on 64bit Linux

[Thomas Monjalon]

25/03/2021 13:46, Jerin Jacob:
> On Thu, Mar 25, 2021 at 4:33 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > 25/03/2021 11:58, Kinsella, Ray:
> > > On 25/03/2021 10:46, Thomas Monjalon wrote:
> > > > 25/03/2021 11:42, Thomas Monjalon:
> > > >> I've reorganized the commits per family of drivers,
> > > >> so it makes more sense than grouping per driver class
> > > >> with "common/octeontx" for title for all:
> > > >>
> > > >> net/thunderx: enable build only on 64-bit Linux
> > > >> common/octeontx: enable build only on 64-bit Linux
> > > >> common/octeontx2: enable build only on 64-bit Linux
> > > >>
> > > >> and applied.
> > > >
> > > > Actually not applied yet.
> > > > I'm not sure what to do for the ABI check which is broken
> > > > because some drivers are not compiled anymore in 32-bit build.
> > > > I've workarounded locally by removing the dump files in the reference build.
> > > > Should we add an exception in libabigail.abignore?
> > > >
> > > In the past we said that depreciating HW support would be considered to be same as an ABI Breakage.
> > >
> > > From the policy ...
> > > "Updates to the minimum hardware requirements, which drop support for hardware which was previously supported, should be treated as an ABI change."
> >
> > So the patches should wait 21.11.
> > Everybody agree?
> 
> Looks good to me to postpone.

The v2 is waiting in patchwork with the status "Deferred":
https://patches.dpdk.org/project/dpdk/list/?series=15885&state=*

Re: [dpdk-dev] [PATCH 1/7] common/octeontx: enable build only on 64bit Linux

[David Marchand]

On Thu, Mar 25, 2021 at 3:57 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > > In the past we said that depreciating HW support would be considered to be same as an ABI Breakage.
> > > >
> > > > From the policy ...
> > > > "Updates to the minimum hardware requirements, which drop support for hardware which was previously supported, should be treated as an ABI change."
> > >
> > > So the patches should wait 21.11.
> > > Everybody agree?
> >
> > Looks good to me to postpone.
>
> The v2 is waiting in patchwork with the status "Deferred":
> https://patches.dpdk.org/project/dpdk/list/?series=15885&state=*

We need a deprecation notice.


-- 
David Marchand

[dpdk-dev] [PATCH 21.11 v2 0/3] octeontx build only on 64-bit Linux

[Thomas Monjalon]

This is a reorg of the patches from Pavan.
It has been discussed that it should wait for DPDK 21.11
for ABI compatibility reason.

Pavan Nikhilesh (3):
  net/thunderx: enable build only on 64-bit Linux
  common/octeontx: enable build only on 64-bit Linux
  common/octeontx2: enable build only on 64-bit Linux

 drivers/common/octeontx/meson.build   |  6 ++++++
 drivers/common/octeontx2/meson.build  |  4 ++--
 drivers/compress/octeontx/meson.build |  6 ++++++
 drivers/crypto/octeontx/meson.build   |  7 +++++--
 drivers/event/octeontx/meson.build    |  6 ++++++
 drivers/event/octeontx2/meson.build   |  4 ++--
 drivers/mempool/octeontx/meson.build  |  5 +++--
 drivers/mempool/octeontx2/meson.build |  9 ++-------
 drivers/net/octeontx/meson.build      |  4 ++--
 drivers/net/octeontx2/meson.build     | 10 ++--------
 drivers/net/thunderx/meson.build      |  4 ++--
 drivers/raw/octeontx2_dma/meson.build | 10 ++++++----
 12 files changed, 44 insertions(+), 31 deletions(-)

-- 
2.30.1

[dpdk-dev] [PATCH 21.11 v2 1/3] net/thunderx: enable build only on 64-bit Linux

[Thomas Monjalon]

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Due to Linux kernel dependency, only enable build for 64-bit Linux.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---
 drivers/net/thunderx/meson.build | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/thunderx/meson.build b/drivers/net/thunderx/meson.build
index dad5c59242..97a84d5875 100644
--- a/drivers/net/thunderx/meson.build
+++ b/drivers/net/thunderx/meson.build
@@ -1,9 +1,9 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Cavium, Inc
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
 	build = false
-	reason = 'not supported on Windows'
+	reason = 'only supported on 64-bit Linux'
 	subdir_done()
 endif
 
-- 
2.30.1

[dpdk-dev] [PATCH v3 1/3] net/thunderx: enable build only on 64-bit Linux

[pbhagavatula]

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Due to Linux kernel dependency, only enable build for 64-bit Linux.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---
 drivers/net/thunderx/meson.build | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/thunderx/meson.build b/drivers/net/thunderx/meson.build
index 4bbcea7f93..da665bd76f 100644
--- a/drivers/net/thunderx/meson.build
+++ b/drivers/net/thunderx/meson.build
@@ -1,9 +1,9 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Cavium, Inc
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif
 
-- 
2.17.1

[dpdk-dev] [PATCH v3 2/3] common/octeontx: enable build only on 64-bit Linux

[pbhagavatula]

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Due to Linux kernel dependency, only enable build for 64-bit Linux.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---
 drivers/common/octeontx/meson.build   | 4 ++--
 drivers/compress/octeontx/meson.build | 6 ++++++
 drivers/crypto/octeontx/meson.build   | 7 +++++++
 drivers/event/octeontx/meson.build    | 6 ++++++
 drivers/mempool/octeontx/meson.build  | 5 +++--
 drivers/net/octeontx/meson.build      | 4 ++--
 6 files changed, 26 insertions(+), 6 deletions(-)

diff --git a/drivers/common/octeontx/meson.build b/drivers/common/octeontx/meson.build
index fcda0f6445..dc060dfea1 100644
--- a/drivers/common/octeontx/meson.build
+++ b/drivers/common/octeontx/meson.build
@@ -2,9 +2,9 @@
 # Copyright(c) 2018 Cavium, Inc
 #
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif
 
diff --git a/drivers/compress/octeontx/meson.build b/drivers/compress/octeontx/meson.build
index e1b7bed422..cd8687fde3 100644
--- a/drivers/compress/octeontx/meson.build
+++ b/drivers/compress/octeontx/meson.build
@@ -1,6 +1,12 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2018 Cavium, Inc
 
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
+	build = false
+	reason = 'only supported on 64-bit Linux'
+	subdir_done()
+endif
+
 sources = files('otx_zip.c', 'otx_zip_pmd.c')
 includes += include_directories('include')
 deps += ['mempool_octeontx', 'bus_pci']
diff --git a/drivers/crypto/octeontx/meson.build b/drivers/crypto/octeontx/meson.build
index 244b16230e..bc6187e1cf 100644
--- a/drivers/crypto/octeontx/meson.build
+++ b/drivers/crypto/octeontx/meson.build
@@ -1,5 +1,12 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2018 Cavium, Inc
+#
+
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
+    build = false
+    reason = 'only supported on 64-bit Linux'
+    subdir_done()
+endif
 
 deps += ['bus_pci']
 deps += ['bus_vdev']
diff --git a/drivers/event/octeontx/meson.build b/drivers/event/octeontx/meson.build
index 0d9eec3f2e..eb17e059d8 100644
--- a/drivers/event/octeontx/meson.build
+++ b/drivers/event/octeontx/meson.build
@@ -1,6 +1,12 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Cavium, Inc
 
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
+    build = false
+    reason = 'only supported on 64-bit Linux'
+    subdir_done()
+endif
+
 sources = files(
         'ssovf_worker.c',
         'ssovf_evdev.c',
diff --git a/drivers/mempool/octeontx/meson.build b/drivers/mempool/octeontx/meson.build
index a57213e2d8..fb05928129 100644
--- a/drivers/mempool/octeontx/meson.build
+++ b/drivers/mempool/octeontx/meson.build
@@ -1,9 +1,10 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Cavium, Inc
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
+    reason = 'only supported on 64-bit Linux'
+    subdir_done()
 endif
 
 sources = files(
diff --git a/drivers/net/octeontx/meson.build b/drivers/net/octeontx/meson.build
index 84cd4e1142..a5a6c9661c 100644
--- a/drivers/net/octeontx/meson.build
+++ b/drivers/net/octeontx/meson.build
@@ -1,9 +1,9 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Cavium, Inc
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif
 
-- 
2.17.1

[dpdk-dev] [PATCH v3 3/3] common/octeontx2: enable build only on 64-bit Linux

[pbhagavatula]

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Due to Linux kernel dependency, only enable build for 64-bit Linux.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---
 drivers/common/octeontx2/meson.build  | 10 ++--------
 drivers/event/octeontx2/meson.build   |  4 ++--
 drivers/mempool/octeontx2/meson.build |  9 ++-------
 drivers/net/octeontx2/meson.build     | 10 ++--------
 drivers/raw/octeontx2_dma/meson.build | 10 ++++++----
 5 files changed, 14 insertions(+), 29 deletions(-)

diff --git a/drivers/common/octeontx2/meson.build b/drivers/common/octeontx2/meson.build
index dcfaa1e102..223ba5ef51 100644
--- a/drivers/common/octeontx2/meson.build
+++ b/drivers/common/octeontx2/meson.build
@@ -2,15 +2,9 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
-    subdir_done()
-endif
-
-if not dpdk_conf.get('RTE_ARCH_64')
-    build = false
-    reason = 'only supported on 64-bit'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif
 
diff --git a/drivers/event/octeontx2/meson.build b/drivers/event/octeontx2/meson.build
index 96ebb1f2e7..ce360af5f8 100644
--- a/drivers/event/octeontx2/meson.build
+++ b/drivers/event/octeontx2/meson.build
@@ -2,9 +2,9 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #
 
-if not dpdk_conf.get('RTE_ARCH_64')
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'only supported on 64-bit'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif
 
diff --git a/drivers/mempool/octeontx2/meson.build b/drivers/mempool/octeontx2/meson.build
index 2a1dfddd4c..a4bea6d364 100644
--- a/drivers/mempool/octeontx2/meson.build
+++ b/drivers/mempool/octeontx2/meson.build
@@ -2,14 +2,9 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
-    subdir_done()
-endif
-if not dpdk_conf.get('RTE_ARCH_64')
-    build = false
-    reason = 'only supported on 64-bit'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif
 
diff --git a/drivers/net/octeontx2/meson.build b/drivers/net/octeontx2/meson.build
index a355313120..ab15844cbc 100644
--- a/drivers/net/octeontx2/meson.build
+++ b/drivers/net/octeontx2/meson.build
@@ -2,15 +2,9 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
-    subdir_done()
-endif
-
-if not dpdk_conf.get('RTE_ARCH_64')
-    build = false
-    reason = 'only supported on 64-bit'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif
 
diff --git a/drivers/raw/octeontx2_dma/meson.build b/drivers/raw/octeontx2_dma/meson.build
index e744fccaae..6460bd8242 100644
--- a/drivers/raw/octeontx2_dma/meson.build
+++ b/drivers/raw/octeontx2_dma/meson.build
@@ -2,14 +2,16 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #
 
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
+    build = false
+    reason = 'only supported on 64-bit Linux'
+    subdir_done()
+endif
+
 deps += ['bus_pci', 'common_octeontx2', 'rawdev']
 sources = files('otx2_dpi_rawdev.c', 'otx2_dpi_msg.c', 'otx2_dpi_test.c')
 
 extra_flags = []
-# This integrated controller runs only on a arm64 machine, remove 32bit warnings
-if not dpdk_conf.get('RTE_ARCH_64')
-    extra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast']
-endif
 
 foreach flag: extra_flags
     if cc.has_argument(flag)
-- 
2.17.1

Re: [dpdk-dev] [PATCH v3 1/3] net/thunderx: enable build only on 64-bit Linux

[Ferruh Yigit]

On 8/23/2021 8:54 PM, pbhagavatula@marvell.com wrote:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Due to Linux kernel dependency, only enable build for 64-bit Linux.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> Acked-by: Jerin Jacob <jerinj@marvell.com>

patches looks good, but can you please add more details related to the
dependency in the commit log?

[dpdk-dev] [PATCH v4 1/3] net/thunderx: enable build only on 64-bit Linux

[pbhagavatula]

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Due to Linux kernel AF(Admin fuction) driver dependency, only enable
build for 64-bit Linux.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---
 v4 Changes:
 - Update commit message regarding dependency on AF driver.

 drivers/net/thunderx/meson.build | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/thunderx/meson.build b/drivers/net/thunderx/meson.build
index 4bbcea7f93..da665bd76f 100644
--- a/drivers/net/thunderx/meson.build
+++ b/drivers/net/thunderx/meson.build
@@ -1,9 +1,9 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Cavium, Inc

-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif

--
2.17.1

[dpdk-dev] [PATCH v4 2/3] common/octeontx: enable build only on 64-bit Linux

[pbhagavatula]

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Due to Linux kernel AF(Admin fuction) driver dependency, only enable
build for 64-bit Linux.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---
 drivers/common/octeontx/meson.build   | 4 ++--
 drivers/compress/octeontx/meson.build | 6 ++++++
 drivers/crypto/octeontx/meson.build   | 7 +++++++
 drivers/event/octeontx/meson.build    | 6 ++++++
 drivers/mempool/octeontx/meson.build  | 5 +++--
 drivers/net/octeontx/meson.build      | 4 ++--
 6 files changed, 26 insertions(+), 6 deletions(-)

diff --git a/drivers/common/octeontx/meson.build b/drivers/common/octeontx/meson.build
index fcda0f6445..dc060dfea1 100644
--- a/drivers/common/octeontx/meson.build
+++ b/drivers/common/octeontx/meson.build
@@ -2,9 +2,9 @@
 # Copyright(c) 2018 Cavium, Inc
 #
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif
 
diff --git a/drivers/compress/octeontx/meson.build b/drivers/compress/octeontx/meson.build
index e1b7bed422..cd8687fde3 100644
--- a/drivers/compress/octeontx/meson.build
+++ b/drivers/compress/octeontx/meson.build
@@ -1,6 +1,12 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2018 Cavium, Inc
 
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
+	build = false
+	reason = 'only supported on 64-bit Linux'
+	subdir_done()
+endif
+
 sources = files('otx_zip.c', 'otx_zip_pmd.c')
 includes += include_directories('include')
 deps += ['mempool_octeontx', 'bus_pci']
diff --git a/drivers/crypto/octeontx/meson.build b/drivers/crypto/octeontx/meson.build
index 244b16230e..bc6187e1cf 100644
--- a/drivers/crypto/octeontx/meson.build
+++ b/drivers/crypto/octeontx/meson.build
@@ -1,5 +1,12 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2018 Cavium, Inc
+#
+
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
+    build = false
+    reason = 'only supported on 64-bit Linux'
+    subdir_done()
+endif
 
 deps += ['bus_pci']
 deps += ['bus_vdev']
diff --git a/drivers/event/octeontx/meson.build b/drivers/event/octeontx/meson.build
index 0d9eec3f2e..eb17e059d8 100644
--- a/drivers/event/octeontx/meson.build
+++ b/drivers/event/octeontx/meson.build
@@ -1,6 +1,12 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Cavium, Inc
 
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
+    build = false
+    reason = 'only supported on 64-bit Linux'
+    subdir_done()
+endif
+
 sources = files(
         'ssovf_worker.c',
         'ssovf_evdev.c',
diff --git a/drivers/mempool/octeontx/meson.build b/drivers/mempool/octeontx/meson.build
index a57213e2d8..fb05928129 100644
--- a/drivers/mempool/octeontx/meson.build
+++ b/drivers/mempool/octeontx/meson.build
@@ -1,9 +1,10 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Cavium, Inc
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
+    reason = 'only supported on 64-bit Linux'
+    subdir_done()
 endif
 
 sources = files(
diff --git a/drivers/net/octeontx/meson.build b/drivers/net/octeontx/meson.build
index 84cd4e1142..a5a6c9661c 100644
--- a/drivers/net/octeontx/meson.build
+++ b/drivers/net/octeontx/meson.build
@@ -1,9 +1,9 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Cavium, Inc
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif
 
-- 
2.17.1

[dpdk-dev] [PATCH v4 3/3] common/octeontx2: enable build only on 64-bit Linux

[pbhagavatula]

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Due to Linux kernel AF(Admin Fuction) driver dependency, only enable
build for 64-bit Linux.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---
 drivers/common/octeontx2/meson.build  | 10 ++--------
 drivers/event/octeontx2/meson.build   |  4 ++--
 drivers/mempool/octeontx2/meson.build |  9 ++-------
 drivers/net/octeontx2/meson.build     | 10 ++--------
 drivers/raw/octeontx2_dma/meson.build | 10 ++++++----
 5 files changed, 14 insertions(+), 29 deletions(-)

diff --git a/drivers/common/octeontx2/meson.build b/drivers/common/octeontx2/meson.build
index dcfaa1e102..223ba5ef51 100644
--- a/drivers/common/octeontx2/meson.build
+++ b/drivers/common/octeontx2/meson.build
@@ -2,15 +2,9 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
-    subdir_done()
-endif
-
-if not dpdk_conf.get('RTE_ARCH_64')
-    build = false
-    reason = 'only supported on 64-bit'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif
 
diff --git a/drivers/event/octeontx2/meson.build b/drivers/event/octeontx2/meson.build
index 96ebb1f2e7..ce360af5f8 100644
--- a/drivers/event/octeontx2/meson.build
+++ b/drivers/event/octeontx2/meson.build
@@ -2,9 +2,9 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #
 
-if not dpdk_conf.get('RTE_ARCH_64')
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'only supported on 64-bit'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif
 
diff --git a/drivers/mempool/octeontx2/meson.build b/drivers/mempool/octeontx2/meson.build
index 2a1dfddd4c..a4bea6d364 100644
--- a/drivers/mempool/octeontx2/meson.build
+++ b/drivers/mempool/octeontx2/meson.build
@@ -2,14 +2,9 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
-    subdir_done()
-endif
-if not dpdk_conf.get('RTE_ARCH_64')
-    build = false
-    reason = 'only supported on 64-bit'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif
 
diff --git a/drivers/net/octeontx2/meson.build b/drivers/net/octeontx2/meson.build
index a355313120..ab15844cbc 100644
--- a/drivers/net/octeontx2/meson.build
+++ b/drivers/net/octeontx2/meson.build
@@ -2,15 +2,9 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
-    subdir_done()
-endif
-
-if not dpdk_conf.get('RTE_ARCH_64')
-    build = false
-    reason = 'only supported on 64-bit'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif
 
diff --git a/drivers/raw/octeontx2_dma/meson.build b/drivers/raw/octeontx2_dma/meson.build
index e744fccaae..6460bd8242 100644
--- a/drivers/raw/octeontx2_dma/meson.build
+++ b/drivers/raw/octeontx2_dma/meson.build
@@ -2,14 +2,16 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #
 
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
+    build = false
+    reason = 'only supported on 64-bit Linux'
+    subdir_done()
+endif
+
 deps += ['bus_pci', 'common_octeontx2', 'rawdev']
 sources = files('otx2_dpi_rawdev.c', 'otx2_dpi_msg.c', 'otx2_dpi_test.c')
 
 extra_flags = []
-# This integrated controller runs only on a arm64 machine, remove 32bit warnings
-if not dpdk_conf.get('RTE_ARCH_64')
-    extra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast']
-endif
 
 foreach flag: extra_flags
     if cc.has_argument(flag)
-- 
2.17.1

[dpdk-dev] [PATCH v5 1/3] net/thunderx: enable build only on 64-bit Linux

[pbhagavatula]

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Due to Linux kernel AF(Admin function) driver dependency, only enable
build for 64-bit Linux.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---
 v5 Changes
 - s/fuction/function.

 v4 Changes:
 - Update commit message regarding dependency on AF driver.

 drivers/net/thunderx/meson.build | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/thunderx/meson.build b/drivers/net/thunderx/meson.build
index 4bbcea7f93..da665bd76f 100644
--- a/drivers/net/thunderx/meson.build
+++ b/drivers/net/thunderx/meson.build
@@ -1,9 +1,9 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Cavium, Inc

-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif

--
2.17.1

[dpdk-dev] [PATCH v5 2/3] common/octeontx: enable build only on 64-bit Linux

[pbhagavatula]

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Due to Linux kernel AF(Admin function) driver dependency, only enable
build for 64-bit Linux.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---
 drivers/common/octeontx/meson.build   | 4 ++--
 drivers/compress/octeontx/meson.build | 6 ++++++
 drivers/crypto/octeontx/meson.build   | 7 +++++++
 drivers/event/octeontx/meson.build    | 6 ++++++
 drivers/mempool/octeontx/meson.build  | 5 +++--
 drivers/net/octeontx/meson.build      | 4 ++--
 6 files changed, 26 insertions(+), 6 deletions(-)

diff --git a/drivers/common/octeontx/meson.build b/drivers/common/octeontx/meson.build
index fcda0f6445..dc060dfea1 100644
--- a/drivers/common/octeontx/meson.build
+++ b/drivers/common/octeontx/meson.build
@@ -2,9 +2,9 @@
 # Copyright(c) 2018 Cavium, Inc
 #

-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif

diff --git a/drivers/compress/octeontx/meson.build b/drivers/compress/octeontx/meson.build
index e1b7bed422..cd8687fde3 100644
--- a/drivers/compress/octeontx/meson.build
+++ b/drivers/compress/octeontx/meson.build
@@ -1,6 +1,12 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2018 Cavium, Inc

+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
+	build = false
+	reason = 'only supported on 64-bit Linux'
+	subdir_done()
+endif
+
 sources = files('otx_zip.c', 'otx_zip_pmd.c')
 includes += include_directories('include')
 deps += ['mempool_octeontx', 'bus_pci']
diff --git a/drivers/crypto/octeontx/meson.build b/drivers/crypto/octeontx/meson.build
index 244b16230e..bc6187e1cf 100644
--- a/drivers/crypto/octeontx/meson.build
+++ b/drivers/crypto/octeontx/meson.build
@@ -1,5 +1,12 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2018 Cavium, Inc
+#
+
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
+    build = false
+    reason = 'only supported on 64-bit Linux'
+    subdir_done()
+endif

 deps += ['bus_pci']
 deps += ['bus_vdev']
diff --git a/drivers/event/octeontx/meson.build b/drivers/event/octeontx/meson.build
index 0d9eec3f2e..eb17e059d8 100644
--- a/drivers/event/octeontx/meson.build
+++ b/drivers/event/octeontx/meson.build
@@ -1,6 +1,12 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Cavium, Inc

+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
+    build = false
+    reason = 'only supported on 64-bit Linux'
+    subdir_done()
+endif
+
 sources = files(
         'ssovf_worker.c',
         'ssovf_evdev.c',
diff --git a/drivers/mempool/octeontx/meson.build b/drivers/mempool/octeontx/meson.build
index a57213e2d8..fb05928129 100644
--- a/drivers/mempool/octeontx/meson.build
+++ b/drivers/mempool/octeontx/meson.build
@@ -1,9 +1,10 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Cavium, Inc

-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
+    reason = 'only supported on 64-bit Linux'
+    subdir_done()
 endif

 sources = files(
diff --git a/drivers/net/octeontx/meson.build b/drivers/net/octeontx/meson.build
index 84cd4e1142..a5a6c9661c 100644
--- a/drivers/net/octeontx/meson.build
+++ b/drivers/net/octeontx/meson.build
@@ -1,9 +1,9 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Cavium, Inc

-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif

--
2.17.1

[dpdk-dev] [PATCH v5 3/3] common/octeontx2: enable build only on 64-bit Linux

[pbhagavatula]

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Due to Linux kernel AF(Admin Function) driver dependency, only enable
build for 64-bit Linux.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---
 drivers/common/octeontx2/meson.build  | 10 ++--------
 drivers/event/octeontx2/meson.build   |  4 ++--
 drivers/mempool/octeontx2/meson.build |  9 ++-------
 drivers/net/octeontx2/meson.build     | 10 ++--------
 drivers/raw/octeontx2_dma/meson.build | 10 ++++++----
 5 files changed, 14 insertions(+), 29 deletions(-)

diff --git a/drivers/common/octeontx2/meson.build b/drivers/common/octeontx2/meson.build
index dcfaa1e102..223ba5ef51 100644
--- a/drivers/common/octeontx2/meson.build
+++ b/drivers/common/octeontx2/meson.build
@@ -2,15 +2,9 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #

-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
-    subdir_done()
-endif
-
-if not dpdk_conf.get('RTE_ARCH_64')
-    build = false
-    reason = 'only supported on 64-bit'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif

diff --git a/drivers/event/octeontx2/meson.build b/drivers/event/octeontx2/meson.build
index 96ebb1f2e7..ce360af5f8 100644
--- a/drivers/event/octeontx2/meson.build
+++ b/drivers/event/octeontx2/meson.build
@@ -2,9 +2,9 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #

-if not dpdk_conf.get('RTE_ARCH_64')
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'only supported on 64-bit'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif

diff --git a/drivers/mempool/octeontx2/meson.build b/drivers/mempool/octeontx2/meson.build
index 2a1dfddd4c..a4bea6d364 100644
--- a/drivers/mempool/octeontx2/meson.build
+++ b/drivers/mempool/octeontx2/meson.build
@@ -2,14 +2,9 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #

-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
-    subdir_done()
-endif
-if not dpdk_conf.get('RTE_ARCH_64')
-    build = false
-    reason = 'only supported on 64-bit'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif

diff --git a/drivers/net/octeontx2/meson.build b/drivers/net/octeontx2/meson.build
index a355313120..ab15844cbc 100644
--- a/drivers/net/octeontx2/meson.build
+++ b/drivers/net/octeontx2/meson.build
@@ -2,15 +2,9 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #

-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
-    subdir_done()
-endif
-
-if not dpdk_conf.get('RTE_ARCH_64')
-    build = false
-    reason = 'only supported on 64-bit'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif

diff --git a/drivers/raw/octeontx2_dma/meson.build b/drivers/raw/octeontx2_dma/meson.build
index e744fccaae..6460bd8242 100644
--- a/drivers/raw/octeontx2_dma/meson.build
+++ b/drivers/raw/octeontx2_dma/meson.build
@@ -2,14 +2,16 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #

+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
+    build = false
+    reason = 'only supported on 64-bit Linux'
+    subdir_done()
+endif
+
 deps += ['bus_pci', 'common_octeontx2', 'rawdev']
 sources = files('otx2_dpi_rawdev.c', 'otx2_dpi_msg.c', 'otx2_dpi_test.c')

 extra_flags = []
-# This integrated controller runs only on a arm64 machine, remove 32bit warnings
-if not dpdk_conf.get('RTE_ARCH_64')
-    extra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast']
-endif

 foreach flag: extra_flags
     if cc.has_argument(flag)
--
2.17.1

Re: [dpdk-dev] [PATCH v5 1/3] net/thunderx: enable build only on 64-bit Linux

[Ferruh Yigit]

On 10/4/2021 6:56 AM, pbhagavatula@marvell.com wrote:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Due to Linux kernel AF(Admin function) driver dependency, only enable
> build for 64-bit Linux.
> 

Hi Pavan,

Isn't it possible to provide a commit log in the kernel side etc, that let
others to verify why only 64 bit is required, or if someone want to support
32bit that may help them to investigate the source of the restriction.

> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
>  v5 Changes
>  - s/fuction/function.
> 
>  v4 Changes:
>  - Update commit message regarding dependency on AF driver.
> 
>  drivers/net/thunderx/meson.build | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/thunderx/meson.build b/drivers/net/thunderx/meson.build
> index 4bbcea7f93..da665bd76f 100644
> --- a/drivers/net/thunderx/meson.build
> +++ b/drivers/net/thunderx/meson.build
> @@ -1,9 +1,9 @@
>  # SPDX-License-Identifier: BSD-3-Clause
>  # Copyright(c) 2017 Cavium, Inc
> 
> -if is_windows
> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
>      build = false
> -    reason = 'not supported on Windows'
> +    reason = 'only supported on 64-bit Linux'
>      subdir_done()
>  endif
> 
> --
> 2.17.1
> 

[dpdk-dev] [PATCH v6 1/3] net/thunderx: enable build only on 64-bit Linux

[pbhagavatula]

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Since AARCH32 extension is not implemented on thunderx family, only
enable build for 64bit.
Due to Linux kernel AF(Admin function) driver dependency, only enable
build for Linux.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---
 v6 Changes:
 - Update commit log to describe why 32bit is not supported.
 v5 Changes:
 - s/fuction/function.
 v4 Changes:
 - Update commit message regarding dependency on AF driver.

 drivers/net/thunderx/meson.build | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/thunderx/meson.build b/drivers/net/thunderx/meson.build
index 4bbcea7f93..da665bd76f 100644
--- a/drivers/net/thunderx/meson.build
+++ b/drivers/net/thunderx/meson.build
@@ -1,9 +1,9 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Cavium, Inc

-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif

--
2.17.1

[dpdk-dev] [PATCH v6 2/3] common/octeontx: enable build only on 64-bit Linux

[pbhagavatula]

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Since AARCH32 extension is not implemented on octeontx family, only
enable build for 64bit.
Due to Linux kernel AF(Admin function) driver dependency, only enable
build for 64-bit Linux.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---
 drivers/common/octeontx/meson.build   | 4 ++--
 drivers/compress/octeontx/meson.build | 6 ++++++
 drivers/crypto/octeontx/meson.build   | 7 +++++++
 drivers/event/octeontx/meson.build    | 6 ++++++
 drivers/mempool/octeontx/meson.build  | 5 +++--
 drivers/net/octeontx/meson.build      | 4 ++--
 6 files changed, 26 insertions(+), 6 deletions(-)

diff --git a/drivers/common/octeontx/meson.build b/drivers/common/octeontx/meson.build
index fcda0f6445..dc060dfea1 100644
--- a/drivers/common/octeontx/meson.build
+++ b/drivers/common/octeontx/meson.build
@@ -2,9 +2,9 @@
 # Copyright(c) 2018 Cavium, Inc
 #
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif
 
diff --git a/drivers/compress/octeontx/meson.build b/drivers/compress/octeontx/meson.build
index e1b7bed422..cd8687fde3 100644
--- a/drivers/compress/octeontx/meson.build
+++ b/drivers/compress/octeontx/meson.build
@@ -1,6 +1,12 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2018 Cavium, Inc
 
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
+	build = false
+	reason = 'only supported on 64-bit Linux'
+	subdir_done()
+endif
+
 sources = files('otx_zip.c', 'otx_zip_pmd.c')
 includes += include_directories('include')
 deps += ['mempool_octeontx', 'bus_pci']
diff --git a/drivers/crypto/octeontx/meson.build b/drivers/crypto/octeontx/meson.build
index 244b16230e..bc6187e1cf 100644
--- a/drivers/crypto/octeontx/meson.build
+++ b/drivers/crypto/octeontx/meson.build
@@ -1,5 +1,12 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2018 Cavium, Inc
+#
+
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
+    build = false
+    reason = 'only supported on 64-bit Linux'
+    subdir_done()
+endif
 
 deps += ['bus_pci']
 deps += ['bus_vdev']
diff --git a/drivers/event/octeontx/meson.build b/drivers/event/octeontx/meson.build
index 0d9eec3f2e..eb17e059d8 100644
--- a/drivers/event/octeontx/meson.build
+++ b/drivers/event/octeontx/meson.build
@@ -1,6 +1,12 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Cavium, Inc
 
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
+    build = false
+    reason = 'only supported on 64-bit Linux'
+    subdir_done()
+endif
+
 sources = files(
         'ssovf_worker.c',
         'ssovf_evdev.c',
diff --git a/drivers/mempool/octeontx/meson.build b/drivers/mempool/octeontx/meson.build
index a57213e2d8..fb05928129 100644
--- a/drivers/mempool/octeontx/meson.build
+++ b/drivers/mempool/octeontx/meson.build
@@ -1,9 +1,10 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Cavium, Inc
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
+    reason = 'only supported on 64-bit Linux'
+    subdir_done()
 endif
 
 sources = files(
diff --git a/drivers/net/octeontx/meson.build b/drivers/net/octeontx/meson.build
index 84cd4e1142..a5a6c9661c 100644
--- a/drivers/net/octeontx/meson.build
+++ b/drivers/net/octeontx/meson.build
@@ -1,9 +1,9 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Cavium, Inc
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif
 
-- 
2.17.1

Re: [dpdk-dev] [PATCH v6 2/3] common/octeontx: enable build only on 64-bit Linux

[Harman Kalra]

> -----Original Message-----
> From: pbhagavatula@marvell.com <pbhagavatula@marvell.com>
> Sent: Friday, October 15, 2021 1:27 AM
> To: ferruh.yigit@intel.com; Jerin Jacob Kollanukkaran <jerinj@marvell.com>;
> Harman Kalra <hkalra@marvell.com>; Ashish Gupta
> <ashishg@marvell.com>; Fiona Trahe <fiona.trahe@intel.com>; Anoob
> Joseph <anoobj@marvell.com>
> Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>
> Subject: [dpdk-dev] [PATCH v6 2/3] common/octeontx: enable build only on
> 64-bit Linux
> 
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Since AARCH32 extension is not implemented on octeontx family, only
> enable build for 64bit.
> Due to Linux kernel AF(Admin function) driver dependency, only enable build
> for 64-bit Linux.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---

Acked-by: Harman Kalra <hkalra@marvell.com>


Thanks
Harman

>  drivers/common/octeontx/meson.build   | 4 ++--
>  drivers/compress/octeontx/meson.build | 6 ++++++
>  drivers/crypto/octeontx/meson.build   | 7 +++++++
>  drivers/event/octeontx/meson.build    | 6 ++++++
>  drivers/mempool/octeontx/meson.build  | 5 +++--
>  drivers/net/octeontx/meson.build      | 4 ++--
>  6 files changed, 26 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/common/octeontx/meson.build
> b/drivers/common/octeontx/meson.build
> index fcda0f6445..dc060dfea1 100644
> --- a/drivers/common/octeontx/meson.build
> +++ b/drivers/common/octeontx/meson.build
> @@ -2,9 +2,9 @@
>  # Copyright(c) 2018 Cavium, Inc
>  #
> 
> -if is_windows
> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
>      build = false
> -    reason = 'not supported on Windows'
> +    reason = 'only supported on 64-bit Linux'
>      subdir_done()
>  endif
> 
> diff --git a/drivers/compress/octeontx/meson.build
> b/drivers/compress/octeontx/meson.build
> index e1b7bed422..cd8687fde3 100644
> --- a/drivers/compress/octeontx/meson.build
> +++ b/drivers/compress/octeontx/meson.build
> @@ -1,6 +1,12 @@
>  # SPDX-License-Identifier: BSD-3-Clause  # Copyright(c) 2018 Cavium, Inc
> 
> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
> +	build = false
> +	reason = 'only supported on 64-bit Linux'
> +	subdir_done()
> +endif
> +
>  sources = files('otx_zip.c', 'otx_zip_pmd.c')  includes +=
> include_directories('include')  deps += ['mempool_octeontx', 'bus_pci'] diff --
> git a/drivers/crypto/octeontx/meson.build
> b/drivers/crypto/octeontx/meson.build
> index 244b16230e..bc6187e1cf 100644
> --- a/drivers/crypto/octeontx/meson.build
> +++ b/drivers/crypto/octeontx/meson.build
> @@ -1,5 +1,12 @@
>  # SPDX-License-Identifier: BSD-3-Clause  # Copyright(c) 2018 Cavium, Inc
> +#
> +
> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
> +    build = false
> +    reason = 'only supported on 64-bit Linux'
> +    subdir_done()
> +endif
> 
>  deps += ['bus_pci']
>  deps += ['bus_vdev']
> diff --git a/drivers/event/octeontx/meson.build
> b/drivers/event/octeontx/meson.build
> index 0d9eec3f2e..eb17e059d8 100644
> --- a/drivers/event/octeontx/meson.build
> +++ b/drivers/event/octeontx/meson.build
> @@ -1,6 +1,12 @@
>  # SPDX-License-Identifier: BSD-3-Clause  # Copyright(c) 2017 Cavium, Inc
> 
> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
> +    build = false
> +    reason = 'only supported on 64-bit Linux'
> +    subdir_done()
> +endif
> +
>  sources = files(
>          'ssovf_worker.c',
>          'ssovf_evdev.c',
> diff --git a/drivers/mempool/octeontx/meson.build
> b/drivers/mempool/octeontx/meson.build
> index a57213e2d8..fb05928129 100644
> --- a/drivers/mempool/octeontx/meson.build
> +++ b/drivers/mempool/octeontx/meson.build
> @@ -1,9 +1,10 @@
>  # SPDX-License-Identifier: BSD-3-Clause  # Copyright(c) 2017 Cavium, Inc
> 
> -if is_windows
> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
>      build = false
> -    reason = 'not supported on Windows'
> +    reason = 'only supported on 64-bit Linux'
> +    subdir_done()
>  endif
> 
>  sources = files(
> diff --git a/drivers/net/octeontx/meson.build
> b/drivers/net/octeontx/meson.build
> index 84cd4e1142..a5a6c9661c 100644
> --- a/drivers/net/octeontx/meson.build
> +++ b/drivers/net/octeontx/meson.build
> @@ -1,9 +1,9 @@
>  # SPDX-License-Identifier: BSD-3-Clause  # Copyright(c) 2017 Cavium, Inc
> 
> -if is_windows
> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
>      build = false
> -    reason = 'not supported on Windows'
> +    reason = 'only supported on 64-bit Linux'
>      subdir_done()
>  endif
> 
> --
> 2.17.1

[dpdk-dev] [PATCH v6 3/3] common/octeontx2: enable build only on 64-bit Linux

[pbhagavatula]

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Since AARCH32 extension is not implemented on octeontx2 family, only
enable build for 64bit.
Due to Linux kernel AF(Admin Function) driver dependency, only enable
build for 64-bit Linux.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---
 drivers/common/octeontx2/meson.build  | 10 ++--------
 drivers/event/octeontx2/meson.build   |  4 ++--
 drivers/mempool/octeontx2/meson.build |  9 ++-------
 drivers/net/octeontx2/meson.build     | 10 ++--------
 drivers/raw/octeontx2_dma/meson.build | 10 ++++++----
 5 files changed, 14 insertions(+), 29 deletions(-)

diff --git a/drivers/common/octeontx2/meson.build b/drivers/common/octeontx2/meson.build
index dcfaa1e102..223ba5ef51 100644
--- a/drivers/common/octeontx2/meson.build
+++ b/drivers/common/octeontx2/meson.build
@@ -2,15 +2,9 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
-    subdir_done()
-endif
-
-if not dpdk_conf.get('RTE_ARCH_64')
-    build = false
-    reason = 'only supported on 64-bit'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif
 
diff --git a/drivers/event/octeontx2/meson.build b/drivers/event/octeontx2/meson.build
index 96ebb1f2e7..ce360af5f8 100644
--- a/drivers/event/octeontx2/meson.build
+++ b/drivers/event/octeontx2/meson.build
@@ -2,9 +2,9 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #
 
-if not dpdk_conf.get('RTE_ARCH_64')
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'only supported on 64-bit'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif
 
diff --git a/drivers/mempool/octeontx2/meson.build b/drivers/mempool/octeontx2/meson.build
index 2a1dfddd4c..a4bea6d364 100644
--- a/drivers/mempool/octeontx2/meson.build
+++ b/drivers/mempool/octeontx2/meson.build
@@ -2,14 +2,9 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
-    subdir_done()
-endif
-if not dpdk_conf.get('RTE_ARCH_64')
-    build = false
-    reason = 'only supported on 64-bit'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif
 
diff --git a/drivers/net/octeontx2/meson.build b/drivers/net/octeontx2/meson.build
index a355313120..ab15844cbc 100644
--- a/drivers/net/octeontx2/meson.build
+++ b/drivers/net/octeontx2/meson.build
@@ -2,15 +2,9 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
-    subdir_done()
-endif
-
-if not dpdk_conf.get('RTE_ARCH_64')
-    build = false
-    reason = 'only supported on 64-bit'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif
 
diff --git a/drivers/raw/octeontx2_dma/meson.build b/drivers/raw/octeontx2_dma/meson.build
index e744fccaae..6460bd8242 100644
--- a/drivers/raw/octeontx2_dma/meson.build
+++ b/drivers/raw/octeontx2_dma/meson.build
@@ -2,14 +2,16 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #
 
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
+    build = false
+    reason = 'only supported on 64-bit Linux'
+    subdir_done()
+endif
+
 deps += ['bus_pci', 'common_octeontx2', 'rawdev']
 sources = files('otx2_dpi_rawdev.c', 'otx2_dpi_msg.c', 'otx2_dpi_test.c')
 
 extra_flags = []
-# This integrated controller runs only on a arm64 machine, remove 32bit warnings
-if not dpdk_conf.get('RTE_ARCH_64')
-    extra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast']
-endif
 
 foreach flag: extra_flags
     if cc.has_argument(flag)
-- 
2.17.1

Re: [dpdk-dev] [PATCH v6 1/3] net/thunderx: enable build only on 64-bit Linux

[Ferruh Yigit]

On 10/14/2021 8:56 PM, pbhagavatula@marvell.com wrote:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Since AARCH32 extension is not implemented on thunderx family, only
> enable build for 64bit.
> Due to Linux kernel AF(Admin function) driver dependency, only enable
> build for Linux.
> 

Hi Pavan,

Perhaps this patch took more time than it should, but according Jerin's
description the problem is SoC can't run 32bit applications.

Why do you still mention from the kernel driver dependency? It looks like
that dependency is not reason to not compile 32 bit app, am I missing
something?

> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
>   v6 Changes:
>   - Update commit log to describe why 32bit is not supported.
>   v5 Changes:
>   - s/fuction/function.
>   v4 Changes:
>   - Update commit message regarding dependency on AF driver.
> 
>   drivers/net/thunderx/meson.build | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/thunderx/meson.build b/drivers/net/thunderx/meson.build
> index 4bbcea7f93..da665bd76f 100644
> --- a/drivers/net/thunderx/meson.build
> +++ b/drivers/net/thunderx/meson.build
> @@ -1,9 +1,9 @@
>   # SPDX-License-Identifier: BSD-3-Clause
>   # Copyright(c) 2017 Cavium, Inc
> 
> -if is_windows
> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
>       build = false
> -    reason = 'not supported on Windows'
> +    reason = 'only supported on 64-bit Linux'
>       subdir_done()
>   endif
> 
> --
> 2.17.1
> 

Re: [dpdk-dev] [EXT] Re: [PATCH v6 1/3] net/thunderx: enable build only on 64-bit Linux

[Pavan Nikhilesh Bhagavatula]

>-----Original Message-----
>From: dev <dev-bounces@dpdk.org> On Behalf Of Ferruh Yigit
>Sent: Friday, October 15, 2021 4:09 PM
>To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>; Jerin
>Jacob Kollanukkaran <jerinj@marvell.com>; Maciej Czekaj [C]
><mczekaj@marvell.com>
>Cc: dev@dpdk.org
>Subject: [EXT] Re: [dpdk-dev] [PATCH v6 1/3] net/thunderx: enable
>build only on 64-bit Linux
>
>External Email
>
>----------------------------------------------------------------------
>On 10/14/2021 8:56 PM, pbhagavatula@marvell.com wrote:
>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>
>> Since AARCH32 extension is not implemented on thunderx family,
>only
>> enable build for 64bit.
>> Due to Linux kernel AF(Admin function) driver dependency, only
>enable
>> build for Linux.
>>
>
>Hi Pavan,
>
>Perhaps this patch took more time than it should, but according Jerin's
>description the problem is SoC can't run 32bit applications.
>
>Why do you still mention from the kernel driver dependency? It looks
>like
>that dependency is not reason to not compile 32 bit app, am I missing
>something?
>

Since DPDK runs on FreeBSD and Windows and AF driver is absent for those
We are disabling this driver non-Linux compilations too.

>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>> Acked-by: Jerin Jacob <jerinj@marvell.com>
>> ---
>>   v6 Changes:
>>   - Update commit log to describe why 32bit is not supported.
>>   v5 Changes:
>>   - s/fuction/function.
>>   v4 Changes:
>>   - Update commit message regarding dependency on AF driver.
>>
>>   drivers/net/thunderx/meson.build | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/thunderx/meson.build
>b/drivers/net/thunderx/meson.build
>> index 4bbcea7f93..da665bd76f 100644
>> --- a/drivers/net/thunderx/meson.build
>> +++ b/drivers/net/thunderx/meson.build
>> @@ -1,9 +1,9 @@
>>   # SPDX-License-Identifier: BSD-3-Clause
>>   # Copyright(c) 2017 Cavium, Inc
>>
>> -if is_windows
>> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
>>       build = false
>> -    reason = 'not supported on Windows'
>> +    reason = 'only supported on 64-bit Linux'
>>       subdir_done()
>>   endif
>>
>> --
>> 2.17.1
>>

Re: [dpdk-dev] [EXT] Re: [PATCH v6 1/3] net/thunderx: enable build only on 64-bit Linux

[Ferruh Yigit]

On 10/15/2021 2:58 PM, Pavan Nikhilesh Bhagavatula wrote:
> 
> 
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Ferruh Yigit
>> Sent: Friday, October 15, 2021 4:09 PM
>> To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>; Jerin
>> Jacob Kollanukkaran <jerinj@marvell.com>; Maciej Czekaj [C]
>> <mczekaj@marvell.com>
>> Cc: dev@dpdk.org
>> Subject: [EXT] Re: [dpdk-dev] [PATCH v6 1/3] net/thunderx: enable
>> build only on 64-bit Linux
>>
>> External Email
>>
>> ----------------------------------------------------------------------
>> On 10/14/2021 8:56 PM, pbhagavatula@marvell.com wrote:
>>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>
>>> Since AARCH32 extension is not implemented on thunderx family,
>> only
>>> enable build for 64bit.
>>> Due to Linux kernel AF(Admin function) driver dependency, only
>> enable
>>> build for Linux.
>>>
>>
>> Hi Pavan,
>>
>> Perhaps this patch took more time than it should, but according Jerin's
>> description the problem is SoC can't run 32bit applications.
>>
>> Why do you still mention from the kernel driver dependency? It looks
>> like
>> that dependency is not reason to not compile 32 bit app, am I missing
>> something?
>>
> 
> Since DPDK runs on FreeBSD and Windows and AF driver is absent for those
> We are disabling this driver non-Linux compilations too.
> 

Ah, it doesn't only add 'RTE_ARCH_64' requirement, also reduces the support
to Linux, so commit log makes sense. Thanks.

>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>> Acked-by: Jerin Jacob <jerinj@marvell.com>
>>> ---
>>>    v6 Changes:
>>>    - Update commit log to describe why 32bit is not supported.
>>>    v5 Changes:
>>>    - s/fuction/function.
>>>    v4 Changes:
>>>    - Update commit message regarding dependency on AF driver.
>>>
>>>    drivers/net/thunderx/meson.build | 4 ++--
>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/thunderx/meson.build
>> b/drivers/net/thunderx/meson.build
>>> index 4bbcea7f93..da665bd76f 100644
>>> --- a/drivers/net/thunderx/meson.build
>>> +++ b/drivers/net/thunderx/meson.build
>>> @@ -1,9 +1,9 @@
>>>    # SPDX-License-Identifier: BSD-3-Clause
>>>    # Copyright(c) 2017 Cavium, Inc
>>>
>>> -if is_windows
>>> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
>>>        build = false
>>> -    reason = 'not supported on Windows'
>>> +    reason = 'only supported on 64-bit Linux'
>>>        subdir_done()
>>>    endif
>>>
>>> --
>>> 2.17.1
>>>
> 

Re: [dpdk-dev] [PATCH v6 1/3] net/thunderx: enable build only on 64-bit Linux

[Ferruh Yigit]

On 10/14/2021 8:56 PM, pbhagavatula@marvell.com wrote:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Since AARCH32 extension is not implemented on thunderx family, only
> enable build for 64bit.
> Due to Linux kernel AF(Admin function) driver dependency, only enable
> build for Linux.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> Acked-by: Jerin Jacob <jerinj@marvell.com>

Series applied to dpdk-next-net/main, thanks.

[dpdk-dev] [PATCH 21.11 v2 2/3] common/octeontx: enable build only on 64-bit Linux

[Thomas Monjalon]

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Due to Linux kernel dependency, only enable build for 64-bit Linux.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---
 drivers/common/octeontx/meson.build   | 6 ++++++
 drivers/compress/octeontx/meson.build | 6 ++++++
 drivers/crypto/octeontx/meson.build   | 7 +++++--
 drivers/event/octeontx/meson.build    | 6 ++++++
 drivers/mempool/octeontx/meson.build  | 5 +++--
 drivers/net/octeontx/meson.build      | 4 ++--
 6 files changed, 28 insertions(+), 6 deletions(-)

diff --git a/drivers/common/octeontx/meson.build b/drivers/common/octeontx/meson.build
index 203d1ef496..f29b583204 100644
--- a/drivers/common/octeontx/meson.build
+++ b/drivers/common/octeontx/meson.build
@@ -2,4 +2,10 @@
 # Copyright(c) 2018 Cavium, Inc
 #
 
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
+	build = false
+	reason = 'only supported on 64-bit Linux'
+	subdir_done()
+endif
+
 sources = files('octeontx_mbox.c')
diff --git a/drivers/compress/octeontx/meson.build b/drivers/compress/octeontx/meson.build
index e1b7bed422..cd8687fde3 100644
--- a/drivers/compress/octeontx/meson.build
+++ b/drivers/compress/octeontx/meson.build
@@ -1,6 +1,12 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2018 Cavium, Inc
 
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
+	build = false
+	reason = 'only supported on 64-bit Linux'
+	subdir_done()
+endif
+
 sources = files('otx_zip.c', 'otx_zip_pmd.c')
 includes += include_directories('include')
 deps += ['mempool_octeontx', 'bus_pci']
diff --git a/drivers/crypto/octeontx/meson.build b/drivers/crypto/octeontx/meson.build
index a353d37a10..2e5838641d 100644
--- a/drivers/crypto/octeontx/meson.build
+++ b/drivers/crypto/octeontx/meson.build
@@ -1,8 +1,11 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2018 Cavium, Inc
-if not is_linux
+#
+
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
 	build = false
-	reason = 'only supported on Linux'
+	reason = 'only supported on 64-bit Linux'
+	subdir_done()
 endif
 
 deps += ['bus_pci']
diff --git a/drivers/event/octeontx/meson.build b/drivers/event/octeontx/meson.build
index 41e367684c..63c7f793a6 100644
--- a/drivers/event/octeontx/meson.build
+++ b/drivers/event/octeontx/meson.build
@@ -1,6 +1,12 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Cavium, Inc
 
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
+	build = false
+	reason = 'only supported on 64-bit Linux'
+	subdir_done()
+endif
+
 sources = files('ssovf_worker.c',
 		'ssovf_evdev.c',
 		'ssovf_evdev_selftest.c',
diff --git a/drivers/mempool/octeontx/meson.build b/drivers/mempool/octeontx/meson.build
index b5695a9329..4607dfe23d 100644
--- a/drivers/mempool/octeontx/meson.build
+++ b/drivers/mempool/octeontx/meson.build
@@ -1,9 +1,10 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Cavium, Inc
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
 	build = false
-	reason = 'not supported on Windows'
+	reason = 'only supported on 64-bit Linux'
+	subdir_done()
 endif
 
 sources = files('octeontx_fpavf.c',
diff --git a/drivers/net/octeontx/meson.build b/drivers/net/octeontx/meson.build
index 4e784b9484..a0d0fb80e6 100644
--- a/drivers/net/octeontx/meson.build
+++ b/drivers/net/octeontx/meson.build
@@ -1,9 +1,9 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Cavium, Inc
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
 	build = false
-	reason = 'not supported on Windows'
+	reason = 'only supported on 64-bit Linux'
 	subdir_done()
 endif
 
-- 
2.30.1

[dpdk-dev] [PATCH 21.11 v2 3/3] common/octeontx2: enable build only on 64-bit Linux

[Thomas Monjalon]

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Due to Linux kernel dependency, only enable build for 64-bit Linux.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---
 drivers/common/octeontx2/meson.build  |  4 ++--
 drivers/event/octeontx2/meson.build   |  4 ++--
 drivers/mempool/octeontx2/meson.build |  9 ++-------
 drivers/net/octeontx2/meson.build     | 10 ++--------
 drivers/raw/octeontx2_dma/meson.build | 10 ++++++----
 5 files changed, 14 insertions(+), 23 deletions(-)

diff --git a/drivers/common/octeontx2/meson.build b/drivers/common/octeontx2/meson.build
index 84fb11524d..3ae1067921 100644
--- a/drivers/common/octeontx2/meson.build
+++ b/drivers/common/octeontx2/meson.build
@@ -2,9 +2,9 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #
 
-if not dpdk_conf.get('RTE_ARCH_64')
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
 	build = false
-	reason = 'only supported on 64-bit'
+	reason = 'only supported on 64-bit Linux'
 	subdir_done()
 endif
 
diff --git a/drivers/event/octeontx2/meson.build b/drivers/event/octeontx2/meson.build
index 22e7e4cb63..c81950cefe 100644
--- a/drivers/event/octeontx2/meson.build
+++ b/drivers/event/octeontx2/meson.build
@@ -2,9 +2,9 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #
 
-if not dpdk_conf.get('RTE_ARCH_64')
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
 	build = false
-	reason = 'only supported on 64-bit'
+	reason = 'only supported on 64-bit Linux'
 	subdir_done()
 endif
 
diff --git a/drivers/mempool/octeontx2/meson.build b/drivers/mempool/octeontx2/meson.build
index 0586321abe..c67d8e2d20 100644
--- a/drivers/mempool/octeontx2/meson.build
+++ b/drivers/mempool/octeontx2/meson.build
@@ -2,14 +2,9 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
 	build = false
-	reason = 'not supported on Windows'
-	subdir_done()
-endif
-if not dpdk_conf.get('RTE_ARCH_64')
-	build = false
-	reason = 'only supported on 64-bit'
+	reason = 'only supported on 64-bit Linux'
 	subdir_done()
 endif
 
diff --git a/drivers/net/octeontx2/meson.build b/drivers/net/octeontx2/meson.build
index 779a75b5d0..5dbe002e3f 100644
--- a/drivers/net/octeontx2/meson.build
+++ b/drivers/net/octeontx2/meson.build
@@ -2,15 +2,9 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #
 
-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
 	build = false
-	reason = 'not supported on Windows'
-	subdir_done()
-endif
-
-if not dpdk_conf.get('RTE_ARCH_64')
-	build = false
-	reason = 'only supported on 64-bit'
+	reason = 'only supported on 64-bit Linux'
 	subdir_done()
 endif
 
diff --git a/drivers/raw/octeontx2_dma/meson.build b/drivers/raw/octeontx2_dma/meson.build
index 11f74680a5..1910351253 100644
--- a/drivers/raw/octeontx2_dma/meson.build
+++ b/drivers/raw/octeontx2_dma/meson.build
@@ -2,14 +2,16 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #
 
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
+	build = false
+	reason = 'only supported on 64-bit Linux'
+	subdir_done()
+endif
+
 deps += ['bus_pci', 'common_octeontx2', 'rawdev']
 sources = files('otx2_dpi_rawdev.c', 'otx2_dpi_msg.c', 'otx2_dpi_test.c')
 
 extra_flags = []
-# This integrated controller runs only on a arm64 machine, remove 32bit warnings
-if not dpdk_conf.get('RTE_ARCH_64')
-	extra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast']
-endif
 
 foreach flag: extra_flags
 	if cc.has_argument(flag)
-- 
2.30.1

Re: [dpdk-dev] [PATCH 21.11 v2 0/3] octeontx build only on 64-bit Linux

[David Marchand]

On Thu, Mar 25, 2021 at 3:52 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> This is a reorg of the patches from Pavan.
> It has been discussed that it should wait for DPDK 21.11
> for ABI compatibility reason.
>
> Pavan Nikhilesh (3):
>   net/thunderx: enable build only on 64-bit Linux
>   common/octeontx: enable build only on 64-bit Linux
>   common/octeontx2: enable build only on 64-bit Linux
>
>  drivers/common/octeontx/meson.build   |  6 ++++++
>  drivers/common/octeontx2/meson.build  |  4 ++--
>  drivers/compress/octeontx/meson.build |  6 ++++++
>  drivers/crypto/octeontx/meson.build   |  7 +++++--
>  drivers/event/octeontx/meson.build    |  6 ++++++
>  drivers/event/octeontx2/meson.build   |  4 ++--
>  drivers/mempool/octeontx/meson.build  |  5 +++--
>  drivers/mempool/octeontx2/meson.build |  9 ++-------
>  drivers/net/octeontx/meson.build      |  4 ++--
>  drivers/net/octeontx2/meson.build     | 10 ++--------
>  drivers/net/thunderx/meson.build      |  4 ++--
>  drivers/raw/octeontx2_dma/meson.build | 10 ++++++----
>  12 files changed, 44 insertions(+), 31 deletions(-)

There were a couple of cleanups (indent etc..) and changes in meson files.
This series does not apply cleanly on the main branch.
Could you rebase it?

I noticed that the net/cnxk driver does not have this check, but it is
disabled anyway since it depends on common/cnxk.
Is it worth adding the check for consistency?


-- 
David Marchand

Re: [dpdk-dev] [PATCH v5 1/3] net/thunderx: enable build only on 64-bit Linux

[Pavan Nikhilesh Bhagavatula]

>On 10/4/2021 6:56 AM, pbhagavatula@marvell.com wrote:
>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>
>> Due to Linux kernel AF(Admin function) driver dependency, only
>enable
>> build for 64-bit Linux.
>>
>
>Hi Pavan,
>
>Isn't it possible to provide a commit log in the kernel side etc, that let
>others to verify why only 64 bit is required, or if someone want to
>support
>32bit that may help them to investigate the source of the restriction.

Arch 32 support is not implemented on ThunderX, so 32bit will not run.

>
>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>> Acked-by: Jerin Jacob <jerinj@marvell.com>
>> ---
>>  v5 Changes
>>  - s/fuction/function.
>>
>>  v4 Changes:
>>  - Update commit message regarding dependency on AF driver.
>>
>>  drivers/net/thunderx/meson.build | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/thunderx/meson.build
>b/drivers/net/thunderx/meson.build
>> index 4bbcea7f93..da665bd76f 100644
>> --- a/drivers/net/thunderx/meson.build
>> +++ b/drivers/net/thunderx/meson.build
>> @@ -1,9 +1,9 @@
>>  # SPDX-License-Identifier: BSD-3-Clause
>>  # Copyright(c) 2017 Cavium, Inc
>>
>> -if is_windows
>> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
>>      build = false
>> -    reason = 'not supported on Windows'
>> +    reason = 'only supported on 64-bit Linux'
>>      subdir_done()
>>  endif
>>
>> --
>> 2.17.1
>>

Re: [dpdk-dev] [PATCH v5 1/3] net/thunderx: enable build only on 64-bit Linux

[Ferruh Yigit]

On 10/4/2021 11:02 AM, Pavan Nikhilesh Bhagavatula wrote:
>> On 10/4/2021 6:56 AM, pbhagavatula@marvell.com wrote:
>>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>
>>> Due to Linux kernel AF(Admin function) driver dependency, only
>> enable
>>> build for 64-bit Linux.
>>>
>>
>> Hi Pavan,
>>
>> Isn't it possible to provide a commit log in the kernel side etc, that let
>> others to verify why only 64 bit is required, or if someone want to
>> support
>> 32bit that may help them to investigate the source of the restriction.
> 
> Arch 32 support is not implemented on ThunderX, so 32bit will not run.
> 

I see, is following correct:
All thunderx, octeonx & octeontx2 only supports VF in the DPDK, and PF is
supported by Linux kernel driver. And Linux kernel driver doesn't support arch32.

Is something changed in kernel driver side to drop the 32bit support?
If it was not supported at all, what is the motivation to disable the DPDK
drivers now?

>>
>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>> Acked-by: Jerin Jacob <jerinj@marvell.com>
>>> ---
>>>  v5 Changes
>>>  - s/fuction/function.
>>>
>>>  v4 Changes:
>>>  - Update commit message regarding dependency on AF driver.
>>>
>>>  drivers/net/thunderx/meson.build | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/thunderx/meson.build
>> b/drivers/net/thunderx/meson.build
>>> index 4bbcea7f93..da665bd76f 100644
>>> --- a/drivers/net/thunderx/meson.build
>>> +++ b/drivers/net/thunderx/meson.build
>>> @@ -1,9 +1,9 @@
>>>  # SPDX-License-Identifier: BSD-3-Clause
>>>  # Copyright(c) 2017 Cavium, Inc
>>>
>>> -if is_windows
>>> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
>>>      build = false
>>> -    reason = 'not supported on Windows'
>>> +    reason = 'only supported on 64-bit Linux'
>>>      subdir_done()
>>>  endif
>>>
>>> --
>>> 2.17.1
>>>
> 

Re: [dpdk-dev] [PATCH v5 1/3] net/thunderx: enable build only on 64-bit Linux

[Pavan Nikhilesh Bhagavatula]

>On 10/4/2021 11:02 AM, Pavan Nikhilesh Bhagavatula wrote:
>>> On 10/4/2021 6:56 AM, pbhagavatula@marvell.com wrote:
>>>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>>
>>>> Due to Linux kernel AF(Admin function) driver dependency, only
>>> enable
>>>> build for 64-bit Linux.
>>>>
>>>
>>> Hi Pavan,
>>>
>>> Isn't it possible to provide a commit log in the kernel side etc, that let
>>> others to verify why only 64 bit is required, or if someone want to
>>> support
>>> 32bit that may help them to investigate the source of the restriction.
>>
>> Arch 32 support is not implemented on ThunderX, so 32bit will not
>run.
>>
>
>I see, is following correct:
>All thunderx, octeonx & octeontx2 only supports VF in the DPDK, and PF
>is
>supported by Linux kernel driver. And Linux kernel driver doesn't
>support arch32.

AF != PF, AF is something that manages all the shared resources between PF/VF.

>
>Is something changed in kernel driver side to drop the 32bit support?
>If it was not supported at all, what is the motivation to disable the DPDK
>drivers now?
>

It was never supported to begin with, motivation is that build will fail if we try to 
compile with 32b.

>>>
>>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>> Acked-by: Jerin Jacob <jerinj@marvell.com>
>>>> ---
>>>>  v5 Changes
>>>>  - s/fuction/function.
>>>>
>>>>  v4 Changes:
>>>>  - Update commit message regarding dependency on AF driver.
>>>>
>>>>  drivers/net/thunderx/meson.build | 4 ++--
>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/net/thunderx/meson.build
>>> b/drivers/net/thunderx/meson.build
>>>> index 4bbcea7f93..da665bd76f 100644
>>>> --- a/drivers/net/thunderx/meson.build
>>>> +++ b/drivers/net/thunderx/meson.build
>>>> @@ -1,9 +1,9 @@
>>>>  # SPDX-License-Identifier: BSD-3-Clause
>>>>  # Copyright(c) 2017 Cavium, Inc
>>>>
>>>> -if is_windows
>>>> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
>>>>      build = false
>>>> -    reason = 'not supported on Windows'
>>>> +    reason = 'only supported on 64-bit Linux'
>>>>      subdir_done()
>>>>  endif
>>>>
>>>> --
>>>> 2.17.1
>>>>
>>

Re: [dpdk-dev] [PATCH v5 1/3] net/thunderx: enable build only on 64-bit Linux

[Ferruh Yigit]

On 10/4/2021 12:34 PM, Pavan Nikhilesh Bhagavatula wrote:
>> On 10/4/2021 11:02 AM, Pavan Nikhilesh Bhagavatula wrote:
>>>> On 10/4/2021 6:56 AM, pbhagavatula@marvell.com wrote:
>>>>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>>>
>>>>> Due to Linux kernel AF(Admin function) driver dependency, only
>>>> enable
>>>>> build for 64-bit Linux.
>>>>>
>>>>
>>>> Hi Pavan,
>>>>
>>>> Isn't it possible to provide a commit log in the kernel side etc, that let
>>>> others to verify why only 64 bit is required, or if someone want to
>>>> support
>>>> 32bit that may help them to investigate the source of the restriction.
>>>
>>> Arch 32 support is not implemented on ThunderX, so 32bit will not
>> run.
>>>
>>
>> I see, is following correct:
>> All thunderx, octeonx & octeontx2 only supports VF in the DPDK, and PF
>> is
>> supported by Linux kernel driver. And Linux kernel driver doesn't
>> support arch32.
> 
> AF != PF, AF is something that manages all the shared resources between PF/VF.
> 

I see, I though AF is part of PF functionality. Are there two different kernel
modules for PF and AF?

So can DPDK driver drive PF? In a way, PF by DPDK, VF by DPDK, AF by Linux
kernel driver.

>>
>> Is something changed in kernel driver side to drop the 32bit support?
>> If it was not supported at all, what is the motivation to disable the DPDK
>> drivers now?
>>
> 
> It was never supported to begin with, motivation is that build will fail if we try to 
> compile with 32b.
> 

If there is no plan to support 32bit in the kernel side, that is reasonable to
disable 32bit build, please provide above details in the commit log.

And after above said, how much maintenance cost to support 32bit, if the build
error is on the logging format "%lx" etc .. (as we mostly have 32bit build
errors), it is better to fix them using 'PRIx64' which is more proper way
anyway. If there is more logical issue with 32bit pointers, I agree with you to
disable it.
Can you please provided the build error in the commit log as record?

>>>>
>>>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>>> Acked-by: Jerin Jacob <jerinj@marvell.com>
>>>>> ---
>>>>>  v5 Changes
>>>>>  - s/fuction/function.
>>>>>
>>>>>  v4 Changes:
>>>>>  - Update commit message regarding dependency on AF driver.
>>>>>
>>>>>  drivers/net/thunderx/meson.build | 4 ++--
>>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/drivers/net/thunderx/meson.build
>>>> b/drivers/net/thunderx/meson.build
>>>>> index 4bbcea7f93..da665bd76f 100644
>>>>> --- a/drivers/net/thunderx/meson.build
>>>>> +++ b/drivers/net/thunderx/meson.build
>>>>> @@ -1,9 +1,9 @@
>>>>>  # SPDX-License-Identifier: BSD-3-Clause
>>>>>  # Copyright(c) 2017 Cavium, Inc
>>>>>
>>>>> -if is_windows
>>>>> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
>>>>>      build = false
>>>>> -    reason = 'not supported on Windows'
>>>>> +    reason = 'only supported on 64-bit Linux'
>>>>>      subdir_done()
>>>>>  endif
>>>>>
>>>>> --
>>>>> 2.17.1
>>>>>
>>>
> 

Re: [dpdk-dev] [PATCH v5 1/3] net/thunderx: enable build only on 64-bit Linux

[Pavan Nikhilesh Bhagavatula]

>On 10/4/2021 12:34 PM, Pavan Nikhilesh Bhagavatula wrote:
>>> On 10/4/2021 11:02 AM, Pavan Nikhilesh Bhagavatula wrote:
>>>>> On 10/4/2021 6:56 AM, pbhagavatula@marvell.com wrote:
>>>>>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>>>>
>>>>>> Due to Linux kernel AF(Admin function) driver dependency, only
>>>>> enable
>>>>>> build for 64-bit Linux.
>>>>>>
>>>>>
>>>>> Hi Pavan,
>>>>>
>>>>> Isn't it possible to provide a commit log in the kernel side etc, that
>let
>>>>> others to verify why only 64 bit is required, or if someone want to
>>>>> support
>>>>> 32bit that may help them to investigate the source of the
>restriction.
>>>>
>>>> Arch 32 support is not implemented on ThunderX, so 32bit will not
>>> run.
>>>>
>>>
>>> I see, is following correct:
>>> All thunderx, octeonx & octeontx2 only supports VF in the DPDK,
>and PF
>>> is
>>> supported by Linux kernel driver. And Linux kernel driver doesn't
>>> support arch32.
>>
>> AF != PF, AF is something that manages all the shared resources
>between PF/VF.
>>
>
>I see, I though AF is part of PF functionality. Are there two different
>kernel
>modules for PF and AF?
>
>So can DPDK driver drive PF? In a way, PF by DPDK, VF by DPDK, AF by
>Linux
>kernel driver.

Yup that’s correct.

>
>>>
>>> Is something changed in kernel driver side to drop the 32bit support?
>>> If it was not supported at all, what is the motivation to disable the
>DPDK
>>> drivers now?
>>>
>>
>> It was never supported to begin with, motivation is that build will fail if
>we try to
>> compile with 32b.
>>
>
>If there is no plan to support 32bit in the kernel side, that is reasonable
>to
>disable 32bit build, please provide above details in the commit log.
>
>And after above said, how much maintenance cost to support 32bit, if
>the build
>error is on the logging format "%lx" etc .. (as we mostly have 32bit build
>errors), it is better to fix them using 'PRIx64' which is more proper way
>anyway. If there is more logical issue with 32bit pointers, I agree with
>you to
>disable it.
>Can you please provided the build error in the commit log as record?
>

Apologies, I meant that all the functions that don’t fall under 64b are stubbed out
so the driver wouldn’t work.

>>>>>
>>>>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>>>> Acked-by: Jerin Jacob <jerinj@marvell.com>
>>>>>> ---
>>>>>>  v5 Changes
>>>>>>  - s/fuction/function.
>>>>>>
>>>>>>  v4 Changes:
>>>>>>  - Update commit message regarding dependency on AF driver.
>>>>>>
>>>>>>  drivers/net/thunderx/meson.build | 4 ++--
>>>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>>
>>>>>> diff --git a/drivers/net/thunderx/meson.build
>>>>> b/drivers/net/thunderx/meson.build
>>>>>> index 4bbcea7f93..da665bd76f 100644
>>>>>> --- a/drivers/net/thunderx/meson.build
>>>>>> +++ b/drivers/net/thunderx/meson.build
>>>>>> @@ -1,9 +1,9 @@
>>>>>>  # SPDX-License-Identifier: BSD-3-Clause
>>>>>>  # Copyright(c) 2017 Cavium, Inc
>>>>>>
>>>>>> -if is_windows
>>>>>> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
>>>>>>      build = false
>>>>>> -    reason = 'not supported on Windows'
>>>>>> +    reason = 'only supported on 64-bit Linux'
>>>>>>      subdir_done()
>>>>>>  endif
>>>>>>
>>>>>> --
>>>>>> 2.17.1
>>>>>>
>>>>
>>

Re: [dpdk-dev] [PATCH v5 1/3] net/thunderx: enable build only on 64-bit Linux

[Ferruh Yigit]

On 10/4/2021 1:01 PM, Pavan Nikhilesh Bhagavatula wrote:
>> On 10/4/2021 12:34 PM, Pavan Nikhilesh Bhagavatula wrote:
>>>> On 10/4/2021 11:02 AM, Pavan Nikhilesh Bhagavatula wrote:
>>>>>> On 10/4/2021 6:56 AM, pbhagavatula@marvell.com wrote:
>>>>>>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>>>>>
>>>>>>> Due to Linux kernel AF(Admin function) driver dependency, only
>>>>>> enable
>>>>>>> build for 64-bit Linux.
>>>>>>>
>>>>>>
>>>>>> Hi Pavan,
>>>>>>
>>>>>> Isn't it possible to provide a commit log in the kernel side etc, that
>> let
>>>>>> others to verify why only 64 bit is required, or if someone want to
>>>>>> support
>>>>>> 32bit that may help them to investigate the source of the
>> restriction.
>>>>>
>>>>> Arch 32 support is not implemented on ThunderX, so 32bit will not
>>>> run.
>>>>>
>>>>
>>>> I see, is following correct:
>>>> All thunderx, octeonx & octeontx2 only supports VF in the DPDK,
>> and PF
>>>> is
>>>> supported by Linux kernel driver. And Linux kernel driver doesn't
>>>> support arch32.
>>>
>>> AF != PF, AF is something that manages all the shared resources
>> between PF/VF.
>>>
>>
>> I see, I though AF is part of PF functionality. Are there two different
>> kernel
>> modules for PF and AF?
>>
>> So can DPDK driver drive PF? In a way, PF by DPDK, VF by DPDK, AF by
>> Linux
>> kernel driver.
> 
> Yup that’s correct.
> 
>>
>>>>
>>>> Is something changed in kernel driver side to drop the 32bit support?
>>>> If it was not supported at all, what is the motivation to disable the
>> DPDK
>>>> drivers now?
>>>>
>>>
>>> It was never supported to begin with, motivation is that build will fail if
>> we try to
>>> compile with 32b.
>>>
>>
>> If there is no plan to support 32bit in the kernel side, that is reasonable
>> to
>> disable 32bit build, please provide above details in the commit log.
>>
>> And after above said, how much maintenance cost to support 32bit, if
>> the build
>> error is on the logging format "%lx" etc .. (as we mostly have 32bit build
>> errors), it is better to fix them using 'PRIx64' which is more proper way
>> anyway. If there is more logical issue with 32bit pointers, I agree with
>> you to
>> disable it.
>> Can you please provided the build error in the commit log as record?
>>
> 
> Apologies, I meant that all the functions that don’t fall under 64b are stubbed out
> so the driver wouldn’t work.
> 

so is there build error or not?

>>>>>>
>>>>>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>>>>> Acked-by: Jerin Jacob <jerinj@marvell.com>
>>>>>>> ---
>>>>>>>  v5 Changes
>>>>>>>  - s/fuction/function.
>>>>>>>
>>>>>>>  v4 Changes:
>>>>>>>  - Update commit message regarding dependency on AF driver.
>>>>>>>
>>>>>>>  drivers/net/thunderx/meson.build | 4 ++--
>>>>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>>>
>>>>>>> diff --git a/drivers/net/thunderx/meson.build
>>>>>> b/drivers/net/thunderx/meson.build
>>>>>>> index 4bbcea7f93..da665bd76f 100644
>>>>>>> --- a/drivers/net/thunderx/meson.build
>>>>>>> +++ b/drivers/net/thunderx/meson.build
>>>>>>> @@ -1,9 +1,9 @@
>>>>>>>  # SPDX-License-Identifier: BSD-3-Clause
>>>>>>>  # Copyright(c) 2017 Cavium, Inc
>>>>>>>
>>>>>>> -if is_windows
>>>>>>> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
>>>>>>>      build = false
>>>>>>> -    reason = 'not supported on Windows'
>>>>>>> +    reason = 'only supported on 64-bit Linux'
>>>>>>>      subdir_done()
>>>>>>>  endif
>>>>>>>
>>>>>>> --
>>>>>>> 2.17.1
>>>>>>>
>>>>>
>>>
>