From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5320A0547; Mon, 21 Jun 2021 02:52:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21DFD40040; Mon, 21 Jun 2021 02:52:39 +0200 (CEST) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id 5ABCB4003F for ; Mon, 21 Jun 2021 02:52:38 +0200 (CEST) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4G7W8J16mnz1BPqL; Mon, 21 Jun 2021 08:47:28 +0800 (CST) Received: from dggpeml500024.china.huawei.com (7.185.36.10) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 21 Jun 2021 08:52:35 +0800 Received: from [127.0.0.1] (10.40.190.165) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 21 Jun 2021 08:52:34 +0800 To: "thomas@monjalon.net" CC: Honnappa Nagarahalli , "jerinj@marvell.com" , Ruifeng Wang , "juraj.linkes@pantheon.tech" , "ferruh.yigit@intel.com" , "dev@dpdk.org" , "viktorin@rehivetech.com" , "bruce.richardson@intel.com" , "jerinjacobk@gmail.com" , nd References: <1620808126-18876-1-git-send-email-fengchengwen@huawei.com> <1621862602-51782-1-git-send-email-fengchengwen@huawei.com> <1621862602-51782-2-git-send-email-fengchengwen@huawei.com> <5907391.mv1e21vPBl@thomas> From: fengchengwen Message-ID: <616fa425-6bb9-54cc-2493-e1963afe0a27@huawei.com> Date: Mon, 21 Jun 2021 08:52:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.40.190.165] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v8 1/2] config/arm: select most suitable -march for kunpeng soc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Thomas Another patch '[dpdk-dev] [PATCH v8 2/2] net/hns3: refactor SVE code compile method' has nothing to do with this patch (they're just in the same patchset) and has been reviewed by ARM guys. So please review it, thanks. On 2021/6/18 7:33, Honnappa Nagarahalli wrote: > > >> >> 24/05/2021 15:23, Chengwen Feng: >>> Currently, the soc_kunpeng930 declares '-march=armv8.2-a+crypto+sve', >>> but some compiler doesn't recognize the march because it doesn't >>> support sve. >>> >>> To solve this bug we use the following scheme: >>> 1. Define 'march_base' tuple which defines support march, it should >>> arrange from lower to higher. >>> e.g. 'march_base': ['-march=armv8.1-a', '-march=armv8.2-a'] 2. Define >>> 'march_feature' tuple which defines support feature. >>> e.g. 'march_feature': ['crypto', 'sve'] >>> Note: If user defined 'march_feature', it also needs to define a valid >>> 'march_base' because 'march_feature' depends on 'march_base' when >>> checking validity. >>> 3. Select the most suitable march+feature combination based on >>> 'march_base' and 'march_feature' tuples. >>> 4. Use the selected march+feature combination as the default >>> machine_args. >>> >>> Fixes: 7cf32a22b240 ("config/arm: add Hisilicon kunpeng") >>> >>> Signed-off-by: Chengwen Feng >> >> This patch is still not accepted. >> Arm maintainers, what is missing? >> Is it rejected? > Juraj is working on a more generalized solution. Not sure how it will turn out. It would be good to wait. > >> >> >> > > > . >