From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A685A1D7 for ; Wed, 20 Dec 2017 02:53:51 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2017 17:53:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,429,1508828400"; d="scan'208";a="13218531" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.69]) ([10.241.225.69]) by FMSMGA003.fm.intel.com with ESMTP; 19 Dec 2017 17:53:50 -0800 To: Stephen Hemminger , dev@dpdk.org References: <20171219063840.18981-1-stephen@networkplumber.org> <20171219063840.18981-2-stephen@networkplumber.org> From: Ferruh Yigit Message-ID: <6170a4ed-87ff-c750-f3f3-a38e192e6698@intel.com> Date: Tue, 19 Dec 2017 17:53:50 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171219063840.18981-2-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 01/11] avp: implement dynamic logging X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Dec 2017 01:53:52 -0000 On 12/18/2017 10:38 PM, Stephen Hemminger wrote: > All PMD should be using dynamic log levels. > > Signed-off-by: Stephen Hemminger > --- > config/common_base | 1 - > drivers/net/avp/avp_ethdev.c | 10 ++++++++++ > drivers/net/avp/avp_logs.h | 9 ++++----- > 3 files changed, 14 insertions(+), 6 deletions(-) > > diff --git a/config/common_base b/config/common_base > index e74febef4848..f775ec96184c 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -441,7 +441,6 @@ CONFIG_RTE_LIBRTE_ARK_DEBUG_TRACE=n > CONFIG_RTE_LIBRTE_AVP_PMD=n > CONFIG_RTE_LIBRTE_AVP_DEBUG_RX=n > CONFIG_RTE_LIBRTE_AVP_DEBUG_TX=n > -CONFIG_RTE_LIBRTE_AVP_DEBUG_DRIVER=y > CONFIG_RTE_LIBRTE_AVP_DEBUG_BUFFERS=n > > # > diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c > index 9b342bfa3ae8..deb6f355d3ef 100644 > --- a/drivers/net/avp/avp_ethdev.c > +++ b/drivers/net/avp/avp_ethdev.c > @@ -60,6 +60,7 @@ > > #include "avp_logs.h" > > +int avp_logtype_driver; > > static int avp_dev_create(struct rte_pci_device *pci_dev, > struct rte_eth_dev *eth_dev); > @@ -2312,3 +2313,12 @@ avp_dev_stats_reset(struct rte_eth_dev *eth_dev) > > RTE_PMD_REGISTER_PCI(net_avp, rte_avp_pmd); > RTE_PMD_REGISTER_PCI_TABLE(net_avp, pci_id_avp_map); > + > +RTE_INIT(avp_init_log); > +static void > +avp_init_log(void) > +{ > + avp_logtype_driver = rte_log_register("pmd.avp.driver"); > + if (avp_logtype_driver >= 0) > + rte_log_set_level(avp_logtype_driver, RTE_LOG_NOTICE); > +} This can be done later as well but what do you think creating a macro [1], so that driver part can become just: PMD_INIT_LOG(avp, init, NOTICE); [1] something like: #define INIT_LOG_VAR_NAME(pmd, type) logtype_ ## pmd ## _ ## type #define INIT_LOG_FUNC_NAME(pmd, type) log_ ## pmd ## _ ## type #define PMD_INIT_LOG(pmd, type, level) \ int INIT_LOG_VAR_NAME(pmd, type); \ RTE_INIT(INIT_LOG_FUNC_NAME(pmd, type)); \ static void INIT_LOG_FUNC_NAME(pmd, type)(void) \ { \ INIT_LOG_VAR_NAME(pmd, type) = rte_log_register("pmd." RTE_STR(pmd) "." RTE_STR(type)); \ if (INIT_LOG_VAR_NAME(pmd, type) > 0) \ rte_log_set_level(INIT_LOG_VAR_NAME(pmd, type), RTE_LOG_##level); \ }