From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED51443750; Thu, 21 Dec 2023 14:46:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B33D040395; Thu, 21 Dec 2023 14:46:44 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id EACCC402BD for ; Thu, 21 Dec 2023 14:46:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703166403; x=1734702403; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=WRR2Yt2FGEZS9XTQeQq06kxmSZSZJA2xl/vzzkhTfnE=; b=e19ugf+ye7pCdSeQqUTl73ftSB/XtSHlgTQg0tDJkfQm9MygXsPfZ60e pdwipbTmW72nrZlBuLEgsEuLLAqE4AL213ujYmZDgQZXJwBNtxKnkOs7n DubSzY44D2mdcf76HFirJkb1ZAnrF6ZHeElg9swAYDXoyog3OCmuToSb5 rFMu1Wjc2N1YfS5ycheRnMkep8vFaWVbBSBfC1hqfThAfnr35dNiyQRjq sBV+FbHKQeCzht7bWUsW6pEOEwtkyP5A3S9G93Tjw7KrKyWNX4G8hOXAm Yry0Mupxh70D+R0FusSVftfjdysM0XXpgsZle8YbGEjpUkvm7QSyw2fxi g==; X-IronPort-AV: E=McAfee;i="6600,9927,10930"; a="2809803" X-IronPort-AV: E=Sophos;i="6.04,293,1695711600"; d="scan'208";a="2809803" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Dec 2023 05:46:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10930"; a="867314799" X-IronPort-AV: E=Sophos;i="6.04,293,1695711600"; d="scan'208";a="867314799" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by FMSMGA003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Dec 2023 05:46:41 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 21 Dec 2023 05:46:40 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 21 Dec 2023 05:46:40 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 21 Dec 2023 05:46:40 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N5JfTbopiwdpOaVdJTnI95gZkA08UueAMuo8Q4Kiq4EihiVI3ggJ9mZrGLVc6jaeQ14zdeS/KvpfHINMp2UO3Q6qBwi1+ffk46N/IAR+/ARqbcRfTS/O940hmiLg14u6ek/AuFVrSyXU5wkXI920E6XCtGA8RZOikUwZoE3pQbK5+jBx9suG0o2Ff7TKDh7HVULNLvZZJh5DYc9wcVe2ccjF95Yb9CJ077Zm1DiD9PrtaeJAastK7z5LwXzadZTCnO/uPHMVbXgzfOG7w98L/m7Fn490kvldvybsRJrhygRR5o/w+T9ykyh09wDHr2A1kx/znF7QZtfLsJAj8aCnZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sc/jl4OvgkQYZGn7Bjrb6FfY1j1S8NQXUR67I3TkrQY=; b=HaiAOyP0MMUr94oYnTWNXbA84Nhd2uhmibzKRn5iKLu2iFU8nz/uk8Mh9d6qQJ86FeQ58hmMYlBqKv4tL/N0r5NilkX/s+kt+aWEef0F0d+7nxpi+5gkdke9B2N0aYTyYx9XhIxogtUgDo4Oqpqn2v/VL6AE0X8P43oN1jJ6R4FCYVdgrdEBD39FjE0ixeoiAnmcrawzT1nxABElJu0WmUXPK8UUO9BO6RrXhQ/BBqM/5/RnMX1JLiFdgWgAMpfprJB0YlCefJwQiGbuuvv3rKlgz/1dGM7RCp17yo1yDs2gxQz8SkF5dE0el2c+6fKKgX9rRS5/XGHBrz//Kx56mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SN7PR11MB6876.namprd11.prod.outlook.com (2603:10b6:806:2a7::13) by CH3PR11MB7940.namprd11.prod.outlook.com (2603:10b6:610:130::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.18; Thu, 21 Dec 2023 13:46:34 +0000 Received: from SN7PR11MB6876.namprd11.prod.outlook.com ([fe80::2778:47:71ed:6969]) by SN7PR11MB6876.namprd11.prod.outlook.com ([fe80::2778:47:71ed:6969%5]) with mapi id 15.20.7113.016; Thu, 21 Dec 2023 13:46:33 +0000 Message-ID: <6174a29e-8182-4465-8872-b441221b815f@intel.com> Date: Thu, 21 Dec 2023 13:46:29 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] doc: updated incorrect value for IP frag max fragments To: Thomas Monjalon CC: , Bruce Richardson , "Konstantin Ananyev" References: <20231221113242.3351356-1-euan.bourke@intel.com> <3099751.jZfb76A358@thomas> Content-Language: en-US From: "Bourke, Euan" In-Reply-To: <3099751.jZfb76A358@thomas> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DUZPR01CA0069.eurprd01.prod.exchangelabs.com (2603:10a6:10:3c2::12) To SN7PR11MB6876.namprd11.prod.outlook.com (2603:10b6:806:2a7::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN7PR11MB6876:EE_|CH3PR11MB7940:EE_ X-MS-Office365-Filtering-Correlation-Id: 93203689-3fdc-4c2a-69c4-08dc022b3e55 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OevMnTYwVfasPxW4a1R0VIlXGFB1LsfKFE1aKSECFcN5uEQKqgq2DJJcvU4+mEYDKBEN8jBHz0BIH2jOvlRas/vBRgVoj/Ng0/9W6QS6qeMrQZe0QKhRghHSoPKNKq6Qq24hEttiuvffzNB4aTx9ETLWZFZYC9AnpwsnBHQoX/YSmUg69KWcFrNgQ+MtEkOZQnhA/SzWEGgwa3xB9kqOWMMe9+7q2fewTGegKAnt6qLKRP+399lV2HI0PZ1IB5RsXuuhXfsH69NJVP5EFxcKehoRsj/3Bbou+cNtm2WRe7Kf6a1ZVJVMHAWi+nlJkkIjOMPhH9fOY0FWJfADNWvuw9OmmcqfzFVkap8G0zBkQ5JlKxtV/cujZlTtRAq4sb4BRY2v5ORtBQp9j7tpCY1qTl3Jg9iw9QGsdR/jUbDwbgBOfWmO1p2n3GOs9pjD7Pgy7camXBrd4ZBgzageEzNT/IDc8rpL/4VmOk5KGQWzmtIyLokJWa0LJne1qs9H5lVki2JUJxM//ZBSnGgm1OW7hW+wyd1n5EbJk10J/IZ7LeyVGrTEnqilNADLLL4enLaT2dm2kl5kBTcvOmhovtmlFsDcyL3sr/4UHGkNNYTJ8HClu13uTZ81aabZz+1iYZQgC7U0kEmAt6FCYDkP5wnVUw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB6876.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(39860400002)(366004)(346002)(396003)(136003)(230922051799003)(451199024)(186009)(64100799003)(1800799012)(478600001)(38100700002)(66476007)(6916009)(66946007)(316002)(31696002)(36756003)(66556008)(6512007)(6666004)(86362001)(41300700001)(82960400001)(6506007)(53546011)(26005)(4326008)(5660300002)(8936002)(2616005)(4744005)(54906003)(2906002)(8676002)(31686004)(6486002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZnFYU1lrMTdlWlNUM09TTFVLZFlkZzdjZnFQTDJtTklQbGFXdWtONkRBRVN3?= =?utf-8?B?QXNCdjV3ay9RbURHdGl3L2ZpNWI4Z1FFKytSak9jSGt3d3lnemtpNHVSRkd0?= =?utf-8?B?TUpGRS91eit6V2RUbVN3UFBSZlRPUDBpNkFhUUg2NzAreXp2R2o4eW5jQ2Ir?= =?utf-8?B?K0R3K21qNm8wbXV2S2Z3YnllTGt0NHpZNkpnWEZrN1RGaUhOeDhDVnpRNmRl?= =?utf-8?B?NHF1Nm5Ja1UvNUlBbmNlVWoxakN6VmlwZENJUnBWVjJOZEJFUXUzdkhiNjRx?= =?utf-8?B?c1YzK2cyZmgyN0lQK2JUSlJHbEF5NzZhd0JmODBHaENpS3o4a29aMEw3eXdD?= =?utf-8?B?OVRONEVmWmF0K21id25wd2thSDNCNUpYeWZtaVJnM2toMld4clcrWko2K050?= =?utf-8?B?VEd0bjZ2MVBDVkVqci9yZ094QmRlUXowU3dGRkszK1AvYnhFL1M2ZExJRGtF?= =?utf-8?B?YTlKMWhBenIzUUY4Y1pNcjRvMkNDbFBnODVtUG5URTNIc0sveWx4dnk0WThJ?= =?utf-8?B?SzlFLzdxU0JtMGFKVEZyT0JLYkprOEdFZkQ5aGVtVm9HeU1BN0FINTd2dGF0?= =?utf-8?B?ZHZvUllGNExJcER5N05qU3kyTFFxL25mRkVKWktacnVFTnAwKzc5cW1kTERm?= =?utf-8?B?VjliU0R0SUtCbmRCc1lkMmJ5T0xVcnpFdVUwZllSbFBqYkxUV3QrVTlmL0RJ?= =?utf-8?B?T3NOR25iUHdSdVliVnFNemtua3lYNkxqOEpDYytkakZCb0c3cWhPQW4zZlJ4?= =?utf-8?B?RkQvVGhDeFR2c2diR0pIQ0dJUjFEOFZwSm9ieG9RSmpKNDl4RFlhaENGY0Qv?= =?utf-8?B?ai9xREFNMjJZekZMZVNoTnNYYk9pZjdpdkFpZW5DS2ZWOHE5ZDJJYTg2clgv?= =?utf-8?B?MExhS09PSmVidUptNnY0TlZlQlE2QTJUUjNjMmVOWURvKzJxdEd4N2QwQ0Mw?= =?utf-8?B?RjhZZkEwZ3IrMCt1ZnM4a0pDMXphb25lK0RXb0ZETW5Bd2l5azRPSFVnVWE2?= =?utf-8?B?UDJHZUJiYklvRnJnTTk3aTZJRktRSE5JYmhZVXpxZDgxbjE5cjBodzJ1RDZW?= =?utf-8?B?VDFieUx2NGhLN2JpZHBUeDBKSmx2MmRiYXExVnArR2tTdE5LbnB5c3BvbU9S?= =?utf-8?B?ZEhjTzJWaTRNYzgvNFNnTm9IWFRuNTZZNXMvZTcwUHNGZ2ZiRVhWL0tETkVy?= =?utf-8?B?d1dxbHBrQjYwanJwcEVyeTRCNmlDUE5SekcwQngvNlNhb0JCRmZnR3N5aWNH?= =?utf-8?B?bXhhNVB5V2p5azVIam0wcEZsU0IxRmJIMDZSYTJZb0sxY3BBMEFJcS9qRWZw?= =?utf-8?B?VThIN3RhK28xd2h4ZGZZVENKa0U4MlBWU3NaVDBiVHpRT3JuYVNnT2ZMNnly?= =?utf-8?B?VHNnZkdoZUFtdmxsRHpyYitpVXFwd2N6M0V0RFNzcXh5VExOQTlCTFRZZStB?= =?utf-8?B?UGpveGZ3L2Q1b3Q2MEEvazJBUnhnbFhvcjBBL3pUNk0zd01DbDMzVzB3a21i?= =?utf-8?B?dm8yVlpzNjhWRDRWODJGUmx3N3IwMUtDZHVUZkhBKytOOXowb05ZK2JONTdR?= =?utf-8?B?Qkp0Y1pncDJUbEF2RTRNdzZvMk5mWnNiT1plUnh6bk44VUJVL0x6NDNtYXkr?= =?utf-8?B?ZGYzUTJMSFAxeVEvVHhJYmkvQjdqeTNCcHVWR1pkNC9mUGUwb3JlK1BBVzZG?= =?utf-8?B?bG5BbzVwVS9nRHRPZ0xrSVl1azJzWW1CMDlEb2hUbWZBVCsvQ0J6S0M4K2J2?= =?utf-8?B?emxiSW1LT2x6Y0ZKcHBSdENXblljR3I0TWNZVVFaSENzV2pIZjljWCswdDJZ?= =?utf-8?B?L0FKNzU4ZngvN0pNaDNHL3U3Vkw3ekNnaWxadkZvc0F0eS9EY0pQd1ZRZ2lk?= =?utf-8?B?OHRpMUR0UGtrdHF5VXdtUmhNK0ZiZXFiUWJpZkNKdXBtd29UKzJkWjRIeGFv?= =?utf-8?B?RnkvbXBGbmx0YnViQklpRGUxWDRNVnRxSE1sWXhqQ1ZlQU1VbjVpZUNSTTg0?= =?utf-8?B?VC9CRGpBVGlLNFZpUWJ2MzUyWEpaT3JhZmtCNFNHeDdONm9BcExxcG9Wa29l?= =?utf-8?B?UDREeWpGeXBIRGpYbHpVTkRpQVUvbHAzSFZxdjQvOXpoMzJpR1ZnREN2cVpi?= =?utf-8?B?czlDbWRMd0M0Q05UdGg4MGtCSjFrTnZ2Z2FSQW1pQ3FwQi8vZWZTUEJKL0VN?= =?utf-8?B?VXc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 93203689-3fdc-4c2a-69c4-08dc022b3e55 X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB6876.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2023 13:46:33.5071 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C0FSBUdIqtUhmrHUBKatMpZdtlZaxNl2OsA2FuRC2cdptryGRw276uCdPkw0YMyVeDoyI8NZ4bp7ao4kdCRQWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7940 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 21/12/2023 11:41, Thomas Monjalon wrote: > 21/12/2023 12:32, Euan Bourke: >> -/* ip_fragmentation defines */ >> +/* ip_fragmentation defines 8< */ >> #define RTE_LIBRTE_IP_FRAG_MAX_FRAG 8 >> +/* >8 End of ip_fragmentation defines */ > [...] >> +.. literalinclude:: ../../../config/rte_config.h >> + :start-after: ip_fragmentation defines 8< >> + :end-before: >8 End of ip_fragmentation defines > > In v1 I asked to use "start-at". You didn't reply. > It is more convenient for a one-line include. > Don't you agree? > > Apologies, as I was updating the name of the declare in the next patch, I thought this way would be better, will use "start-at" in next version.