From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA69744155; Tue, 4 Jun 2024 17:04:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B384940E68; Tue, 4 Jun 2024 17:04:06 +0200 (CEST) Received: from fhigh1-smtp.messagingengine.com (fhigh1-smtp.messagingengine.com [103.168.172.152]) by mails.dpdk.org (Postfix) with ESMTP id 7C9B54026E for ; Tue, 4 Jun 2024 17:04:05 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfhigh.nyi.internal (Postfix) with ESMTP id E32F211400FF; Tue, 4 Jun 2024 11:04:04 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 04 Jun 2024 11:04:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1717513444; x=1717599844; bh=6R3eUv/Ok4xW6Nbs/sap7x/yhuXu4L+3H09rT6dAdOA=; b= B99l0voiqHJnC4c0eVoQm3YxLZGxmAeVil8iecJWCZjk7mSyFYklpNrxwzY0y/Jg x3N98v5v5/g4negmjYF1Cut2T+gFJHcdhiuuuZ6AcyVuVIr8kOYgC1ICnJ8xqNs5 +iWK4Ji9JdP3yiDUliHg7X+DSCpgJsC+u6tfSa6nNtCjZiFYXHHaZiuVtXAbXYQz Uh24REpf2Cwb7wpk7iX5C8Rzlqyk6jnfglhL9hlf/47HS4JgDcaXBf0tr+1O1dHK 5H28877CNoLko0LtPrhBdl1uWlAnPsPyYdG8KcqYywQ05g5trI+M56Mmh5OexGEr 45edAT7kH+dH47smXJiOPg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1717513444; x= 1717599844; bh=6R3eUv/Ok4xW6Nbs/sap7x/yhuXu4L+3H09rT6dAdOA=; b=J DdMEwz9RV/nICXXXW3YE4pg0ova3Y22Ek6hPTPlC7Q/pfWO66NFCO/fS9HuuM6Iq st9pj1Q3JlSYt3yXELQ1Xpl9/f1vYsTOARXiU/zEegD075yrWDHQprG5uCyhTkfI ZihIRORWc5IsMu4JkP68giddH8aiFrwZ6VgWE+Sa2lJNg5tqKmlFGnl9vlSSqPHD R8y39RRQ9hn1KWQQ+GxGFPVhzGnT2lBD1tu1Z4rg+SOx1alJnolJ2E68WiU/pLmP EKEkj68yW46d7luerwIft8+GKtVf040n14wyRUuPy1GPpvX9adIo/u0NfhZFWRcr gs9uRniOqPXge7DfqD4UQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdelgedgkedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeekueevjeffjeegtdeggeek gfdvuefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 4 Jun 2024 11:04:02 -0400 (EDT) From: Thomas Monjalon To: Rongwei Liu Cc: dev@dpdk.org, matan@nvidia.com, viacheslavo@nvidia.com, orika@nvidia.com, suanmingm@nvidia.com, Dariusz Sosnowski , Aman Singh , Yuying Zhang , Ferruh Yigit , Andrew Rybchenko Subject: Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved field Date: Tue, 04 Jun 2024 17:03:56 +0200 Message-ID: <6180616.2l3rmUXbR5@thomas> In-Reply-To: <20240604123840.432044-3-rongweil@nvidia.com> References: <14937324.O6BkTfRZtg@thomas> <20240604123840.432044-1-rongweil@nvidia.com> <20240604123840.432044-3-rongweil@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 04/06/2024 14:38, Rongwei Liu: > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -1006,6 +1006,7 @@ static const char *const flow_field_ids[] = { > "ipv6_flow_label", "ipv6_traffic_class", > "esp_spi", "esp_seq_num", "esp_proto", > "random", > + "vxlan_last_rsvd", > NULL > }; How vxlan_last_rsvd is linked to RTE_FLOW_FIELD_VXLAN_RSVD1 in testpmd? Just because it is the same order? > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -2428,6 +2428,7 @@ enum rte_flow_field_id { > RTE_FLOW_FIELD_ESP_SEQ_NUM, /**< ESP Sequence Number. */ > RTE_FLOW_FIELD_ESP_PROTO, /**< ESP next protocol value. */ > RTE_FLOW_FIELD_RANDOM, /**< Random value. */ > + RTE_FLOW_FIELD_VXLAN_RSVD1, /**< VXLAN last reserved byte. */ > }; I think we should use the same naming as in testpmd. What about RTE_FLOW_FIELD_VXLAN_LAST_RSVD?