From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF99B45AF0; Wed, 9 Oct 2024 11:17:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CFF4140F16; Wed, 9 Oct 2024 11:17:20 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4B1E140EE5 for ; Wed, 9 Oct 2024 11:17:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728465438; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PJg+DxRAg/YdKxMC+l18zx98VO3FxPLvinokQl3MvqU=; b=QVB9DvneyVXlQCBn63T9cB4CAuMbNKLMSditH45hwKFUlj2lSNAf718QBYXCIOhb70Co3C qQDKs0YXbtdhJ8lJQQrCqSDEcUnEaQMQS4JFVn/UwYAwZL9Z8NXjl1c4Vp00XZc3mK0cX8 r4qkE7f3GsglhdJ4p/Q66fysVXfzqIU= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-425-Ms6OHY5wNWG24b28AqzIiQ-1; Wed, 09 Oct 2024 05:17:15 -0400 X-MC-Unique: Ms6OHY5wNWG24b28AqzIiQ-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2fad58ddea1so48292011fa.2 for ; Wed, 09 Oct 2024 02:17:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728465434; x=1729070234; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PJg+DxRAg/YdKxMC+l18zx98VO3FxPLvinokQl3MvqU=; b=p8jtktzm6RMi8bgmetnkZKD+QkO20w8DSu7qPTm+pU8JzUNS1HI4+W9solmBro4b9q nwmcQBfqXuSqqoTIwb8ZyYJAPvT8Mnbk2x8FzEz4I050f/3seWAk2Wqw/+lqAFUD6fIJ mygDW2kogYUTJ0XCHlZzejuFX8UHyb88xA5hnZhEO3fNtd+L9Vkeh1zBNqZP0grBo9Sv O5IO9JwcsSLrDPcOVPJVns7JdLcl7RAqs9Is3URFZQamlxQxOV446fj7N0Z1LvP7vGSU Pp/KxLoHPBZ9//I276XuVdKSgm8eVFz7l2qu2ObI0G8wUQpV3mzn4wwnvZcHewsWQy4z kHHQ== X-Forwarded-Encrypted: i=1; AJvYcCUbrTLAFKXz50l6YFkSYa3WvYAxDEgCRAT9RA0wVkY3po4OwK1ArHTQ1zrMOWzR9UCAHKI=@dpdk.org X-Gm-Message-State: AOJu0Yx2FosZBzSe8H7+Zey0UvDI8aQCLuf1usadFlnWKrUBZjloJycj 1sfZ/C+s0C+See5Xbsd11bd5ODzZAcltMPKmzCxoFMI4otjoFMyki8/NW7KArv81JLzjfj/26oO u9aLzda6nbYWeGjg8B6spJ0MBgQ5cK+aIIouLktCV X-Received: by 2002:a05:651c:547:b0:2f7:6653:8053 with SMTP id 38308e7fff4ca-2fb1873d455mr14652581fa.18.1728465433732; Wed, 09 Oct 2024 02:17:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHt8sDarciir4+D5q/dg0MHYOStpM9BKkPpGCcyFQwyMkUaJCN2YuAgTpbP/+v3/8pUnTFKJg== X-Received: by 2002:a05:651c:547:b0:2f7:6653:8053 with SMTP id 38308e7fff4ca-2fb1873d455mr14652271fa.18.1728465433222; Wed, 09 Oct 2024 02:17:13 -0700 (PDT) Received: from [192.168.0.36] ([78.17.54.228]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9958647caasm366926866b.213.2024.10.09.02.17.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Oct 2024 02:17:12 -0700 (PDT) Message-ID: <6183e492-7c00-4ca0-822f-62a30fc4c90e@redhat.com> Date: Wed, 9 Oct 2024 10:17:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] devtools: deduplicate function to mark fixes To: Thomas Monjalon , dev@dpdk.org References: <20230418140726.1472209-1-thomas@monjalon.net> <20230418140726.1472209-3-thomas@monjalon.net> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= In-Reply-To: <20230418140726.1472209-3-thomas@monjalon.net> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 18/04/2023 15:07, Thomas Monjalon wrote: > In the commit 8070d8fecb4e ("devtools: add fixes flag to commit listing") > the function to mark a commit for "stable" was duplicated for "Fixes:" mark. > > The code is a bit smaller by using a single function for both marks. > > Signed-off-by: Thomas Monjalon > --- > devtools/git-log-fixes.sh | 22 ++++++---------------- > 1 file changed, 6 insertions(+), 16 deletions(-) > > diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh > index 4690dd4545..005e46f715 100755 > --- a/devtools/git-log-fixes.sh > +++ b/devtools/git-log-fixes.sh > @@ -84,31 +84,21 @@ origin_version () # ... > done | sort -uV | head -n1 > } > > -# print a marker for stable tag presence > -stable_tag () # > +# print a marker for pattern presence in the commit message > +git_log_mark () # > { > - if git log --format='%b' -1 $1 | grep -qi '^Cc: *stable@dpdk.org' ; then > - echo 'S' > + if git log --format='%b' -1 $1 | grep -qi "$2" ; then > + echo "$3" > else > echo '-' > fi > } > > -# print a marker for fixes tag presence > -fixes_tag () # > -{ > - if git log --format='%b' -1 $1 | grep -qi '^Fixes: *' ; then > - echo 'F' > - else > - echo '-' > - fi > -} > - > git log --oneline --reverse $range | > while read id headline ; do > origins=$(origin_filter $id) > - stable=$(stable_tag $id) > - fixes=$(fixes_tag $id) > + stable=$(git_log_mark $id '^Cc: *stable@dpdk.org' 'S') > + fixes=$(git_log_mark $id '^Fixes:' 'F') > [ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || continue > version=$(commit_version $id) > if [ -n "$origins" ] ; then Acked-by: Kevin Traynor