Re: [dpdk-dev] [PATCH] examples/ip_reassembly: enable scatter mode for Mellanox PMDs

[Thinh Tran <thinhtr@linux.vnet.ibm.com>]

Hi Jerin,
would it be possible to add a command option such as '--enable-scatter' 
like testpmd does?
Thanks,
Thinh Tran
On 11/18/2019 12:30 PM, Jerin Jacob wrote:
> 
> 
> On Mon, 18 Nov, 2019, 11:49 pm Thinh Tran, <thinhtr@linux.vnet.ibm.com 
> <mailto:thinhtr@linux.vnet.ibm.com>> wrote:
> 
>     Simple change to enable scatter for Mellanox CX4/CX5 PMDs
>     to run this example
> 
>     Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com
>     <mailto:thinhtr@linux.vnet.ibm.com>>
>     ---
>       examples/ip_reassembly/main.c | 3 +++
>       1 file changed, 3 insertions(+)
> 
>     diff --git a/examples/ip_reassembly/main.c
>     b/examples/ip_reassembly/main.c
>     index d59e6d02f..f881b89d1 100644
>     --- a/examples/ip_reassembly/main.c
>     +++ b/examples/ip_reassembly/main.c
>     @@ -1109,6 +1109,9 @@ main(int argc, char **argv)
>                                      port_conf.rx_adv_conf.rss_conf.rss_hf,
>                                     
>     local_port_conf.rx_adv_conf.rss_conf.rss_hf);
>                      }
>     +               /* Mellanox PMDs needs scatter mode to be explicitly
>     enabled */
>     +               if (!strcmp(dev_info.driver_name, "net_mlx5"))
> 
> 
> No driver specific code in generic application. Please fix the driver 
> instead.
> 
>     +                       local_port_conf.rxmode.offloads |=
>     DEV_RX_OFFLOAD_SCATTER;
> 
>                      ret = rte_eth_dev_configure(portid, 1,
>     (uint16_t)n_tx_queue,
>                                                  &local_port_conf);
>     -- 
>     2.17.1
>