From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F5F7A04B3; Tue, 19 Nov 2019 00:03:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F0DDCB62; Tue, 19 Nov 2019 00:03:01 +0100 (CET) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by dpdk.org (Postfix) with ESMTP id 7A1CE9E4 for ; Tue, 19 Nov 2019 00:03:00 +0100 (CET) Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xAIMwgRY171949 for ; Mon, 18 Nov 2019 18:02:53 -0500 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 2wact65veu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 18 Nov 2019 18:02:53 -0500 Received: from m0127361.ppops.net (m0127361.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id xAIMxsWR175374 for ; Mon, 18 Nov 2019 18:02:52 -0500 Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0a-001b2d01.pphosted.com with ESMTP id 2wact65veh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Nov 2019 18:02:52 -0500 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id xAIMtDvZ002195; Mon, 18 Nov 2019 23:02:56 GMT Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by ppma01wdc.us.ibm.com with ESMTP id 2wa8r5xb9w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Nov 2019 23:02:56 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xAIN2pOL8847790 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 18 Nov 2019 23:02:52 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D69BD124052; Mon, 18 Nov 2019 23:02:51 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9CC5D124054; Mon, 18 Nov 2019 23:02:51 +0000 (GMT) Received: from [9.53.179.175] (unknown [9.53.179.175]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 18 Nov 2019 23:02:51 +0000 (GMT) To: Jerin Jacob Cc: dpdk-dev References: <20191118181833.541-1-thinhtr@linux.vnet.ibm.com> From: Thinh Tran Message-ID: <6185ed16-0327-4df7-d158-82811b4f907a@linux.vnet.ibm.com> Date: Mon, 18 Nov 2019 17:02:51 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-11-18_08:2019-11-15,2019-11-18 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 mlxlogscore=999 suspectscore=0 adultscore=0 mlxscore=0 bulkscore=0 clxscore=1015 spamscore=0 malwarescore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-1911180197 Subject: Re: [dpdk-dev] [PATCH] examples/ip_reassembly: enable scatter mode for Mellanox PMDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Jerin, would it be possible to add a command option such as '--enable-scatter' like testpmd does? Thanks, Thinh Tran On 11/18/2019 12:30 PM, Jerin Jacob wrote: > > > On Mon, 18 Nov, 2019, 11:49 pm Thinh Tran, > wrote: > > Simple change to enable scatter for Mellanox CX4/CX5 PMDs > to run this example > > Signed-off-by: Thinh Tran > > --- >  examples/ip_reassembly/main.c | 3 +++ >  1 file changed, 3 insertions(+) > > diff --git a/examples/ip_reassembly/main.c > b/examples/ip_reassembly/main.c > index d59e6d02f..f881b89d1 100644 > --- a/examples/ip_reassembly/main.c > +++ b/examples/ip_reassembly/main.c > @@ -1109,6 +1109,9 @@ main(int argc, char **argv) >                                 port_conf.rx_adv_conf.rss_conf.rss_hf, > > local_port_conf.rx_adv_conf.rss_conf.rss_hf); >                 } > +               /* Mellanox PMDs needs scatter mode to be explicitly > enabled */ > +               if (!strcmp(dev_info.driver_name, "net_mlx5")) > > > No driver specific code in generic application. Please fix the driver > instead. > > +                       local_port_conf.rxmode.offloads |= > DEV_RX_OFFLOAD_SCATTER; > >                 ret = rte_eth_dev_configure(portid, 1, > (uint16_t)n_tx_queue, >                                             &local_port_conf); > -- > 2.17.1 >