From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 1BB021B2C7 for ; Wed, 8 Nov 2017 02:44:42 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5C9F820C78; Tue, 7 Nov 2017 20:44:41 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 07 Nov 2017 20:44:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=CltQ7MY6rTGBUtnDvXUv7cmsEK Lnrh8WX49To7JlKxk=; b=Ez6P0BbeN6Pz0wO3FxRNhailAtD5eCuP+RxvUdAC67 +SO+hOjPzrFTd4yDKcqW811M2+94KbPI4jTBOtjVzFQKR4KgG5L4+ZOUeKXT6079 6z+vZsZl8O+Wa4Wwp/hClfcdLd/QP/RNq30uvL91I1yyIfHvlKjxoi1Q9ojFQMI4 k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=CltQ7M Y6rTGBUtnDvXUv7cmsEKLnrh8WX49To7JlKxk=; b=CO8tPKtMPpQ1t+XF1D+e0L tMS34Jtr7hucS86rfGFhj3BoiEZRPtpojnTCeGLs4Y2yuFVCuxm0CxksNdOFsdxw UG+wPCRYC2mdblp7HMPkDVY7b/Y0ad+myKVF9OvbEIpk5sUDXIkzKm+ZY/8cRMHh XB6eHXQ6wUavrrJII5DbkHQRWqevoRPWtDi+Q59ZJHwHHTSWhHBXCOfHjHd7klPH 1baagXEnhF+tmadCp3LmkPhmKa0sWYJfQbuAD8gzpVHNleC59lXmO+PPgDGdMgYc O8gAb+fI2tsGku4h1JWRF3AkOmfuFFdfV3QAa7CZpwpr+u/G5lefSuViHtisSW/Q == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1CEB97F8F6; Tue, 7 Nov 2017 20:44:41 -0500 (EST) From: Thomas Monjalon To: "Patil, Harish" Cc: "ferruh.yigit@intel.com" , dev@dpdk.org, Dept-Eng DPDK Dev , "Mody, Rasesh" Date: Wed, 08 Nov 2017 02:44:40 +0100 Message-ID: <6189711.sNO2pZEAvp@xps> In-Reply-To: References: <1510043665-8160-1-git-send-email-rasesh.mody@cavium.com> <3022250.CEjPREgbVS@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/8] net/qede: fix to disable per-VF Tx switching feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Nov 2017 01:44:42 -0000 08/11/2017 02:34, Patil, Harish: > >> --- a/config/common_base > >> +++ b/config/common_base > >> +CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH=n > > > >We should remove all compile-time options because they cannot be used > >when DPDK is pre-packaged. > >That's why the rule is "NO NEW COMPILE TIME OPTION". > > > >After discussion with Ferruh, this patch is accepted as a hotfix. > >But this option is expected to be removed quickly. > >I've sent a patch to remove this option in 18.02: > > http://dpdk.org/ml/archives/dev/2017-November/081488.html > >It gives you some time to supersede my patch by introducing a > >run-time driver option. > > > >Thanks > > Hi Thomas, > Sure, thanks, we will address before 18.02-rc1. > Do you have any example on how to add a run-time driver option? > Does it mean to introduce some change in ethdev? It is done by parsing devargs with rte_kvargs. Examples: http://dpdk.org/commit/447e0d379 http://dpdk.org/commit/001a520e4 http://dpdk.org/commit/7958b1310