From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5AE00A0C47; Wed, 13 Oct 2021 19:17:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 43FB241140; Wed, 13 Oct 2021 19:17:04 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 9FBD0410F0 for ; Wed, 13 Oct 2021 19:17:02 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10136"; a="214635795" X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="214635795" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 10:16:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="659614060" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga005.jf.intel.com with ESMTP; 13 Oct 2021 10:16:51 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 10:16:51 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 13 Oct 2021 10:16:50 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.49) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 13 Oct 2021 10:16:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fVwTfvxz+XBnuzDg4ilDb6MwMUT406VEsViJ4wkcRRyE4BYYFQnu8ntlhFmPl5GQOIk+7ZgQgTMQ7ZsHJdcdeL2pV/yhagyCesalnq8MIZIrR0a3HnUq8TH9HNEimoeMQH+ysOcvqxetYLxtlUuKBBShhVc4ob7oNlyGRfFjYGrISHm6e2Gd5l3s+erkG/IC1UiDMKlDjyREtj+FQju6tAy7cvG4uZWsepRRmVILsP28flSI85eUVjvuB29nDXSiGkYatWEI0iemvcrn1wMgKpo3mAQKPXwNeLrXORAHjpUFfN2jyk9l81XfOVQtTdmoy1miRMMi7S98VrlNBLz6SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DNmNoiz4eCJUjNGaTpZLY21Pb3rGIJ+sThCB3GSpGA8=; b=Qm0EdTbTtr8NgBGTlwysFg+NIyzNugTlrgGnL55b6R5hKySzOe1WyCcuzl9YuunHK2ImZ+817n/XpNSpTa6W8mAD4dtE+fVj98+vbQUc4pTS9tS7fu/vw6f/igABSyDsv5meMVJfQ0PAF+KdfqK73UmQ84e35TToIDNRtXUKq1fvg0HCuukDz8Ps1Y4a7IZfycPh31MapLzltrB2lvBlqN9JvC/92MQ6s9l8TmsHAfUSWqULrmGgJjSu4JI4AKgEUVFa1HpD1Tg/D65fTdZlgQI+ZG9yHb7NrfM+YqlxK3vE+CrPsI+QoY4SdQImsftVZQivFESeNesbnHBOznCDLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DNmNoiz4eCJUjNGaTpZLY21Pb3rGIJ+sThCB3GSpGA8=; b=d6TNhqVZ+wvcyrrvOsHxoFOMOWSO+IJdj2628HtyPUkZ9wScsNWJrXz+PJ6wnJbTc2ecxBuwRJ+VtWK9c1zRGveAe8m/DDYcwDufrA2HJuUJHzRFyILjbpwGp1We4qQsBtUF9Bq0nE+4tdnqWsduXgg5NWmXYe7dGiyBvwAXUxM= Authentication-Results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4885.namprd11.prod.outlook.com (2603:10b6:510:35::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14; Wed, 13 Oct 2021 17:16:49 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021 17:16:49 +0000 Message-ID: <619310e9-8d50-bacc-939e-ae877c286e39@intel.com> Date: Wed, 13 Oct 2021 18:16:42 +0100 Content-Language: en-US To: Andrew Rybchenko , CC: Raslan Darawsheh References: <20211013152027.2480175-1-ferruh.yigit@intel.com> <20211013163219.1933273-1-andrew.rybchenko@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211013163219.1933273-1-andrew.rybchenko@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR0202CA0047.eurprd02.prod.outlook.com (2603:10a6:4:a5::33) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0202CA0047.eurprd02.prod.outlook.com (2603:10a6:4:a5::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend Transport; Wed, 13 Oct 2021 17:16:48 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 968c5310-605d-411b-1789-08d98e6d3e09 X-MS-TrafficTypeDiagnostic: PH0PR11MB4885: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:88; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 84Af+fchqyk5pvdaihZZiduvCwKo6RXrKuPxDjV8bw2lx8T++79Qi9AS0lgAQ1heyFaRE9gBpItqrPATU/EwlJftztVaargNjfSApvzQpEEw4YAPYAHN2pflozAn3+tVaY2XDrctL+t1soXoiWxCIaCxbIesLpspV2yRgmCyh6vP7K+TXVf+6xiKdH6nRafkaywaZnsuEVeMR9Y7yhr1Wq9iU0IkhxT4WUh2IbrQTIAwXiLxMSzJACDZ6p8URVxHFrvQ0SQHITDP/DujdnvhXPEeVhnLtnkWXeSRKxVqP14jVysw1602g5naIzW3Pv/gLJZguH031jhZYZaa0xZYxLEObwR1+kSpMp9fvHbyO77+xkY96WhGRx7aAC2E7JksRr2r3kZwyxgkZf8KR3fZKEQiEir2/JEg3eK0jq6Pyd3qNDLHwB9wRcQ8NKkOi5/Wdy5OpCWFn/cQ5DQQEweiozZRro+Sjve1zTsTTZMnHmdOp6gWJFWf0+5Thk4A6npNfszISNkUciulaeHkDL33v6h6TSu5wCgugbzFCOZB/sqk094d53VujbkfR7Fxs4tp2kR1PxtAWGLs67feyspG13+Chs0PlMjR6osmumi43fL3om6Jg9auHy2UEvr3IMdiK5tL889trVsjkyKBcXFbHQvv6oeh47XOubhwSv6df4A+cZX36rNn5S4ATuh5GHdHEcF6Zzhfh2xlLu17UULsVQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(86362001)(508600001)(6486002)(36756003)(956004)(66476007)(2616005)(26005)(66946007)(316002)(16576012)(66556008)(186003)(8676002)(5660300002)(2906002)(4744005)(31696002)(38100700002)(4326008)(44832011)(8936002)(83380400001)(6666004)(53546011)(31686004)(82960400001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUh0M0cvQ2ErRFQ0QkErdDkxZEsySnh0RGJJSzExVU9MSVA3a2dGa3VreFNx?= =?utf-8?B?SkFsdEhXblFJWFppMXQ2YWNlZUxmOEllQmRtb1FzYVNuTCtHc0tKQmtacHMv?= =?utf-8?B?b1cyeitEbTZ1VUN1bzVnRk1OMmlQajJ6N3R1T1NZcnE4NnRmZG1zbVdMMXdK?= =?utf-8?B?UURxbitjQ0lCRUJLNWdLYlhVRHV3ZGowdnJ2eG1sOVEwOFFrSjM0SnB4UWFr?= =?utf-8?B?T1BYTEVIQUkzRi9hMmNzYU1ITVUySjB3SElXNS8yTktXOHRuYlgrak4vTHps?= =?utf-8?B?NzR2VVZoTnhtS2NaOVB5NzRNVlJuWUljWTZrRDZjNDNFWnM4QlN0eUs4d1Zu?= =?utf-8?B?cGw5M1BqRmp4aVhHRkkyQWpnajBzSUpGQ3pxa0FmSjBNMytMQUZEYlZ4cVNh?= =?utf-8?B?bkdZY1ZKWmQ1YXJxbFh5Q2xhNHEzWXcyV2FtZmlZWis0VHNJc0ZBcnM0ZEor?= =?utf-8?B?NER5K2dGMHgrZDFqK0NxZit6Vm5tZlFBTEJlMndncU01VXVFQUNUcU94SnFX?= =?utf-8?B?aHJVWmdsR0RQNjlESzNXN0xRaVNmbWtwWVZ5QXp2YXozeWhkekRvZ0J2U0RZ?= =?utf-8?B?WnZKbWtESEhmMmgvSmZhaTdkQzAvUEVuZ0s0ZzhYc3pXUy9xTkdTR0I3SXZn?= =?utf-8?B?Vk5GbVRwbDU0MFBsMWtZT2d5MnM3dE0xTG9CMUZ1N29nYytEQUNtd0p4WVNS?= =?utf-8?B?QjdMYmdXeGdvR3NCNHBnZEl5Wk5DZ0phL08vTkQ3TzFPS0tiMENnZFR5TFVR?= =?utf-8?B?YWtqWlZVdzdGMEl1VlhIZE5MSEFOQndyZnBwdjBOMjJjOEUzbVVZTFdBQWd5?= =?utf-8?B?aUl0WnlSMmhBeUZKYUl5WWV6RkpsZTN5bWRiMXFCMWRna0hseWNnQXVVMExj?= =?utf-8?B?Ynk2emxwS0M5ZzQzZjlhSjY2L1c4VlIyZkdJRnlmcnpydEtma2tBRjJiWWxr?= =?utf-8?B?M0VkOFAyMTZqMS9uclJuTE9UV0NIT1BnaGZDQjliR3piUm9WS0U0cHVpZk9D?= =?utf-8?B?dTNyTFJYTnVoaGg2ZTRwN1I5U29KVXlOaXZSSjVMRURnUkhDbUZUZk13Vnl2?= =?utf-8?B?aGlTeE5HVWZjOXFaRTNQeFZhd3hkUUFzOUlNK3NhMndvWmF5TU1Sd2tKQm82?= =?utf-8?B?VnZNaXZkSVNDREdQSEpxNUc0VnVVUkNvODRjdXlZZytReXRSZ0RCaVFnYzNU?= =?utf-8?B?NWY5YUVuQXlTMlViUDhqVkw0R0prZFlSRW1iV0Rua1ZzeTZWVTdUUGlkSWZG?= =?utf-8?B?V2FhbDJ0cCtNU2k1VjQ5Vk41dnBQL3NRczJaSzQxTWxMQno1cGFmMkc4Z2M1?= =?utf-8?B?VFo2aXZDWitYYmxNVEFKYjNzR0RqK0Rteis5MTNxU1Z5WVRUQjY4czVjbVd1?= =?utf-8?B?c0VrVEVNQkRrL0ExRERNTWRuc3VjTTJFeDZlbGd6SjM5WENjRjJvQXVxRjRH?= =?utf-8?B?NGFCbExrWlFmUWFmQ1IvekVPdElrWlZaYUJkbm01eXc4QjZ2RVU0NmNJejM2?= =?utf-8?B?bHYrZnR3aTdjdmN5ZURPWXJPUjVRcWszKzNXSEt6ZVd4VGVBSDhmZVpQQzdI?= =?utf-8?B?RXpqeHVTVkVIbDk0VDR3SjZjNHFkcC9aVDJMZEhQZkdkNTVkSUVrNVNPeEZO?= =?utf-8?B?UElpdmo5Wmh4WlNLdkVkalNGb2FNZ0lBWEpzSjJUQ2N1YlliNTg1VVhTeWZN?= =?utf-8?B?czhYODZhK3JBUmtnVXgwcVJaTmlKaDB4aGt6clJmM0hlclhVb2ZQSWcvdS9Y?= =?utf-8?Q?TnA6wE6Y5djt1QF33sCUN6WymXXSa0GK9V46cy1?= X-MS-Exchange-CrossTenant-Network-Message-Id: 968c5310-605d-411b-1789-08d98e6d3e09 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 17:16:49.6045 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ikh/FE+KHwgxAktDaujI+RHS8zrOZqgQX6i1p6h0tHbNVMX1fXVBshxnsCcAMnHRjGSfKQhG9/ai3SYYs8z7uQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4885 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/sfc: fix build when assert enabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/13/2021 5:32 PM, Andrew Rybchenko wrote: > When 'RTE_ENABLE_ASSERT' is enabled (meson -Dc_args=-DRTE_ENABLE_ASSERT) > build fails: > ../drivers/net/sfc/sfc_repr.c: In function ‘sfc_repr_start’: > ../drivers/net/sfc/sfc_repr.c:251:20: > warning: implicit declaration of function ‘sfc_repr_lock_is_locked’; > did you mean ‘rte_spinlock_is_locked’? > [-Wimplicit-function-declaration] > 251 | SFC_ASSERT(sfc_repr_lock_is_locked(sr)); > | ^~~~~~~~~~~~~~~~~~~~~~~ > > Fixes: c85675423f01 ("net/sfc: implement port representor start and stop") > > Reported-by: Raslan Darawsheh > Signed-off-by: Andrew Rybchenko Squashed into relevant commit [1] in next-net, thanks. [1] net/sfc: add port representors infrastructure