From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jeff@tracevector.com>
Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com
 [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id 07C075946
 for <dev@dpdk.org>; Sun,  9 Feb 2014 23:52:12 +0100 (CET)
Received: by mail-wi0-f169.google.com with SMTP id e4so2225074wiv.2
 for <dev@dpdk.org>; Sun, 09 Feb 2014 14:53:35 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc
 :content-type;
 bh=Rg+UiAaCF8EPhZGI0tY8l4VE/doj8mo7v76cYZ0s5yo=;
 b=A2h267Gocg7OWzFM6ep8t7FFiHGp20T1WfXW4NTOt+bxpGU8nefffeWogTIIZhfkfa
 XofiBDy+f0U7IJ+Inm7t9FDldQA1wrVzeGuHV5YUuxNL8kC6ztCXCqA9AVPFFH7VIykV
 dV43UzgNGkK9gvMqufBZKrpsHDgyTpkGEv48vogGsRHVt/IZywpuhqGprmpxibmBaLXJ
 iiVLoAqwscda1Wagv0aFk9SGdmpYV5y+qpZpaK3Yp9x+TZOfRDgrFuPQfQdU7M+O797U
 0jDtMBTKZ9eQIR90bGY1Mz7CxNSxfsNPIjTdqfUdWJ3N7hWz6BVMykfLRbWfLp42dL4C
 /KDg==
X-Gm-Message-State: ALoCoQksMcbKr5Cu+hqxLzLkkIDjCS2JsZKyEFiH0J+kWjex/InOgpdXDToEPTjQL6azNcO/1BVn
X-Received: by 10.180.24.227 with SMTP id x3mr8056567wif.41.1391986415198;
 Sun, 09 Feb 2014 14:53:35 -0800 (PST)
MIME-Version: 1.0
From: Jeff Venable <jeff@tracevector.com>
Date: Sun, 9 Feb 2014 14:53:35 -0800
Message-ID: <6194890747401351690@unknownmsgid>
To: Ryan Prenger <ryan@tracevector.com>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] NRMK build break
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 09 Feb 2014 22:52:13 -0000

  Make clean outside of NRMK would have caught it.

Sent from my Windows Phone
 ------------------------------
From: Ryan Prenger <ryan@tracevector.com>
Sent: 2/9/2014 2:08 PM
To: Jeff Venable, Sr. <jeff@tracevector.com>
Cc: dev@dpdk.org
Subject: Re: NRMK build break

Thanks for fixing it.  In my defense, it did build from a clean build for
me before I left and Himanshu also checked the build for me in case I
forgot to git add any files. The only ways I could see this happening is if
environment variables were different on our machines or if doing a "make
clean" leaves something behind from previous makes in lower directories so
doing "make clean; make appD" could work or not work based on previous
builds.  This is something we should track down (maybe you already have)
lest Jenkins starts clearing builds that break from a fresh install.

Cheers,

Ryan


On Fri, Feb 7, 2014 at 4:46 PM, Jeff Venable, Sr. <jeff@tracevector.com>wrote:

> For those who leave the office before verifying they didn't break the
> build, a public flogging! :)
>
> /usr/bin/ld: cannot find -lipinfo
>
> collect2: error: ld returned 1 exit status
>
> make: *** [/home/jeff/Colossus/nrmk/dataplane/P2P/obj/debug/libP2P.so]
> Error 1
>
> make: *** Waiting for unfinished jobs....
>
> You marked libipinfo.so as an *external* dependency.  You need to make it
> a *makefile* dependency.  The fix:
>
> (*jeff**@**colossus** ~/Colossus/nrmk**)**$ *git diff
> dataplane/P2P/Rules.mk
>
> diff --git a/nrmk/dataplane/P2P/Rules.mk b/nrmk/dataplane/P2P/Rules.mk
>
> index 2ecc396..093b7ac 100644
>
> --- a/nrmk/dataplane/P2P/Rules.mk
>
> +++ b/nrmk/dataplane/P2P/Rules.mk
>
> @@ -34,6 +34,7 @@ libP2P.so_DEPS := \
>
>      P2PConfig.o \
>
>      $(TARGETS_$(TOP)/lib/json) \
>
>      $(TARGETS_$(TOP)/lib/notes) \
>
> +    $(TARGETS_$(TOP)/lib/ipinfo)
>
>
>
>  LIBDIRS_$(d) = $(TOP)/../lib
>
>
>
> @@ -41,5 +42,4 @@ libP2P.so_LIBS = \
>
>      -lcolossuscommon \
>
>      -lcolossuscommand \
>
>      -lcolossustrace \
>
> -    -lcolossusutilities \
>
> -    -lipinfo
>
> +    -lcolossusutilities
>
> Pushing the fix.
>
> Thanks for moving all your algorithms into NRMK! :)
>
> Jeff
>