From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D947C46700; Fri, 9 May 2025 15:42:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB3854025D; Fri, 9 May 2025 15:42:50 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by mails.dpdk.org (Postfix) with ESMTP id D357C4025A for ; Fri, 9 May 2025 15:42:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746798169; x=1778334169; h=message-id:date:subject:from:to:references:in-reply-to: content-transfer-encoding:mime-version; bh=uoMldrRbH8kgoRoEzKfCm2z45FJOoeHmCX59lO/9n20=; b=ZZqtiaejujkTk2pxrQow4eSOq1TSna8Fl0roGMlZRuE1djLeDjX9EdxX yZ6+FkeYCJVBgdhTthdssW99a9kOrQG1Xjjf96azH20DTeQbf6wD/kMWo 1CBuDNP0yp6APXHXLeevD2kVsUJ0qi2ii1SfMhyuILTDvVFKLqI8cayk5 aT+ZLuOIq7sj6/rWjh+Hwsxg1zEVPKa7aZQchFAM22LOvk945SI9B7o6M nqFLF1M9WVEl9pje+oge8yDMhgY0Y5WRDPlKBRA/I4IDWNNeaMfT/PDu1 sq2Di8TC/lp6cPzIAzpBfCTVHKytHdsa8qeyDAZDjwowAkJiALod9GP4l g==; X-CSE-ConnectionGUID: LdgFDk3lQvaeeKpc9Uxu6g== X-CSE-MsgGUID: lwAS35auQaGLTeyjyLz63g== X-IronPort-AV: E=McAfee;i="6700,10204,11427"; a="48532690" X-IronPort-AV: E=Sophos;i="6.15,275,1739865600"; d="scan'208";a="48532690" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2025 06:42:47 -0700 X-CSE-ConnectionGUID: T6dZNcZ9TYCnVclZwxyqkw== X-CSE-MsgGUID: HkCacZ/NRxyTxSRKgsrPQg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,275,1739865600"; d="scan'208";a="136323033" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by orviesa009.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2025 06:42:47 -0700 Received: from ORSMSX902.amr.corp.intel.com (10.22.229.24) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Fri, 9 May 2025 06:42:47 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14 via Frontend Transport; Fri, 9 May 2025 06:42:47 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.49) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Fri, 9 May 2025 06:42:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zJwfcdXLJt50JNpVUINBGj7blL45JlvZxOOqQ3XrGYFlT2L9FTD3yydseJtx5xbKNNzbJ6RJZGtsYjcsFALAAtKDtkqFcayaljv/bh6o+UR1uALirDQuelWzTX+woHXLO0Xu0JeVW41VUvMc8lRcpHMyzZSZoI5VAPAonZlg2Xx6Sl92vbQduF/v856vb9Ok46tzM1y16rvREKD4vgJxnKBPs+my8K6yXHUQ7rdifsyeJHPpByh4VTe5otcWQ+HT/boZ1YTjgNzTgbR9COwkvsVzk59sXnIO/AQ8obIKzxGQUCTqgwWxJeyymVq7tJX7yCL7zQrQLwemCuV4CS0pwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zb5Du6oxS8+VzOhImehTuZQ4h43dmPvXfksSEGURUiI=; b=PbJm+J1Xro3mgq7v6Kki0zsynagddozNEi+SRcw+hRCoruzlRMRAtlmFccpkvMPVunueSbOU/n4k2M8OX/M1GZHUDkcKE43r6u4OrHJv+hAAkTRqU7tK/YS+QygXb29dlL1fh0Mr2wW8C4XBvKdvjnO7jX9NGw+uAAuLasc/F0ZDgohGU6gIbjCrYnDEx8K9JU3jcb/XthvSPaXvPpO7ZDe5QIuWEj6HHtPBdPLZ210eLlp4WL9phyV72RMOX+/m4SPwoA6yMJp2otUBzwnjLADY9myIe2bmCDcpVNHgdBucUj79le089P2kMhv3rxInNExPSAbD3iBG36cXzNA6+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by PH7PR11MB6769.namprd11.prod.outlook.com (2603:10b6:510:1af::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.23; Fri, 9 May 2025 13:42:44 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a%2]) with mapi id 15.20.8678.033; Fri, 9 May 2025 13:42:44 +0000 Message-ID: <61973ce6-801d-4fcc-85ba-3c719d01ffcd@intel.com> Date: Fri, 9 May 2025 15:42:39 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 1/3] cmdline: use C standard library as number parser From: "Burakov, Anatoly" To: References: <7ac1444b7d2d64dc467a22e7ac65cf3cc16246dc.1746188833.git.anatoly.burakov@intel.com> <9ea91fbec73396343179143e9c3b058148f05c5b.1746797960.git.anatoly.burakov@intel.com> Content-Language: en-US In-Reply-To: <9ea91fbec73396343179143e9c3b058148f05c5b.1746797960.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0301CA0088.eurprd03.prod.outlook.com (2603:10a6:6:30::35) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|PH7PR11MB6769:EE_ X-MS-Office365-Filtering-Correlation-Id: 3bb3cf1b-e3db-4713-e22e-08dd8eff608a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cWpSb0FRb0NOYmxxL1lSd0h0QVdGUVdpUVZ5eXFnVlEySm1nU3B1SkRSMEVz?= =?utf-8?B?dGRmMWhqRWptdEluOExtZ05ibXdCYy9WV3RWVmVhb2hRQkFRMVZRa1lRck5K?= =?utf-8?B?bVZCdEY4ajBNWUVrUW10YU4zdDNQYlBDY3lDNWM1RjFYWCt6RWpQWUdqaXlw?= =?utf-8?B?NytCSEg3MnRsVlJTTzNadnVSR2VicFNMZWxMYTI3c1cvM0RTemtRK05nS1cy?= =?utf-8?B?b3Z0cjF2dmt0ZjBMSWNXTWJhWjFwUUN5cWdBNDYvQy8xbU5nbE5hSDBuTW9U?= =?utf-8?B?Q291QTBydmwyR21NY2lYWEhLTHh0Mm5sV29MZ0V2aHBZQ3FlR0FLTHpNazlF?= =?utf-8?B?SFZuTTRQbDIzOWpOQ25xQnlzenhNZzBWNUJoMmFWZEZnQ1orTXowS3czMDhU?= =?utf-8?B?YVp2MEpFNFgwYkdkaTBNeFV2S1BSb3NDby93SVZxMmZ4T245alQrUmdXV21a?= =?utf-8?B?Ykc4bW1YR2xzWXR5akhQdmpSVW51U0sxV2F6RHlMNStudm53ZlMyNWtneExj?= =?utf-8?B?VEd6c090SkRkaUJuWlhrT25FTmRkOXBtV1RWa0cwd2tlK0R1K1orbFJjZXR6?= =?utf-8?B?YTdacjNHOUJHcGU3WElOTHptZDE2d2VvZ25BSHI5Z0Y1M2VKWitVTXM5SWJB?= =?utf-8?B?SEJKaDJ6WXl4Mll0elZMNnJrMUh3VU9aeG9YK2w5WlI5Qy9tNFlGMjRFR2dH?= =?utf-8?B?Ylk0UEV6QTVsbkNQaXQwU0t6VHNlU1h3UEErUFhUMzFib1dRRGlpVWdGd0tq?= =?utf-8?B?QVpEbU1iU3J1VmFXb3BlT3ZEdzE3YU44Zi9zYmM3UHJQa3NKL3ordzgxQy9K?= =?utf-8?B?NnhyZlFQeDJpeDJtaGlQUlZCM0NIT2FFbW1tRHZCNWY4d1ROaEs5TXRkT0hq?= =?utf-8?B?cjhoMkMyTDZrempEeHd2L0NSVk5FUm1oT0tmK0YwcFk0cXFxam11ZTBBMHNJ?= =?utf-8?B?YTh3cVZZMDRKZUw5b2U4ZTlWbTFLRTFkUWtESk1WL21wYnU0a2dCN2NRbXps?= =?utf-8?B?ZEtqaXBGQXRJbXhCSDJYaGhiR0x3OEMvdlpva3B5RFVmWXFrTUUwRTNTVXE3?= =?utf-8?B?LzA4TGoySXQ2aENBclNlVEpKYm1EZkQxVlRFdXFLRm1leHluMXJDbGY3VUk2?= =?utf-8?B?Qk5jNnNUMFdnRHh0WVNTSXVnRU5wcWQ0ZGQ2WDJjYVpZTU5ZaFZzeERjZ3d0?= =?utf-8?B?aWVyYzNxRWwwcmFxSkxFaWRCOGZ1TEhWNnFsUlpaWUxvRXFyTS94ZkZ6UjBN?= =?utf-8?B?R2VBM01CNU9rUERkZFlrNE5jTlBXeGJVOGY1OTczTjl0RFZQWHAwYVIrZ3R6?= =?utf-8?B?c2YveFM2R29jNk5uYjFSQThGb25FalhMUUpRMWtaUGtaMFRzRGNoK1hFaVIw?= =?utf-8?B?Q2llbWM1R0NHV3NJb25uUzdGdE9PWmoxbG1jazg0ZDF2ejZoVmt5azZPWGdn?= =?utf-8?B?U3ZMVjBRUHl6OThNVGM2NW5ldkF5Wm82NldYclJrSUFORXpqWXBCZm5Yam9Z?= =?utf-8?B?MFUzY2pmVks5ZFMyRmZhSzl4MytBMTh0WS90VmEwejdtV2o2Rm44ZkNBOGRH?= =?utf-8?B?UFpOZzdKcUFDd3FKUU5DY1V4MlppRFZjUWpySE5ONURMbHRHV2h6TnVadmRl?= =?utf-8?B?NnBCeTV1N1hrcTl2SmVETzFkalo5UUZZYWRuL3JYSGozSnprZlZjdmRJSVJX?= =?utf-8?B?eE1JUlc1Qm5DcHRuazNwd2Z5MGVJbi9LMGFrYng0VE8rQWY0ejZaSUpRc3Z2?= =?utf-8?B?QVRDMlp5aVBBaG5TK0hSaVFSSVk2VEJzMisvWkIvNTdSSW9YdGxWbGprdWJZ?= =?utf-8?B?anZLcFVGMlFyRnlRbmtGSzNqVkxMTjRkVTlvK1ppRzJBaURxVU9KdUtVMVFQ?= =?utf-8?B?dUd3elZRcjlXUWJmTEw4Z2VsOE43VWNmSnVwSEVPYXlEZXoreEJibDI0UEY3?= =?utf-8?Q?iZnysnAKVPg=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YXRVRWd6RitOLzBVaE53WldSZ0N4ODN1YTFraWkzUXordVBiaFZxUk1pdDFF?= =?utf-8?B?SnZaWXJhTzQ4Y3Y5ODM5VjhHOXB6NlpZZXJtU0U0OVZXcnFjclU1Yk5pU0xM?= =?utf-8?B?YXhHSnhZNG5rS0t3UnEzbDI2bCtBakpVNFd4Q28raFRxc1hlcXVLUkJva1BD?= =?utf-8?B?RElGR25yZ1Nma3JEdlhRMGtsUkt2TVlIVnMxbmVWU0lrVGhsU3RUVmo3d1Ew?= =?utf-8?B?Uk0zQ3NMdFFSNzVtTFJKMlh5Q1oxL1ZqeGdTaUd4cDVsSVRTMjJGN0k1WWhN?= =?utf-8?B?YW1uMFV3QTR6L29kd0lQc3dhR3R3OXl5Zk1SNGZ6S3A1T2Vmb2xGbmZEanps?= =?utf-8?B?LzN2SXNPOGVDRzAvRHVER3VwYVRDU1p1L0RtWHFVYWVFSXJQd0s5bHJPSFNG?= =?utf-8?B?dFcvNVVEWTlacDFNUFJFODJ5ZUJSbFRHN1pvT3BGME80NzlXTC9SSjYybkZP?= =?utf-8?B?RFEzelB6RE1OZTJQWnRCSzRieE5GRXBlc0RsSmtaMmdRNVJzRHJLTFNQR2ZN?= =?utf-8?B?REVRQnpsakJzM28raFdMUlloWVVQVHdEVzk0QmR1U0w1TXN2cnZBVUx2ZldK?= =?utf-8?B?eW5hUTRkbUxIbVBsMFFYVmx1K2l1UGxMTEY1Qmd4UDNmN0NVODVweDIzYytX?= =?utf-8?B?UDQ4SHpLa1g3S2EvNUZkQXJuMysxVE5rRC9yTUQ3YVRRWW43ak9vYmN1Mkpa?= =?utf-8?B?NXJZbTRzZW4rMDFyMk9DbEpLLzdmUVZSa3dMaHlwYzh0emhQOTh3QzdPSEJw?= =?utf-8?B?dG16RG9XVm01KzBxV29LVnVlTlg5MWlZVjNoRVhuQ1BrdW04NDNGS3lOVkNR?= =?utf-8?B?NVBNUHkvSHppbWxLRThHR1BlbHV0M2Y2M25IaFFCV0pCV011MUVZbG9ObjZR?= =?utf-8?B?TVNoUTRMKzdvT1E4YldoQTBHT3p4dmdqWWRtaXhzOGVqKzB6MHNDaTY1M1JK?= =?utf-8?B?dlVUS2hmdlVnbmZNOGlWWXl1U09VVFVrYnBqOEhrRmFCWm8zNnR2WGZwanVw?= =?utf-8?B?cndpS3VBb2V6THVCVXFjT3kzOGtaS21iZEI0bWpTdE1zOEtOS2k1YnJHVVVv?= =?utf-8?B?THE0VE00c3QyNVh6Z2hkMDByQ21McERaN2hxTkd3VFBScWgvWXFwMjFDRkRi?= =?utf-8?B?OVRLTmVSTm5WS2c1UWtuc2llUEY2aDliT2xmNFJIMTF4a2lYeGZ4aFlBWUhL?= =?utf-8?B?MjlOZG9WMk9ENCtrYzJyT1dXMFJBTXlEaUpid05XOXhnTUUxTGp5K2VySmN2?= =?utf-8?B?K1dqaWNwNk1WQVVyK0dYSlQ2U1B0dUZ6OGl6WUxQQXZaUk4yLzZNamUrOHpK?= =?utf-8?B?ZUNyWFhCS3FWSDJWQ0JTckU1WTFCY1NDK0dleTJkaGdIcWEwOEE3VWVPeVVq?= =?utf-8?B?Vm0veS9GVFdoV0N3Nk9NbFlwdmptdmVadGdsMGxwRzhqWWJiUEU2aVFUOVZi?= =?utf-8?B?dzRONkFqREFHWDQrT1N1eWVQc2RjVkhKRVpqRFB1ZUpzU09NcGpJVnBEVmNq?= =?utf-8?B?aktVNDV3MlIrMDlUVzNJbWoreHVQbHFISWpJUFZiY3RBRGd6WjBWMUd5NFRx?= =?utf-8?B?TDJZNDNZa01xQ0Z5RHhUcGk2WXo2MGZid1J4aEw0UUtyUkNSTWpHK3BvSERG?= =?utf-8?B?Nk9uOEVGdjB6N290akw4QkpsZmdrUTlFSkVOc1BTSElzeG9scGNmamRMRkl4?= =?utf-8?B?RGNMUTBhYkV1R0pOSnBxakJ3MGZpbDdpdkRXOWkxdzBiRkdKVnNvd1ROQTRH?= =?utf-8?B?YjVNcWNKZ1I5enRJZFMyQ0d6MmNpRjQyRWY1YjBYUUhMZXduSDd5N1hRY0sx?= =?utf-8?B?U2FqYnRUbGI5UHQ4RDZRNGx3dko2NmYzaEt5cnFGN29haFJ2M2sxMG5Scktj?= =?utf-8?B?ek1vZ2dRdlN6MmpHTWlrcVhpU0VqNU9NY1VMeDY4c0hCUnppUVRySGdMREVh?= =?utf-8?B?aFZCV0ZQdWZDSUtlV0ViS0lPc3dhUmh6SVk5ZFN0dkJQeldrQWdRQkpjWXl2?= =?utf-8?B?SFpEVWZRa3k0cEVzWFY0ZWtVSjBzdWZjQkNwQXRuTS9XNXVhbmYwblFNT1oy?= =?utf-8?B?Z0haNGpxSkdETjQ2VUw0VUFPR0hGcGczOVdzd3VOMTBKUWdqZ1NWRms2cnhw?= =?utf-8?B?alFqZUNEN2IrdlFuMDg5VzhxZ3lZSytsNTU5Q2tKTHMvWWlZRjdHbDJjTXdI?= =?utf-8?B?cFE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3bb3cf1b-e3db-4713-e22e-08dd8eff608a X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2025 13:42:44.6200 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3aB/CMMVmvU64CbFdJCMV3XGhFyiERVJbqjzs/OQmlLutlCVYQ4KgzrOelg+43hwWxDpJN7VBBN7Kv6zoQG5XXMb/XWBFIKZJVFpmKmNUmk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6769 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/9/2025 3:39 PM, Anatoly Burakov wrote: > Remove custom number parser and use C standard library instead. In order to > keep compatibility with earlier versions of the parser, we have to take > into account a couple of quirks: > > - We did not consider "negative" numbers to be valid for anything other > than base-10 numbers, whereas C standard library does. Adjust the tests > to match the new behavior. > - We did not consider numbers such as "+4" to be valid, whereas C > standard library does. Adjust the tests to match the new behavior. > - C standard library's strtoull does not do range checks on negative > numbers, so we have to parse knowingly-negative numbers as signed. > - C standard library does not support binary numbers, so we keep around the > relevant parts of the custom parser in place to support binary numbers. Missed updating this part. Better wording: cmdline: use C standard library as number parser - Some C standard library versions do not support binary numbers, so we keep around the relevant parts of the custom parser in place to support binary numbers. However, since those libc versions that do support them, also support them being negative, allow negative binary as well. -- Thanks, Anatoly