From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 36D9D108F for ; Mon, 23 Jan 2017 18:30:47 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 23 Jan 2017 09:30:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,274,1477983600"; d="scan'208";a="1097843549" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by fmsmga001.fm.intel.com with ESMTP; 23 Jan 2017 09:30:44 -0800 To: Hemant Agrawal , dev@dpdk.org References: <1484832240-2048-1-git-send-email-hemant.agrawal@nxp.com> <1485172803-17288-1-git-send-email-hemant.agrawal@nxp.com> <1485172803-17288-3-git-send-email-hemant.agrawal@nxp.com> Cc: thomas.monjalon@6wind.com, bruce.richardson@intel.com, shreyansh.jain@nxp.com, john.mcnamara@intel.com, jerin.jacob@caviumnetworks.com, Geoff Thorpe , Roy Pledge From: Ferruh Yigit Message-ID: <61976e79-6ea8-0b9c-0792-c9cdc4dbc14a@intel.com> Date: Mon, 23 Jan 2017 17:30:44 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1485172803-17288-3-git-send-email-hemant.agrawal@nxp.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCHv6 02/33] drivers/common/dpaa2: adding qbman driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2017 17:30:48 -0000 On 1/23/2017 11:59 AM, Hemant Agrawal wrote: > QBMAN, is a hardware block which interfaces with the other > accelerating hardware blocks (For e.g., WRIOP) on NXP's DPAA2 > SoC for queue, buffer and packet scheduling. > > This patch introduces a userspace driver for interfacing with > the QBMAN hw block. > > The qbman-portal component provides APIs to do the low level > hardware bit twiddling for operations such as: > -initializing Qman software portals > -building and sending portal commands > -portal interrupt configuration and processing > > This same/similar code is used in kernel and compat file is used > to make it working in user space. > > Signed-off-by: Geoff Thorpe > Signed-off-by: Roy Pledge > Signed-off-by: Hemant Agrawal > --- <...> > --- a/config/common_base > +++ b/config/common_base > @@ -287,7 +287,6 @@ CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_TX=n > CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_DRIVER=n > CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_MBOX=n > > -# Minor typo .. > # Compile burst-oriented VIRTIO PMD driver > # > CONFIG_RTE_LIBRTE_VIRTIO_PMD=y <...> > --- /dev/null > +++ b/drivers/common/dpaa2/qbman/rte_common_dpaa2_qbman_version.map > @@ -0,0 +1,27 @@ > +DPDK_17.02 { > + global: > + > + qbman_check_command_complete; > + qbman_eq_desc_clear; > + qbman_eq_desc_set_fq; > + qbman_eq_desc_set_no_orp; > + qbman_eq_desc_set_qd; > + qbman_eq_desc_set_response; > + qbman_get_version; > + qbman_pull_desc_clear; > + qbman_pull_desc_set_fq; > + qbman_pull_desc_set_numframes; > + qbman_pull_desc_set_storage; > + qbman_release_desc_clear; > + qbman_release_desc_set_bpid; > + qbman_result_DQ_fd; > + qbman_result_DQ_flags; > + qbman_result_has_new_result; > + qbman_swp_acquire; > + qbman_swp_init; > + qbman_swp_pull; > + qbman_swp_release; > + qbman_swp_send_multiple; Overall, dpdk library exported APIs not having DPDK prefix (rte_) is a concern, which already pointed by Thomas. I guess only user of this library will be other dpaa2 code, so these are not really APIs. Not sure how to proceed. I think I have seen "_rte" prefix used in some APIs to say that is internal API, does it make sense to use that API here? > + > + local: *; > +}; >