From: "Wiles, Keith" <keith.wiles@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dpdk-dev <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Thomas Monjalon" <thomas@monjalon.net>,
Olivier Matz <olivier.matz@6wind.com>,
"Maxime Coquelin" <maxime.coquelin@redhat.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH 2/5] net/tap: revert changes on rte_ prefixing
Date: Wed, 29 May 2019 13:36:12 +0000 [thread overview]
Message-ID: <61AFC727-02F7-4C2A-96CD-1B7BBB01D1DE@intel.com> (raw)
In-Reply-To: <1559129358-2935-2-git-send-email-david.marchand@redhat.com>
> On May 29, 2019, at 6:29 AM, David Marchand <david.marchand@redhat.com> wrote:
>
> This source is compiled as a bpf program out of dpdk.
> Revert to structures/macros coming from libc.
>
> Fixes: 6d13ea8e8e49 ("net: add rte prefix to ether structures")
> Fixes: 24ac604ef746 ("net: add rte prefix to IP defines")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> drivers/net/tap/tap_bpf_program.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/tap/tap_bpf_program.c b/drivers/net/tap/tap_bpf_program.c
Did not test the whole patch, but the changes to TAP PMD seem reasonable.
Ack just the TAP PMD changes.
Acked-by Keith.Wiles<keith.wiles@intel.com>
Regards,
Keith
next prev parent reply other threads:[~2019-05-29 13:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 11:29 [dpdk-dev] [PATCH 1/5] test/table: remove duplicate macro David Marchand
2019-05-29 11:29 ` [dpdk-dev] [PATCH 2/5] net/tap: revert changes on rte_ prefixing David Marchand
2019-05-29 13:36 ` Wiles, Keith [this message]
2019-05-29 14:26 ` Olivier Matz
2019-05-29 11:29 ` [dpdk-dev] [PATCH 3/5] replace RTE_IPv4 with uppercase RTE_IPV4 David Marchand
2019-05-29 14:26 ` Olivier Matz
2019-06-03 8:58 ` David Marchand
2019-06-03 13:30 ` Thomas Monjalon
2019-05-29 11:29 ` [dpdk-dev] [PATCH 4/5] replace RTE_ETHER_TYPE_IPv4 with uppercase RTE_ETHER_TYPE_IPV4 David Marchand
2019-05-29 14:26 ` Olivier Matz
2019-05-29 11:29 ` [dpdk-dev] [PATCH 5/5] replace RTE_ETHER_TYPE_IPv6 with uppercase RTE_ETHER_TYPE_IPV6 David Marchand
2019-05-29 14:27 ` Olivier Matz
2019-05-29 14:25 ` [dpdk-dev] [PATCH 1/5] test/table: remove duplicate macro Olivier Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61AFC727-02F7-4C2A-96CD-1B7BBB01D1DE@intel.com \
--to=keith.wiles@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=olivier.matz@6wind.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).