From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id B5A00235 for ; Wed, 5 Jul 2017 17:31:55 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jul 2017 08:31:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,312,1496127600"; d="scan'208";a="104699748" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by orsmga004.jf.intel.com with ESMTP; 05 Jul 2017 08:31:53 -0700 From: Ferruh Yigit To: Vasily Philipov , dev@dpdk.org Cc: Adrien Mazarguil , Nelio Laranjeiro References: <0dca86aa1372d6ff09d0aff01d522c580e0e24ab.1495717153.git.vasilyf@mellanox.com> <225679c202aa0bae5c61882aef6c8117a9074029.1499242343.git.vasilyf@mellanox.com> <448145d7-03d9-9c62-6676-1a3c4e52d879@intel.com> Message-ID: <61b04350-6b2f-8188-1de8-92a57ec8851f@intel.com> Date: Wed, 5 Jul 2017 16:31:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <448145d7-03d9-9c62-6676-1a3c4e52d879@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8 1/4] app/testpmd: add isolated mode parameter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jul 2017 15:31:56 -0000 On 7/5/2017 4:18 PM, Ferruh Yigit wrote: > On 7/5/2017 9:14 AM, Vasily Philipov wrote: >> Providing this parameter requests flow API isolated mode on all ports at >> initialization time. It ensures all traffic is received through the >> configured flow rules only (see flow command). >> >> Ports that do not support this mode are automatically discarded. >> >> Signed-off-by: Vasily Philipov >> --- >> app/test-pmd/parameters.c | 3 +++ >> app/test-pmd/testpmd.c | 14 ++++++++++++++ >> app/test-pmd/testpmd.h | 1 + >> 3 files changed, 18 insertions(+) >> >> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c >> index fbe6284..e313871 100644 >> --- a/app/test-pmd/parameters.c >> +++ b/app/test-pmd/parameters.c >> @@ -623,6 +623,7 @@ >> { "tx-queue-stats-mapping", 1, 0, 0 }, >> { "rx-queue-stats-mapping", 1, 0, 0 }, >> { "no-flush-rx", 0, 0, 0 }, >> + { "isolated-mode", 0, 0, 0 }, > > Can you please document the new option [1] ? > > And when you don't know nothing about isolated-mode, this option is not > specific enough. What do you think adding a "flow" or similar keyword to > the option? > > [1] > doc/guides/testpmd_app_ug/run_app.rst Overall this testpmd patch seems can be seperated from patchset. I will check other driver patches in the patchset, can you please send new version of this patch as a standalone patch? Thanks, ferruh