From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 12768237;
 Sat,  2 Dec 2017 00:52:10 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 01 Dec 2017 15:52:09 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.45,347,1508828400"; 
   d="scan'208";a="8185761"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.115])
 ([10.241.225.115])
 by FMSMGA003.fm.intel.com with ESMTP; 01 Dec 2017 15:52:09 -0800
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, vladz@cloudius-systems.com, stable@dpdk.org,
 declan.doherty@intel.com, Boris Pismenny <borisp@mellanox.com>,
 Aviad Yehezkel <aviadye@mellanox.com>, Radu Nicolau <radu.nicolau@intel.com>
References: <20171201022957.64329-1-ferruh.yigit@intel.com>
 <20171201022957.64329-2-ferruh.yigit@intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <61b4477c-afcb-9459-c132-3c2a45e227c0@intel.com>
Date: Fri, 1 Dec 2017 15:52:08 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20171201022957.64329-2-ferruh.yigit@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 2/7] ethdev: fix port id storage
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Dec 2017 23:52:11 -0000

On 11/30/2017 6:29 PM, Ferruh Yigit wrote:
> port_id is now 16bits, update function parameter according.
> 
> Fixes: 4c270218aa26 ("ethdev: support security APIs")
> Cc: stable@dpdk.org
> Cc: declan.doherty@intel.com
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Boris Pismenny <borisp@mellanox.com>
> Cc: Aviad Yehezkel <aviadye@mellanox.com>
> Cc: Radu Nicolau <radu.nicolau@intel.com>
> Cc: Declan Doherty <declan.doherty@intel.com>
> ---

<...>

>  
>  void *
> -rte_eth_dev_get_sec_ctx(uint8_t port_id);
> +rte_eth_dev_get_sec_ctx(uint16_t port_id);

Hi Declan,

Since this is a public API, it needs API documentation. Can you please send a
patch to add doxygen comments the the API?

Thanks,
ferruh

>  
>  struct rte_eth_dev_sriov {
>  	uint8_t active;               /**< SRIOV is active with 16, 32 or 64 pools */
>