From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DFDDA0547; Thu, 28 Oct 2021 20:23:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 55C5840DDB; Thu, 28 Oct 2021 20:23:48 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 79CE74067B for ; Thu, 28 Oct 2021 20:23:46 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10151"; a="230745931" X-IronPort-AV: E=Sophos;i="5.87,190,1631602800"; d="scan'208";a="230745931" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2021 11:23:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,190,1631602800"; d="scan'208";a="487253279" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga007.jf.intel.com with ESMTP; 28 Oct 2021 11:23:30 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 28 Oct 2021 11:23:30 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 28 Oct 2021 11:23:30 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 28 Oct 2021 11:23:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZYHyZ/CJjrXMRi0Dd+5XR94mNqbbPEycHScLW2vJczHw/5rmawB3emM1TouCWSgVRoaHLL4ThhewyYMBNt4FrS0znAF4G8D+/IogsL3+WSp18g4t1p17awXN1GI3PXE1gZVWKU49EOdo9gNjYMa9GhYJe67VlSCPbSKJqsstguRQVHCpfbWEgmmb3ZOZrzs7DhWsRDSBr3uIRE+t1344D3El6KVRXbiXaFBoCNU8O1DbDC3gLLWnPUCXOAKbzTVDz+cDsD6NHwUHYiE+YGMMrwaV6mOFsSslOZfR0jV6ffT81tN758sr68PE1yKx/FwYt/c6/IBRRlScXM6cer82Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=39L8ZoOaapyDgs6AIDC8gwyPEXDNMKeVa5avm/8kHes=; b=mluqAZ51/nafDtD7Sw6q7IQAZf8aJ0aV26uerDRNRHIpAYwNGwAGrsO0k7uNxLSRhHnuvi2YwfpKVb+1QRfTwvBFOhAIkE+8wFQ5gkbDJgrCN/Xa23dXxSHs8BxPeZQvwg1WFpDyIt0XTN2HXanGlekbZrcBh3iZGF//CmhC8HHkHBH0k2PSe0QAZAyY1CC7fRmtk1k1HFMgqc9pAZ6Hsvo/CXHnuCyKrijremWKNHFQjlq7zMCborjqtGTgesTBjWrtwy8n1bM/mxxfWC0O3V4tMBag96w+DifnbuvkIKS+Bjc1bmv+5KNnpJH5N2SbFiveAvTavx01R52ma70xsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=39L8ZoOaapyDgs6AIDC8gwyPEXDNMKeVa5avm/8kHes=; b=vx9LfzVet4k8y/sLkbKL23Qknfgl3GHI40qGISOEtbZBqWvMYnOdE0nqxmHyk5ASt+V0kJlxV5IDwuX7Glz78vN4Lu3WrTB1PPbvisQ8AynWhe9Zf/AZ0HgE+3mgpe/g9DzfmUZVdeMFjEFWtD4tnltF2zBJowgMaOgc9rc/xEg= Authentication-Results: broadcom.com; dkim=none (message not signed) header.d=none;broadcom.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5016.namprd11.prod.outlook.com (2603:10b6:510:32::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Thu, 28 Oct 2021 18:23:14 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4649.015; Thu, 28 Oct 2021 18:23:14 +0000 Message-ID: <61c8c94e-6c63-17e9-0950-5ddc8b327437@intel.com> Date: Thu, 28 Oct 2021 19:23:07 +0100 Content-Language: en-US To: Ajit Khaparde , Andrew Rybchenko CC: Xiaoyun Li , Rosen Xu , Konstantin Ananyev , Ivan Ilchenko , dpdk-dev References: <20211024164237.2116166-1-andrew.rybchenko@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0301CA0043.eurprd03.prod.outlook.com (2603:10a6:4:54::11) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0301CA0043.eurprd03.prod.outlook.com (2603:10a6:4:54::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend Transport; Thu, 28 Oct 2021 18:23:12 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cb92e64e-59c5-4160-d618-08d99a400137 X-MS-TrafficTypeDiagnostic: PH0PR11MB5016: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2512; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d4IAhqgwQPLHH6Cd6kz78J6THlas9NV2JyD0ZYtDB+JUcDCefCZpKLwUMG0Py2SrAWI5ao/aWCOwPAuAcPsdC3wKshZdeGEeGZDh4BJPFyqf6q4VU22wDM7BSL0/+YDs+D5870uWst+RGfN60pMWNwWhcnyiCpOZFt5Srmq+WFpOrErXk9iWPr/hxb0Aau/XsPuUf7h3jBlSLcuaBh+nYTo64nKaNL47UxWYqce88e15TR/mmVUPqJlkD45zfeBR05xlDVmyCIdDfGGq38TaTxVO9+D2e/HcoMceDANT/e/J3P8sTaTZ9DTY2k0uFGUHu9kesm5WsOcm9MH94wEx91FAlM4txuVnPzo2nL9BAxbXcFJ5LYBvIVIcJjt9NMoK/+SYy3dJAnZsd5s9zDmzKewDMZNf65miR4skB3U/q9D6WZD78uGNM0MdPMRxj5W6R2UO3VcqOsoOwbBlemt9G9hLELiGJWzUIhjH9CILh4NSGCC0UP2rnGpq+nPolGxgwSGgq8TmYaLjdSbUz4+k2IGOPT3Ama/cBI+R0FivEJVbu9H2MPs8gUCNSNcZhKqeQs2l9mrz+qK6lgZvMsRFtAAqAzRKZYhbMn7p3RnMGpz0K6SHp5PbEtL1jwHxNvA5rdENvUcELQeMN5T2UgsgX6zy67q1sHojrHRDQyp2SOtrT15EwsO810hxR06PRpvemd9hIRDKNtoXjBHYG0P0/A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(26005)(6486002)(83380400001)(53546011)(6666004)(2906002)(4744005)(8676002)(36756003)(956004)(82960400001)(110136005)(31686004)(4326008)(66946007)(44832011)(8936002)(186003)(66556008)(316002)(16576012)(54906003)(5660300002)(2616005)(31696002)(508600001)(38100700002)(86362001)(66476007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnhPTVlvRTc1dythMjcvL0JJL3BBWVVOVzAvWmNydWgvWjZsWGUweFNpaFBE?= =?utf-8?B?dTRpTm1zd0grSk92VE13YlZtZU5maWxURkNJNWZPbWVuYjcyRDVnOWdIVmNx?= =?utf-8?B?alRKdWI5NlFCOGtSeHorWmR3N2t3YklTVngvMmZtNm5tQVUvQys0NitWbG5Q?= =?utf-8?B?R2xGZmx0a1VsSnhZbXMzVFZ6c1BCNStpcnF0RnBTTnBXU1pxdlNDdkQ4SGhj?= =?utf-8?B?Z29LcU51VGIwVnFjTXZZWEVWODk1Q293UjRVdU9pVm9YNUVzQ0VGbWg2U1BV?= =?utf-8?B?ZFQ3Yjl3YUNKRmx4WmF6YVp6bjNNQXZ6R1IwRVBuSXJXTEkycWVQMTE3YzVo?= =?utf-8?B?RjFkaDdCbmw4SmlKRms1akFUY3QydmMvcjRDL1l3ZkxYSm01bG5OWXIwSDJw?= =?utf-8?B?LytGUi8wRjNSZWpNelFSOFpWRWhZMXZKNXRXZVVMb2kvcDVvbnVWelhNWkEv?= =?utf-8?B?UzlHZXNOSThMTmpjeERIWEg5Szg1VE1iRUpiL3FvUXI5bHVVaWk5RDhNbDlu?= =?utf-8?B?TEtTZk5JbjBpalhHSDlJTVRUeGZZY1VBcEd2NFZ1bE9xM21FYmhsSkVKWUtS?= =?utf-8?B?d24xQWRPN0JBWEIzNjZoRW1oUTR0ck9lWjJlOGlVOHlJZ0w0d1NqbE5CNnpV?= =?utf-8?B?V0tSUkRZUzlGVkpJTWhHdjRvV1RBc2Z5OUpmaXNhYzRubVJNL2NvTitwQlNz?= =?utf-8?B?eWlvZFlXNVkrWGMrb2tLQVdjUElEbDFqYzdMbE5LeU5DOTlodzgrUkNHdTg3?= =?utf-8?B?d0VxeEN1L2dKaFMzZTVXdm5VcEVCYWw1a1RGT1F2TVdVRVZwZjc1amt5UTBN?= =?utf-8?B?eGhrRjc1ZE1Na0F4L1FpUE8xZ0lRVEZCZ2M1Zktob0pkcm9rWlh6TFdxTGlv?= =?utf-8?B?YlIwa1duVlV1WGxRMUFiZkJBQ3U5cTVoS2o4TzNNZkk3T1M4L0p5MkthSGhW?= =?utf-8?B?M3lxUlBFc2dvQVlhOCt2c2lzQzB0bUJaVWhRaGtYZ2toSWI3YmJEaHFOYUxJ?= =?utf-8?B?L0NpL0crQk5pNUg3NkNxSXZLS0hZWTloYXZzSkVIVXQweHZYMHFSTWRJSUVs?= =?utf-8?B?aUNqRDU2U24yVXBUVXd1bkFrbENwUWgrM1I3eTBLQUJTbkhURkJYK0F3emdY?= =?utf-8?B?ZW4yTyt3WXl1SERuM1F1Rll4Q3p4UGhhdmxnZnJsL3kvUVJrSWs5UThKN2dh?= =?utf-8?B?VDZ6aWZ1aGRyWW5YckhNYzN5TDFqVHNtdVA2OWJsOFRpV09nRDN2UndybnFN?= =?utf-8?B?UHlSWFptSTUvWWI2SUsvOVJXcm1OOExKcUhjQzhTRlRJVlM5bzQ1aGsxcGcz?= =?utf-8?B?U3d3QVdhZTNuS0FxblJOZERxbDBMUC83WGpRNmY4UEhJNVVzVmdiNHR3TzUr?= =?utf-8?B?Tm1RVjYzVll3c3NKOWt2b0s1Q0FIRDRQYkFaeUxsd083UXViVlVjNVRJRXl0?= =?utf-8?B?TDQ0bXJ4K0pYLzQ3QXB3d3FzZGp3aVBEVC9CSUdqTUJLNWxaNmpUVHpLWmd4?= =?utf-8?B?dWtPTWUybWJjSTNMZlYwNWN1bEY2cVhack5mdHZpK2k4ZC9MZk1qeis3SVVY?= =?utf-8?B?RXJhblZEZUhyS1lsSXRjOC9tanhFNDlTY3ZiR3VFNFNabm1DMWF0SCtrSFRK?= =?utf-8?B?L3p1WWVIL3VMakRhWG1OUzliMUp1ZWw3emx6QzZvc21wNDRIMGVtTW1Fekp6?= =?utf-8?B?ZENhU2lMdHQ0MHFhOUMzTWlBVTN2MkZpZE1WV1R6T2NrczR4UXhWWjVUOWwy?= =?utf-8?B?SlNuNjZlTlVMRGJJa2JhMlV6R2R2NmZhZCtUaHArMzFKbVdULy83dW9Xb0Nh?= =?utf-8?B?ZXBBNUg3d0ZDc2EwOWttYVYzKy9LdFJZc1VxQWdrTkNCK1ZjeGUwRVpxSGFE?= =?utf-8?B?SnhnUS93bWNuQmtyUnVwT0t4UjlNVC84bzYyQnNHQWxWUWZxYm5qek5qa2lo?= =?utf-8?B?WXZJK0ZYTEdsTHk5S25oRllpL0g2OUU5SExXZWdaWUk4K0FOSlVRb2dQR2lO?= =?utf-8?B?TDNpeXpRR1lLVDd2Q2JVeG1WMlg3aWtadk80b2ZZeVRramo3Y0xod2hDdFgy?= =?utf-8?B?SXltbzNVTXgxazJzL3dFRERkWmxOYzVSWE5LUDhHMHBoRUxrSk5idGdGSVdW?= =?utf-8?B?alVxNW5BQUtKa3dEZDhuekhqZlBISXJzL0lTN2VqanVmTWhFVWZDTm4wZmp2?= =?utf-8?Q?ay+vJ5OjbaIVV2LYC+TSgzo=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: cb92e64e-59c5-4160-d618-08d99a400137 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2021 18:23:14.1285 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JMlppguKXnCx7OfZij872spv+WWyv/E3fvae9HcoxpDAjHJtJcyDsuoe3lMZhcVwpfS6Ju1xYBapYCiW1TKYUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5016 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix MTU configuration before device start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/25/2021 7:06 PM, Ajit Khaparde wrote: > On Sun, Oct 24, 2021 at 9:42 AM Andrew Rybchenko > wrote: >> >> There is no point to do rte_eth_dev_mtu_set() before configure since >> set MTU value is overwritten on configure anyway. So, setting of MTU >> before configure is rejected now on ethdev level. >> >> If testpmd is going to do configure (e.g. just after testpmd start >> with disabled devices start up or any configuration changes in stopped >> state which require reconfigure), just save requested MTU in device >> config to be applied on reconfigure. >> >> Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length") >> Fixes: be0433cf953c ("ethdev: forbid MTU set before device configure") >> >> Signed-off-by: Andrew Rybchenko > Acked-by: Ajit Khaparde > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.