From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5158C5F29 for ; Wed, 25 Apr 2018 19:34:55 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2018 10:34:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,327,1520924400"; d="scan'208";a="223364752" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.42]) ([10.237.221.42]) by fmsmga006.fm.intel.com with ESMTP; 25 Apr 2018 10:34:52 -0700 To: Adrien Mazarguil , Thomas Monjalon , dev@dpdk.org References: <20180419100848.6178-1-adrien.mazarguil@6wind.com> <20180425151852.7676-1-adrien.mazarguil@6wind.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= xsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsF+BBMBAgAoAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAUCWZR3VQUJB33WBQAKCRD5M+tD3xNhH6DWEACVhEb8q1epPwZrUDoxzu7E TS1b8tmabOmnjXZRs6+EXgUVHkp2xxkCfDmL3pa5bC0G/74aJnWjNsdvE05V1cb4YK4kRQ62 FwDQ+hlrFrwFB3PtDZk1tpkzCRHvJgnIil+0MuEh32Y57ig6hy8yO8ql7Lohyrnpfk/nNpm4 jQGEF5qEeHcEFe1AZQlPHN/STno8NZSz2nl0b2cw+cujN1krmvB52Ah/2KugQ6pprVyrGrzB c34ZQO9OsmSjJlETCZk6EZzuhfe16iqBFbOSadi9sPcJRwaUQBid+xdFWl7GQ8qC3zNPibSF HmU43yBZUqJDZlhIcl6/cFpOSjv2sDWdtjEXTDn5y/0FsuY0mFE78ItC4kCTIVk17VZoywcd fmbbnwOSWzDq7hiUYuQGkIudJw5k/A1CMsyLkoUEGN3sLfsw6KASgS4XrrmPO4UVr3mH5bP1 yC7i1OVNpzvOxtahmzm481ID8sk72GC2RktTOHb0cX+qdoiMMfYgo3wRRDYCBt6YoGYUxF1p msjocXyqToKhhnFbXLaZlVfnQ9i2i8jsj9SKig+ewC2p3lkPj6ncye9q95bzhmUeJO6sFhJg Hiz6syOMg8yCcq60j07airybAuHIDNFWk0gaWAmtHZxLObZx2PVn2nv9kLYGohFekw0AOsIW ta++5m48dnCoAc7BTQRX1ky+ARAApzQNvXvE2q1LAS+Z+ni2R13Bb1cDS1ZYq1jgpR13+OKN ipzd8MPngRJilXxBaPTErhgzR0vGcNTYhjGMSyFIHVOoBq1VbP1a0Fi/NqWzJOowo/fDfgVy K4vuitc/gCJs+2se4hdZA4EQJxVlNM51lgYDNpjPGIA43MX15OLAip73+ho6NPBMuc5qse3X pAClNhBKfENRCWN428pi3WVkT+ABRTE0taxjJNP7bb+9TQYNRqGwnGzX5/XISv44asWIQCaq vOkXSUJLd//cdVNTqtL1wreCVVR5pMXj7VIrlk07fmmJVALCmGbFr53BMb8O+8dgK2A5mitM n44d+8KdJWOwziRxcaMk/LclmZS3Iv1TERtiWt98Y9AjeAtcgYPkA3ld0BcUKONogP8pHVz1 Ed3s5rDQ91yr1S0wuAzW91fxGUO4wY+uPmxCtFVuBgd9VT9NAKTUL0qHM7CDgCnZPe0TW6Zj 8OqtdCCyAfvU9cW5xWM7Icxhde6AtPxhDSBwE8fL2ZmrDmaA4jmUKXp3i4JxRPSX84S08b+s DWXHPxy10UFU5A7EK/BEbZAKBwn9ROfm+WK+6X5xOGLoRE++OqNuUudxC1GDyLOPaqCbBCS9 +P6HsTHzxsjyJa27n4jcrcuY3P9TEcFJYSZSeSDh8mVGvugi0exnSJrrBZDyVCcAEQEAAcLB ZQQYAQIADwIbDAUCWZR1ZwUJA59cIQAKCRD5M+tD3xNhH5b+D/9XG44Ci6STdcA5RO/ur05J EE3Ux1DCHZ5V7vNAtX/8Wg4l4GZfweauXwuJ1w7Sp7fklwcNC6wsceI+EmNjGMqfIaukGetG +jBGqsQ7moOZodfXUoCK98gblKgt/BPYMVidzlGC8Q/+lZg1+o29sPnwImW+MXt/Z5az/Z17 Qc265g+p5cqJHzq6bpQdnF7Fu6btKU/kv6wJghENvgMXBuyThqsyFReJWFh2wfaKyuix3Zyj ccq7/blkhzIKmtFWgDcgaSc2UAuJU+x9nuYjihW6WobpKP/nlUDu3BIsbIq09UEke+uE/QK+ FJ8PTJkAsXOf1Bc2C0XbW4Y2hf103+YY6L8weUCBsWC5VH5VtVmeuh26ENURclwfeXhWQ9Og 77yzpTXWr5g1Z0oLpYpWPv745J4bE7pv+dzxOrFdM1xNkzY2pvXph/A8OjxZNQklDkHQ7PIB Lki5L2F4XkEOddUUQchJwzMqTPsggPDmGjgLZrqgO+s4ECZK5+nLD3HEpAbPa3JLDaScy+90 Nu1lAqPUHSnP3vYZVw85ZYm6UCxHE4VLMnnJsN09ZhsOSVR+GyP5Nyw9rT1V3lcsuH7M5Naa 2Xobn9m7l9bRCD/Ji8kG15eV1WTxx1HXVQGjdUYDI7UwegBNbwMLh17XDy+3sn/6SgcqtECA Q6pZKA2mTQxEKMLBZQQYAQIADwIbDAUCWZR3hQUJA59eRwAKCRD5M+tD3xNhH4a/D/4jLAZu UhvU1swWcNEVVCELZ0D3LOV14XcY2MXa3QOpeZ9Bgq7YYJ4S5YXK+SBQS0FkRZdjGNvlGZoG ZdpU+NsQmQFhqHGwX0IT9MeTFM8uvKgxNKGwMVcV9g0IOqwBhGHne+BFboRA9362fgGW5AYQ zT0mzzRKEoOh4r3AQvbM6kLISxo0k1ujdYiI5nj/5WoKDqxTwwfuN1uDUHsWo3tzenRmpMyU NyW3Dc+1ajvXLyo09sRRq7BnM99Rix1EGL8Qhwy+j0YAv+FuspWxUX9FxXYho5PvGLHLsHfK FYQ7x/RRbpMjkJWVfIe/xVnfvn4kz+MTA5yhvsuNi678fLwY9hBP0y4lO8Ob2IhEPdfnTuIs tFVxXuelJ9xAe5TyqP0f+fQjf1ixsBZkqOohsBXDfje0iaUpYa/OQ/BBeej0dUdg2JEu4jAC x41HpVCnP9ipLpD0fYz1d/dX0F/VY2ovW6Eba/y/ngOSAR6C+u881m7oH2l0G47MTwkaQCBA bLGXPj4TCdX3lftqt4bcBPBJ+rFAnJmRHtUuyyaewBnZ81ZU2YAptqFM1kTh+aSvMvGhfVsQ qZL2rk2OPN1hg+KXhErlbTZ6oPtLCFhSHQmuxQ4oc4U147wBTUuOdwNjtnNatUhRCp8POc+3 XphVR5G70mnca1E2vzC77z+XSlTyRA== Message-ID: <61d46aea-12a0-9bc8-d09a-2639fed4bbc6@intel.com> Date: Wed, 25 Apr 2018 18:34:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180425151852.7676-1-adrien.mazarguil@6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 00/16] Flow API overhaul for switch offloads X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 17:34:56 -0000 On 4/25/2018 4:27 PM, Adrien Mazarguil wrote: > As summarized in a prior RFC [1], the flow API (rte_flow) was chosen as a > means to manage switch offloads supported by many devices (usually going by > names such as E-Switch or vSwitch) through user-specified flow rules. > > Combined with the need to support encap/decap actions, this requires a > change in the way flow actions are processed (in order and possibly > repeated) which modifies the behavior of some of the existing actions, thus > warranting a major ABI breakage. > > Given this ABI breakage is also required by other work submitted for the > current release [2][3], this series addresses various longstanding issues > with the flow API and makes minor improvements in preparation for upcoming > features. > > Changes summary: > > - Additional error types. > - Clearer documentation. > - Improved C++ compatibility. > - Exhaustive RSS action. > - Consistent behavior of VLAN pattern item. > - New "transfer" attribute bringing consistency to VF/PF pattern items. > - Confusing "PORT" pattern item renamed "PHY_PORT", with new action > counterpart. > - New "PORT_ID" pattern item and action to be used with port representors. > > This series piggybacks on the major ABI update introduced by a prior > commit [4] for DPDK 18.05 and depends on several fixes [5] which must be > applied first. > > [1] "[RFC] Switch device offload with DPDK" > http://dpdk.org/ml/archives/dev/2018-March/092513.html > > [2] commit 676b605182a5 ("doc: announce ethdev API change for RSS > configuration") > > [3] "[PATCH v1 00/21] MLX5 tunnel Rx offloading" > http://dpdk.org/ml/archives/dev/2018-March/092264.html > > [4] commit 653e038efc9b ("ethdev: remove versioning of filter control > function") > > [5] "[PATCH v6 00/11] Bunch of flow API-related fixes" > http://dpdk.org/ml/archives/dev/2018-April/098035.html > > v6 changes: > > - Fixed mlx5 issue raised by Nelio in "ethdev: flatten RSS configuration in > flow API". > - Updated release notes (API update / ABI breakage) in relevant patches. > - Removed Xueming's deprecation notice in "ethdev: add encap level to RSS > flow API action" since it's covered by this series. > - Reworded a few patches as fixes since they address API flaws. > - Rebased series once again. > > v5 changes: > > - Fixed errors reported by GCC and Clang in patch 05/16 ("ethdev: alter > behavior of flow API actions"). > - Rebased series once again. > > v4 changes: > > - No change besides new acked-by lines, rebased series to address conflicts. > > v3 changes: > > - Rebased series, fixed latest conflicts. > - Addressed Andrew's comments, see affected patches for details: > - Empty RSS types in flow rule means PMD-specific RSS instead of no RSS. > - RSS hash function now explicitly compared against > RTE_ETH_HASH_FUNCTION_DEFAULT instead of 0 in all PMDs. > - sfc PMD updated to also accept Toeplitz. > - Implicit VLAN TPID matching now removed from all PMDs. > - Default mask upate for VLAN TCI now split as separate patch #11. > - Ingress/egress definition clarified in patch #12. > > v2 changes: > > - Squashed "ethdev: update ABI for flow API functions" in subsequent > patches. > - Emphasized ABI impact in relevant commit logs. > - Modified documentation in "ethdev: alter behavior of flow API actions" to > describe how terminating flow rules without any action of the fate kind > result in undefined behavior instead of dropping traffic. > - Fixed other minor documentation formatting issues. > - Modified "ethdev: refine TPID handling in flow API" as follows: > - Using standard macro definitions for VLAN, QinQ and E-Tag EtherTypes. > - Fixed endian conversion in sfc. > - Replaced a condition in VLAN pattern item processing with an assertion > check for i40e. > > Adrien Mazarguil (16): > ethdev: add error types to flow API > ethdev: clarify flow API pattern items and actions > doc: remove flow API migration section > ethdev: remove DUP action from flow API > ethdev: alter behavior of flow API actions > ethdev: fix C99 flexible arrays from flow API > ethdev: flatten RSS configuration in flow API > ethdev: add hash function to RSS flow API action > ethdev: add encap level to RSS flow API action > ethdev: fix TPID handling in flow API > ethdev: fix default VLAN TCI mask in flow API > ethdev: add transfer attribute to flow API > ethdev: fix behavior of VF/PF in flow API > ethdev: rename physical port item in flow API > ethdev: add physical port action to flow API > ethdev: add port ID item and action to flow API Series applied to dpdk-next-net/master, thanks.