From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ting Xu <ting.xu@intel.com>, dev@dpdk.org
Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com,
bernard.iremonger@intel.com, olivier.matz@6wind.com
Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: enable GTP header parse and Tx checksum offload
Date: Mon, 21 Oct 2019 11:52:46 +0100 [thread overview]
Message-ID: <61d640b1-23e9-f4c6-14c2-c7c25a5c8da5@intel.com> (raw)
In-Reply-To: <ff4b25f6-0ced-8288-e350-f65200407e2c@intel.com>
On 10/21/2019 10:28 AM, Ferruh Yigit wrote:
> On 10/21/2019 1:29 PM, Ting Xu wrote:
>> This patch enables testpmd to forward GTP packet in csum fwd mode.
>> GTP header structure (without optional fields and extension header)
>> and parser function are added. GTPU and GTPC packets are both
>> supported, with respective UDP destination port and GTP message
>> type.
>>
>> Signed-off-by: Ting Xu <ting.xu@intel.com>
>>
>> ---
>> v4: Move GTP header defination to rte_ether.h
>> v3: correct coding style issue.
>> v2: modify commit log
>> depend on patch: lib/mbuf: add GTP tunnel type flag.
>> ---
>> app/test-pmd/csumonly.c | 96 ++++++++++++++++++++++++++++++++++----
>> lib/librte_net/rte_ether.h | 23 +++++++++
>> 2 files changed, 109 insertions(+), 10 deletions(-)
>
> <...>
>
>> --- a/lib/librte_net/rte_ether.h
>> +++ b/lib/librte_net/rte_ether.h
>> @@ -342,6 +342,29 @@ struct rte_vxlan_gpe_hdr {
>> sizeof(struct rte_vxlan_gpe_hdr))
>> /**< VXLAN-GPE tunnel header length. */
>>
>> +/**
>> + * Simplified GTP protocol header.
>> + * Contains 8-bit flag, 8-bit message type,
>> + * 16-bit message length, 32-bit TEID.
>> + * No optional fields and next extension header.
>> + */
>> +struct rte_gtp_hdr {
>> + uint8_t gtp_hdr_info;
>> + uint8_t msg_type;
>> + uint16_t msg_len;
>> + uint32_t teid;
>> +} __attribute__((__packed__));
>> +
>> +/* GTP header length */
>> +#define RTE_ETHER_GTP_HLEN \
>> + (sizeof(struct rte_udp_hdr) + sizeof(struct rte_gtp_hdr))
>> +/* GTP next protocal type */
>> +#define RTE_GTP_TYPE_IPV4 0x40
>> +#define RTE_GTP_TYPE_IPV6 0x60
>> +/* GTP destination port number */
>> +#define RTE_GTPC_UDP_PORT 2123
>> +#define RTE_GTPU_UDP_PORT 2152
>> +
>> /**
>> * Extract VLAN tag information into mbuf
>> *
>>
>
> lgtm, @Oliver, any comment/objection on GTP part in rte_ether.h?
>
What about moving the defines to its own header, like rte_gtp? Is these defines
part of the ether?
next prev parent reply other threads:[~2019-10-21 10:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 15:26 [dpdk-dev] [PATCH v1] " Ting Xu
2019-10-17 16:15 ` [dpdk-dev] [PATCH v2] " Ting Xu
2019-10-18 16:08 ` [dpdk-dev] [PATCH v3] " Ting Xu
2019-10-18 18:49 ` Ferruh Yigit
2019-10-21 2:28 ` Xu, Ting
2019-10-21 12:29 ` [dpdk-dev] [PATCH v4] " Ting Xu
2019-10-21 9:28 ` Ferruh Yigit
2019-10-21 10:52 ` Ferruh Yigit [this message]
2019-10-21 16:50 ` Olivier Matz
2019-10-22 5:34 ` Xu, Ting
2019-10-22 12:29 ` [dpdk-dev] [PATCH v5] " Ting Xu
2019-10-22 8:14 ` Ferruh Yigit
2019-10-22 16:26 ` [dpdk-dev] [PATCH v6] " Ting Xu
2019-10-22 15:45 ` Ferruh Yigit
2019-10-23 17:23 ` Ferruh Yigit
2019-10-25 22:43 ` Thomas Monjalon
2019-10-26 17:42 ` Thomas Monjalon
2019-10-25 22:49 ` Thomas Monjalon
2019-10-28 1:35 ` Xu, Ting
2019-10-28 8:38 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61d640b1-23e9-f4c6-14c2-c7c25a5c8da5@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=olivier.matz@6wind.com \
--cc=ting.xu@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).